Patch Detail
Show a patch.
GET /api/patches/27540/?format=api
{ "id": 27540, "url": "https://patchwork.libcamera.org/api/patches/27540/?format=api", "web_url": "https://patchwork.libcamera.org/patch/27540/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<GvKebvBkGHCzFhlNwUSfIJUW9gp5XxHo3P_a6FlPrfUjTF-1hSOfx0ehW-rYw1iHW5W8hlDXm2EkcpyXVY8QNraLybfRMEHMWHvTmT2x29Y=@proton.me>", "date": "2026-08-02T13:59:56", "name": "[2/3] ipa: libipa: Add sensor helpers for the IMX582, IMX586 and OV8856", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "9c8417eeee4c2bf774ba76c0f4e97cac39e6ee68", "submitter": { "id": 484, "url": "https://patchwork.libcamera.org/api/people/484/?format=api", "name": "j4niwzis", "email": "j4niwzis@proton.me" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/27540/mbox/", "series": [ { "id": 6099, "url": "https://patchwork.libcamera.org/api/series/6099/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6099", "date": "2026-08-02T13:59:08", "name": "[1/3] libcamera: camera_sensor_properties: Add IMX582, IMX586 and OV8856", "version": 1, "mbox": "https://patchwork.libcamera.org/series/6099/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/27540/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/27540/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0A4E8C32FE\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 2 Aug 2026 14:00:02 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AC27E67FEC;\n\tSun, 2 Aug 2026 16:00:01 +0200 (CEST)", "from mail-24430.protonmail.ch (mail-24430.protonmail.ch\n\t[109.224.244.30])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 61EBE67FC1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 2 Aug 2026 16:00:00 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=proton.me header.i=@proton.me\n\theader.b=\"farcnuEi\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me;\n\ts=protonmail; t=1785679199; x=1785938399;\n\tbh=54WPUoLBtwtAbIYD2y9tB5oTjCRVcYjHBASUBFvYNX4=;\n\th=Date:To:From:Subject:Message-ID:Feedback-ID:From:To:Cc:Date:\n\tSubject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector;\n\tb=farcnuEiHUWcEouMHwaRo7o/AiCaE1Jn/6NYBX/r86JB5lIGkYG6mXXBXuYpMgFrk\n\tB1gyYMIgElk/GdgBiHJW/Dkjp6KzrfMAOcpyIA296tK4vDaAyJl/URyeIa0NQtR83V\n\t0JqTOjxSooMBikxMnRnQjSJWtWXSDgemT+22bSsRNz5j+11B/KGvyLAcZl/W4rQkvx\n\tApsAIHET26WZpzW+Cm/KlS8ZZY7TKv/H4M1ePDH4wmuPkRUW1HDFqgnnqTArz1h/Af\n\tguzVt1/C9Izi/TD2uah7uaT32uECC3NMlgdELQQVx2UZBphGtQcaQ3T37vGfp0r226\n\tKti+ypmE/uJFA==", "Date": "Sun, 02 Aug 2026 13:59:56 +0000", "To": "\"libcamera-devel@lists.libcamera.org\"\n\t<libcamera-devel@lists.libcamera.org>", "From": "j4niwzis <j4niwzis@proton.me>", "Subject": "[PATCH 2/3] ipa: libipa: Add sensor helpers for the IMX582,\n\tIMX586 and OV8856", "Message-ID": "<GvKebvBkGHCzFhlNwUSfIJUW9gp5XxHo3P_a6FlPrfUjTF-1hSOfx0ehW-rYw1iHW5W8hlDXm2EkcpyXVY8QNraLybfRMEHMWHvTmT2x29Y=@proton.me>", "Feedback-ID": "156040633:user:proton", "X-Pm-Message-ID": "cb2b0b5d2cdbfd608d67202ee14693d140214fb9", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=utf-8", "Content-Transfer-Encoding": "quoted-printable", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The Sony parts use the usual Sony analogue gain, 1024 / (1024 - code), andtheir black level is 0x40 at ten bits, which the software ISP needs in order\nnot to subtract the wrong pedestal - without it a dim scene comes out as a\nuniformly black frame.\n\nThe OV8856 gain is linear in 1/128 steps, as on the OV8858.\n\nSigned-off-by: j4niwzis <j4niwzis@proton.me>\n---\n--\n2.51.0", "diff": "diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n--- a/src/ipa/libipa/camera_sensor_helper.cpp\n+++ b/src/ipa/libipa/camera_sensor_helper.cpp\n@@ -654,6 +654,23 @@\n };\n REGISTER_CAMERA_SENSOR_HELPER(\"imx477\", CameraSensorHelperImx477)\n\n+class CameraSensorHelperImx586 : public CameraSensorHelper\n+{\n+public:\n+ CameraSensorHelperImx586()\n+ {\n+ /* From the register tables: 0x40 at 10 bits. */\n+ blackLevel_ = 4096;\n+ gain_ = AnalogueGainLinear{ 0, 1024, -1, 1024 };\n+ }\n+};\n+REGISTER_CAMERA_SENSOR_HELPER(\"imx586\", CameraSensorHelperImx586)\n+\n+class CameraSensorHelperImx582 : public CameraSensorHelperImx586\n+{\n+};\n+REGISTER_CAMERA_SENSOR_HELPER(\"imx582\", CameraSensorHelperImx582)\n+\n class CameraSensorHelperImx662 : public CameraSensorHelper\n {\n public:\n@@ -827,6 +844,16 @@\n };\n REGISTER_CAMERA_SENSOR_HELPER(\"ov64a40\", CameraSensorHelperOv64a40)\n\n+class CameraSensorHelperOv8856 : public CameraSensorHelper\n+{\n+public:\n+ CameraSensorHelperOv8856()\n+ {\n+ gain_ = AnalogueGainLinear{ 1, 0, 0, 128 };\n+ }\n+};\n+REGISTER_CAMERA_SENSOR_HELPER(\"ov8856\", CameraSensorHelperOv8856)\n+\n class CameraSensorHelperOv8858 : public CameraSensorHelper\n {\n public:\n", "prefixes": [ "2/3" ] }