Patch Detail
Show a patch.
GET /api/patches/27531/?format=api
{ "id": 27531, "url": "https://patchwork.libcamera.org/api/patches/27531/?format=api", "web_url": "https://patchwork.libcamera.org/patch/27531/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<CALr1FG-kFkSwsXtwCegRtHcCcD1Q+-483g_FFAVWabpa1fD49Q@mail.gmail.com>", "date": "2026-07-31T15:15:47", "name": "[v4,1/2] libipa: camera_sensor_helper: Add imx471", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "85076e13057d1408688de336af1d97d8ed3bc24e", "submitter": { "id": 476, "url": "https://patchwork.libcamera.org/api/people/476/?format=api", "name": "John Cronin", "email": "john@stromback.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/27531/mbox/", "series": [ { "id": 6097, "url": "https://patchwork.libcamera.org/api/series/6097/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6097", "date": "2026-07-31T15:15:05", "name": "Add imx471 soft-ISP sensor support", "version": 4, "mbox": "https://patchwork.libcamera.org/series/6097/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/27531/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/27531/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0A45BBDE4C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 31 Jul 2026 15:15:53 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AB20067FDD;\n\tFri, 31 Jul 2026 17:15:52 +0200 (CEST)", "from mail-yw1-x1130.google.com (mail-yw1-x1130.google.com\n\t[IPv6:2607:f8b0:4864:20::1130])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1A9EA67FD6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 31 Jul 2026 17:15:51 +0200 (CEST)", "by mail-yw1-x1130.google.com with SMTP id\n\t00721157ae682-81f36179dd5so15372457b3.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 31 Jul 2026 08:15:51 -0700 (PDT)", "from 313336824172 named unknown by gmailapi.google.com with\n\tHTTPREST; Fri, 31 Jul 2026 08:15:47 -0700", "from 313336824172 named unknown by gmailapi.google.com with\n\tHTTPREST; Fri, 31 Jul 2026 08:15:47 -0700" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=stromback-com.20251104.gappssmtp.com\n\theader.i=@stromback-com.20251104.gappssmtp.com\n\theader.b=\"wYE9Pnnt\"; dkim-atps=neutral", "ARC-Seal": "i=1; a=rsa-sha256; t=1785510950; cv=none;\n\td=google.com; s=arc-20260327;\n\tb=P8kLz1MEgSfaq7PRY6vVNit2G3olOvHMrBiAPNNMFHhay6PBqr9hplsRGsC0UFbn/B\n\thXvhVqbQACPY1eDtHa3WW7xlTMOFqzmWUyEZY+2tuNWlAG0s3AlUU16oiGxISFM5pLX2\n\tbSMh8l5uP4eE6PjFEm+qjqZij2iSvA3n3sGUnjbMMEBzUKui8CUL9dssxAyUKu5NxjGZ\n\tQ5mnZmXmq3zoBkcBktWCTkJXwll4yU9UfEJ01QdKOEna+aVIhjR5jLQyMCtJLqJ3Rk9C\n\t2Szu/3EpAgPrMuJu/rndUFzc0C3NOeAyaUK5ImhelCzCjqIZ5XI302hPrKZyOq2/ozfO\n\tAk9A==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=arc-20260327; \n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:references:in-reply-to:mime-version:dkim-signature;\n\tbh=P3yoEcdeGmBg/V29K56JuO8/m29KqWa6+sXw4ueDDXA=;\n\tfh=hN8mNPnxBXjCARLz6VoZGvcnfJs454t5dBv/gP0fGlc=;\n\tb=WfxbCFJZUm+ZAY2zerkYCSLa2c+avJ4JnNpek8sYlZJpkeGVLwnVpfyesmrxFaQigy\n\t6ssYLllMRuWIrgHGfNhRQCaLx73lub9tt9BG2GM8JKcn3scL58xEEd07nyYFISSdEbqB\n\t3HscKVtII0/a+KD/Kmi94qEfpB8Ez762YbAmOdGDm0KLl94bYW8v9HQ+MEI9hyv33VZR\n\tZlGNM59tfzGuzyW2VrxJQFz6KGxhTq8PPCROeB16tNYEJ6KMdj4AFiaC3T7N9WyQ9jWg\n\tSDuOEP+irtpRTo10BLvKJkbOjjFUBQxvDWjpb2UWhbt2eTK1O1NnjNou2ddSzAazLpU0\n\t7SaQ==; darn=lists.libcamera.org", "ARC-Authentication-Results": "i=1; mx.google.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=stromback-com.20251104.gappssmtp.com; s=20251104; t=1785510950;\n\tx=1786115750; darn=lists.libcamera.org; \n\th=content-transfer-encoding:content-type:cc:to:subject:message-id\n\t:date:from:references:in-reply-to:mime-version:from:to:cc:subject\n\t:date:message-id:reply-to:content-type;\n\tbh=P3yoEcdeGmBg/V29K56JuO8/m29KqWa6+sXw4ueDDXA=;\n\tb=wYE9PnntvxughsMH2MLDE6XR/jGfu+PA2p9l7BON7PSJi0p4/KOa0LSCESWz1IkCON\n\tYh2uKxZIAQ5P8VOlLb1xO7sgyD7i3TVRSzz8HDBR8ZyFY0cY/jBjpoHDMqYxeoRuoXl/\n\thzeG4rfIU29slZa01J+Z+2aPnoL1ck4eSTW8qcMsLff5D7hg7vJ31jmWI3Jk1L1osBXt\n\t7SXsxS/YpxBgPlLNJiQSB8dHo4S8+QXRAqCt9lmASzMsA7CTP+iQGkGXBZNgd0+QiAl3\n\t1lcjUA786CXrROCbuO0T9CmkmUVJPRbRaQ6XHTzLUOsn6L5j1zo/4wqFV7LRLqpzpKtJ\n\t+v7Q==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20251104; t=1785510950; x=1786115750;\n\th=content-transfer-encoding:content-type:cc:to:subject:message-id\n\t:date:from:references:in-reply-to:mime-version:x-gm-gg\n\t:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to\n\t:content-type;\n\tbh=P3yoEcdeGmBg/V29K56JuO8/m29KqWa6+sXw4ueDDXA=;\n\tb=PiY8xe3cWiiPQl+iM/C08OPNopbhB3PoGKNR+leqMBm5Jckib2UWr288R5XTuww0q8\n\tbFfFuQE5yW2/xT/i5fmcXawN2b6fHkwqpYneIew3PcjyLK2McFvzaI79DXP3wz2VyetT\n\tjLtakNLqIgmnq9xsj091e0sljeUJxQHH/EGZNWNe58aXem2jxX17hwCKiIKg1C5eX7hY\n\tGWwapSoUKBWdBg6V6OYQRIvGS770Duv27Gt5jdFEpREU0/mU7zCoIGof7pIMzMDSPQ+M\n\tDJJY8ooTaiL5IZS5vAaMnOhJuUcwEBuZ05jdzXdVoMAxA7tKOFaOB4bZN8SSOjewW5Ty\n\tnJ2w==", "X-Gm-Message-State": "AOJu0YwuBrmIlGeN7lFdrhGIUhrbB1PsDnceO+3nzqouuWxYdZr4Llm/\n\tpJSHhSAHvQIfVkJ8E02d2dpZ7SEweW1CRRKwLpgeHiSdLpdmzhxvqaGiJCEERQm6f3ngO1fvShE\n\t9HUaAFqLanxVNZvlIiJ7NFzqf2JpFo9f5Ra2ddIO0cNS+j2pU11ik1OY=", "X-Gm-Gg": "AR+sD13/tLlSSh7z2ELGpKGBVmN946KJri12xvorZ+cRJd7ofXHcZLMXFhWc9YQNLMm\n\tGcLJuMdFnBP4v4rn5VCxj/yF+iS9fN1GuSoFRBAqyipkXGTnDKv7h57Ns+9+mAE0KK6drobmWAi\n\tIjiuJpxCDwgTn5furDOD73k4Awzzm8AS/m94oKhm/iIY5N3xFLd4VXnOC2B7SXvYOdq2jFzD9s+\n\t6/kMLpX+RdYscyfyRWxWpHB+wSsfKyav+JgPQbHfrq7HIViwGlExrkD3pTcPYBzICH/MQU5K0tY\n\tl/2nKI/81Wej2RX7kYYUMfB6JCw0ZZAzvXquElSCrOJNSjevbu/fHb0JhZ9DLNnEvvcPUngJeBx\n\t+cydgnkabkyIAduAVvDMN6eXmRy8OBef0Rf/XnMmjpXz2NMWpOUraKup1Cm3wPWAudp/73/UlDv\n\ttIp1Fn/zxvZGId9zQxAOToLGwG7kykfjKA1TvVCyKTDZgO6ohfGp8ZEnX+r7prNffnq//aWq88N\n\tXtRO+FVH2dWHNmoNYAkscrknFv2G0YPCSRkt0H1aw==", "X-Received": "by 2002:a05:690c:6885:b0:7cf:d242:d94a with SMTP id\n\t00721157ae682-81fd4bd0126mr2343417b3.25.1785510948447;\n\tFri, 31 Jul 2026 08:15:48 -0700 (PDT)", "MIME-Version": "1.0", "In-Reply-To": "<CALr1FG__gS_agbUnB5iWZ8wQypxdJch_UHziw2xuuG5Axp3vtQ@mail.gmail.com>", "References": "<CALr1FG__gS_agbUnB5iWZ8wQypxdJch_UHziw2xuuG5Axp3vtQ@mail.gmail.com>", "From": "John Cronin <john@stromback.com>", "Date": "Fri, 31 Jul 2026 08:15:47 -0700", "X-Gm-Features": "AUfX_myy8V3kTbfcsSXXJc7tOtRjpnk8XlCAiltpCn7ShWWYZ5ZmwdaiO-tMRy0", "Message-ID": "<CALr1FG-kFkSwsXtwCegRtHcCcD1Q+-483g_FFAVWabpa1fD49Q@mail.gmail.com>", "Subject": "[PATCH v4 1/2] libipa: camera_sensor_helper: Add imx471", "To": "libcamera-devel@lists.libcamera.org", "Cc": "jacopo.mondi@ideasonboard.com, kieran.bingham@ideasonboard.com", "Content-Type": "text/plain; charset=\"UTF-8\"", "Content-Transfer-Encoding": "quoted-printable", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add CameraSensorHelper for Sony IMX471 (SONY471A), used on Lenovo\nThinkPad X9 / X1 Carbon Gen14 and related IPU7 platforms.\n\nThe kernel imx471 driver writes V4L2_CID_ANALOGUE_GAIN codes 0..800\ndirectly to register 0x0204.\n\nAnalogue gain model (measured on ThinkPad X9-15 Gen 1, Fedora 44,\nkernel 7.1.5): fixed-exposure raw Bayer means track\n\n G = 1024 / (1024 - code)\n\nwithin ~1.5% over codes 0..800 (best-fit k≈1023 for G=k/(k-code)).\nCode 800 implies ~4.57x; that is the driver's V4L2 max under this\nmodel, not a full-scale datasheet claim. Other IMX helpers using the\nsame formula expose higher max codes (e.g. imx355 960 → ~16x).\n\nBlack level measured ~64 DN at 10-bit on min exposure/gain raw frames\n(mean ≈ 64.1, p50 = 64) → 4096 at 16-bit.\n\nSoft-ISP loads without \"Failed to create camera sensor helper for\nimx471\".\n\nSigned-off-by: John Cronin <john.cronin@opcenter.com>\n---\n src/ipa/libipa/camera_sensor_helper.cpp | 29 +++++++++++++++++++++++++\n 1 file changed, 29 insertions(+)\n\n public:", "diff": "diff --git a/src/ipa/libipa/camera_sensor_helper.cpp\nb/src/ipa/libipa/camera_sensor_helper.cpp\nindex cc16e25..31d8169 100644\n--- a/src/ipa/libipa/camera_sensor_helper.cpp\n+++ b/src/ipa/libipa/camera_sensor_helper.cpp\n@@ -644,6 +644,35 @@ class CameraSensorHelperImx462 : public\nCameraSensorHelperImx290\n };\n REGISTER_CAMERA_SENSOR_HELPER(\"imx462\", CameraSensorHelperImx462)\n\n+class CameraSensorHelperImx471 : public CameraSensorHelper\n+{\n+public:\n+\tCameraSensorHelperImx471()\n+\t{\n+\t\t/*\n+\t\t * Sony IMX471 (IPU7 platforms: ThinkPad X9 / X1 Carbon Gen14,\n+\t\t * ACPI SONY471A).\n+\t\t *\n+\t\t * Kernel imx471 writes V4L2_CID_ANALOGUE_GAIN directly to\n+\t\t * register 0x0204 with range 0..800 (IMX471_ANA_GAIN_MIN/MAX).\n+\t\t *\n+\t\t * Analogue gain model (measured on ThinkPad X9-15 Gen 1):\n+\t\t * G = 1024 / (1024 - code)\n+\t\t * Fixed exposure raw Bayer means (black-subtracted) track this\n+\t\t * model within ~1.5% over codes 0..800 (best-fit k≈1023 for\n+\t\t * G=k/(k-code)). Code 800 → ~4.57x is the driver max, not a\n+\t\t * datasheet \"full range\" claim; other IMX helpers with the same\n+\t\t * formula use higher max codes (e.g. imx355 code 960 → ~16x).\n+\t\t *\n+\t\t * Black level: measured ~64 DN at 10-bit on min exposure/gain\n+\t\t * raw frames (mean≈64.1, p50=64) → 4096 at 16-bit.\n+\t\t */\n+\t\tblackLevel_ = 4096;\n+\t\tgain_ = AnalogueGainLinear{ 0, 1024, -1, 1024 };\n+\t}\n+};\n+REGISTER_CAMERA_SENSOR_HELPER(\"imx471\", CameraSensorHelperImx471)\n+\n class CameraSensorHelperImx477 : public CameraSensorHelper\n {\n", "prefixes": [ "v4", "1/2" ] }