Patch Detail
Show a patch.
GET /api/patches/2752/?format=api
{ "id": 2752, "url": "https://patchwork.libcamera.org/api/patches/2752/?format=api", "web_url": "https://patchwork.libcamera.org/patch/2752/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200129033210.278800-19-nicolas@ndufresne.ca>", "date": "2020-01-29T03:32:05", "name": "[libcamera-devel,v1,18/23] gst: libcamerapad: Allow storing a pool", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "f4a94459ef5e4087269257adb0c505be940128a6", "submitter": { "id": 30, "url": "https://patchwork.libcamera.org/api/people/30/?format=api", "name": "Nicolas Dufresne", "email": "nicolas@ndufresne.ca" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/2752/mbox/", "series": [ { "id": 648, "url": "https://patchwork.libcamera.org/api/series/648/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=648", "date": "2020-01-29T03:31:47", "name": "GStreamer Element for libcamera", "version": 1, "mbox": "https://patchwork.libcamera.org/series/648/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/2752/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/2752/checks/", "tags": {}, "headers": { "Return-Path": "<nicolas@ndufresne.ca>", "Received": [ "from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 73E4F608C6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 29 Jan 2020 04:35:40 +0100 (CET)", "from nicolas-tpx395.localdomain (unknown\n\t[IPv6:2002:c0de:c115:0:66fc:8b:2a38:8313])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits))\n\t(No client certificate requested) (Authenticated sender: nicolas)\n\tby bhuna.collabora.co.uk (Postfix) with ESMTPSA id 6FC0C28EA9F;\n\tWed, 29 Jan 2020 03:35:39 +0000 (GMT)" ], "From": "Nicolas Dufresne <nicolas@ndufresne.ca>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Nicolas Dufresne <nicolas.dufresne@collabora.com>", "Date": "Tue, 28 Jan 2020 22:32:05 -0500", "Message-Id": "<20200129033210.278800-19-nicolas@ndufresne.ca>", "X-Mailer": "git-send-email 2.24.1", "In-Reply-To": "<20200129033210.278800-1-nicolas@ndufresne.ca>", "References": "<20200129033210.278800-1-nicolas@ndufresne.ca>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v1 18/23] gst: libcamerapad: Allow storing\n\ta pool", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Wed, 29 Jan 2020 03:35:40 -0000" }, "content": "From: Nicolas Dufresne <nicolas.dufresne@collabora.com>\n\nThis add get/set helper to store a pool on the pad.\n\nSigned-off-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>\n---\n src/gstreamer/gstlibcamerapad.cpp | 18 ++++++++++++++++++\n src/gstreamer/gstlibcamerapad.h | 6 ++++++\n 2 files changed, 24 insertions(+)", "diff": "diff --git a/src/gstreamer/gstlibcamerapad.cpp b/src/gstreamer/gstlibcamerapad.cpp\nindex b18584c..b9e6dc5 100644\n--- a/src/gstreamer/gstlibcamerapad.cpp\n+++ b/src/gstreamer/gstlibcamerapad.cpp\n@@ -16,6 +16,7 @@ using namespace libcamera;\n struct _GstLibcameraPad {\n \tGstPad parent;\n \tStreamRole role;\n+\tGstLibcameraPool *pool;\n };\n \n enum {\n@@ -107,3 +108,20 @@ gst_libcamera_pad_get_role(GstPad *pad)\n \tGST_OBJECT_LOCKER(self);\n \treturn self->role;\n }\n+\n+GstLibcameraPool *\n+gst_libcamera_pad_get_pool(GstPad *pad)\n+{\n+\tauto *self = GST_LIBCAMERA_PAD(pad);\n+\treturn self->pool;\n+}\n+\n+void\n+gst_libcamera_pad_set_pool(GstPad *pad, GstLibcameraPool *pool)\n+{\n+\tauto *self = GST_LIBCAMERA_PAD(pad);\n+\t\n+\tif (self->pool)\n+\t\tg_object_unref(self->pool);\n+\tself->pool = pool;\n+}\ndiff --git a/src/gstreamer/gstlibcamerapad.h b/src/gstreamer/gstlibcamerapad.h\nindex 3dea0e7..4570c0c 100644\n--- a/src/gstreamer/gstlibcamerapad.h\n+++ b/src/gstreamer/gstlibcamerapad.h\n@@ -9,6 +9,8 @@\n #include <gst/gst.h>\n #include <libcamera/stream.h>\n \n+#include \"gstlibcamerapool.h\"\n+\n #ifndef __GST_LIBCAMERA_PAD_H__\n #define __GST_LIBCAMERA_PAD_H__\n \n@@ -18,4 +20,8 @@ G_DECLARE_FINAL_TYPE(GstLibcameraPad, gst_libcamera_pad,\n \n libcamera::StreamRole gst_libcamera_pad_get_role(GstPad *pad);\n \n+GstLibcameraPool *gst_libcamera_pad_get_pool(GstPad *pad);\n+\n+void gst_libcamera_pad_set_pool(GstPad *pad, GstLibcameraPool *pool);\n+\n #endif /* __GST_LIBCAMERA_PAD_H__ */\n", "prefixes": [ "libcamera-devel", "v1", "18/23" ] }