Patch Detail
Show a patch.
GET /api/patches/27484/?format=api
{ "id": 27484, "url": "https://patchwork.libcamera.org/api/patches/27484/?format=api", "web_url": "https://patchwork.libcamera.org/patch/27484/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260723154327.1357866-36-barnabas.pocze@ideasonboard.com>", "date": "2026-07-23T15:43:18", "name": "[RFC,v2,35/43] ipa: simple: agc: Use `Histogram`", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "57f2c85f08f488e67c51e70636f0fae74bf384f1", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/27484/mbox/", "series": [ { "id": 6075, "url": "https://patchwork.libcamera.org/api/series/6075/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6075", "date": "2026-07-23T15:42:43", "name": "ipa: libipa: agc rework", "version": 2, "mbox": "https://patchwork.libcamera.org/series/6075/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/27484/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/27484/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A64FAC3338\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 23 Jul 2026 15:44:21 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 29FD267F4A;\n\tThu, 23 Jul 2026 17:44:21 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 65E1867EE2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 23 Jul 2026 17:43:39 +0200 (CEST)", "from pb-laptop.local (185.182.215.156.nat.pool.zt.hu\n\t[185.182.215.156])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8D63623B9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 23 Jul 2026 17:42:38 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Ob4oGJRf\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1784821358;\n\tbh=E985DDPrSQTUb2R+O+XZ6N1q8b6Z6AIwpAePZa0yVVk=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=Ob4oGJRfQPL9HFqXhEW90r9h0EgeF98L1QH1EwaNcsXX30twajdrN02acsaR+5EIl\n\tCttQqmIqypmJjcmLKRgiWOismsjDi1FeT61rX05HPb3o/XJuLw+wYTCSwR6u63z43l\n\tTqpnQ64wmV+Fm+UX0DB4K+5QEo6uftkEARZHKacQ=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[RFC PATCH v2 35/43] ipa: simple: agc: Use `Histogram`", "Date": "Thu, 23 Jul 2026 17:43:18 +0200", "Message-ID": "<20260723154327.1357866-36-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.55.0", "In-Reply-To": "<20260723154327.1357866-1-barnabas.pocze@ideasonboard.com>", "References": "<20260723154327.1357866-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Use the generic `Histogram` type. This is needed to decouple the\nimplementation from the software isp, in order to make this usable\nby other components.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n src/ipa/simple/algorithms/agc.cpp | 10 ++++++----\n 1 file changed, 6 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/ipa/simple/algorithms/agc.cpp b/src/ipa/simple/algorithms/agc.cpp\nindex b25c303835..cc33b269bf 100644\n--- a/src/ipa/simple/algorithms/agc.cpp\n+++ b/src/ipa/simple/algorithms/agc.cpp\n@@ -14,6 +14,8 @@\n \n #include <libcamera/base/log.h>\n \n+#include <libipa/histogram.h>\n+\n #include \"control_ids.h\"\n \n namespace libcamera {\n@@ -64,16 +66,16 @@ static constexpr float kExpMaxStep = 0.15;\n \n namespace {\n \n-std::optional<float> calculateMSV(const SwIspStats::Histogram &histogram, uint8_t blackLevel)\n+std::optional<float> calculateMSV(const Histogram &histogram, uint8_t blackLevel)\n {\n \t/*\n \t * Calculate Mean Sample Value (MSV) according to formula from:\n \t * https://www.araa.asn.au/acra/acra2007/papers/paper84final.pdf\n \t */\n \tconst unsigned int blackLevelHistIdx =\n-\t\tblackLevel / (256 / SwIspStats::kYHistogramSize);\n+\t\tblackLevel * histogram.bins() / 256;\n \tconst unsigned int histogramSize =\n-\t\tSwIspStats::kYHistogramSize - blackLevelHistIdx;\n+\t\thistogram.bins() - blackLevelHistIdx;\n \tconst unsigned int yHistValsPerBin = histogramSize / kExposureBinsCount;\n \tconst unsigned int yHistValsPerBinMod =\n \t\thistogramSize / (histogramSize % kExposureBinsCount + 1);\n@@ -191,7 +193,7 @@ void Agc::process(IPAContext &context,\n \t\treturn;\n \t}\n \n-\tauto exposureMSV = calculateMSV(stats->yHistogram, context.activeState.blc.level);\n+\tauto exposureMSV = calculateMSV({ stats->yHistogram }, context.activeState.blc.level);\n \tif (!exposureMSV) {\n \t\tLOG(IPASoftExposure, Debug)\n \t\t\t<< \"Not adjusting exposure due to insufficient histogram data\";\n", "prefixes": [ "RFC", "v2", "35/43" ] }