Patch Detail
Show a patch.
GET /api/patches/27451/?format=api
{ "id": 27451, "url": "https://patchwork.libcamera.org/api/patches/27451/?format=api", "web_url": "https://patchwork.libcamera.org/patch/27451/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260723154327.1357866-3-barnabas.pocze@ideasonboard.com>", "date": "2026-07-23T15:42:45", "name": "[RFC,v2,02/43] ipa: simple: Remove control presence sanity check", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "99386d6c227176227c1c86d9963984e5f35bb4d4", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/27451/mbox/", "series": [ { "id": 6075, "url": "https://patchwork.libcamera.org/api/series/6075/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6075", "date": "2026-07-23T15:42:43", "name": "ipa: libipa: agc rework", "version": 2, "mbox": "https://patchwork.libcamera.org/series/6075/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/27451/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/27451/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A8866C3264\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 23 Jul 2026 15:43:36 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0F31367EDC;\n\tThu, 23 Jul 2026 17:43:34 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 87E9A67EBA\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 23 Jul 2026 17:43:30 +0200 (CEST)", "from pb-laptop.local (185.182.215.156.nat.pool.zt.hu\n\t[185.182.215.156])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AF5E91C37\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 23 Jul 2026 17:42:29 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"fYv5tM+w\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1784821349;\n\tbh=OFb998A7bxhsobwjqDQbbNj/DCE4bODj2t52c6x4e3E=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=fYv5tM+wBWBlnCbYrwRBLnIeRX4aBKVL7XCgbYCms5uz3URiRM6anPkocYr7Toy2R\n\tNFQNfryUXHEOK7SPj5JluUm9ByaJRlUdnCNYnRxhYnk/WhGtSadx2F+uuY3YRU1rMD\n\tYeNpLJJfN9kdR9pv6kIZpaaOkTpuOexxg45ufk0c=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[RFC PATCH v2 02/43] ipa: simple: Remove control presence sanity\n\tcheck", "Date": "Thu, 23 Jul 2026 17:42:45 +0200", "Message-ID": "<20260723154327.1357866-3-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.55.0", "In-Reply-To": "<20260723154327.1357866-1-barnabas.pocze@ideasonboard.com>", "References": "<20260723154327.1357866-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The check is useless because `DelayedControls::get()` always populates\nthe result even if the value is \"none\", so the presence check will\nalways succeed. And furthermore the check also has the issue of being\nlater than the actual access.\n\nLink: https://gitlab.freedesktop.org/camera/libcamera/-/work_items/241\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n src/ipa/simple/soft_simple.cpp | 7 -------\n 1 file changed, 7 deletions(-)", "diff": "diff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp\nindex 629e1a32de..e99df1986f 100644\n--- a/src/ipa/simple/soft_simple.cpp\n+++ b/src/ipa/simple/soft_simple.cpp\n@@ -311,13 +311,6 @@ void IPASoftSimple::processStats(const uint32_t frame,\n \t\talgo->process(context_, frame, frameContext, stats_, metadata);\n \tmetadataReady.emit(frame, metadata);\n \n-\t/* Sanity check */\n-\tif (!sensorControls.contains(V4L2_CID_EXPOSURE) ||\n-\t !sensorControls.contains(V4L2_CID_ANALOGUE_GAIN)) {\n-\t\tLOG(IPASoft, Error) << \"Control(s) missing\";\n-\t\treturn;\n-\t}\n-\n \tControlList ctrls(sensorInfoMap_);\n \n \tauto &againNew = frameContext.sensor.gain;\n", "prefixes": [ "RFC", "v2", "02/43" ] }