Patch Detail
Show a patch.
GET /api/patches/27438/?format=api
{ "id": 27438, "url": "https://patchwork.libcamera.org/api/patches/27438/?format=api", "web_url": "https://patchwork.libcamera.org/patch/27438/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260722-pi4-upstream-v2-3-eb44d3c6fd92@ideasonboard.com>", "date": "2026-07-22T11:23:19", "name": "[v2,3/8] ipa: rpi: vc4: Add Bcm2835Params helper", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "89fe697c6449657c69c17647176177d7c3e700a4", "submitter": { "id": 223, "url": "https://patchwork.libcamera.org/api/people/223/?format=api", "name": "Jai Luthra", "email": "jai.luthra@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/27438/mbox/", "series": [ { "id": 6072, "url": "https://patchwork.libcamera.org/api/series/6072/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6072", "date": "2026-07-22T11:23:16", "name": "Raspberry Pi: Update VC4 pipeline for mainline", "version": 2, "mbox": "https://patchwork.libcamera.org/series/6072/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/27438/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/27438/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E9C0ABDE17\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 22 Jul 2026 11:24:58 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9892D67E9B;\n\tWed, 22 Jul 2026 13:24:58 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4FDA367E8A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 22 Jul 2026 13:24:57 +0200 (CEST)", "from mail.ideasonboard.com (unknown\n\t[IPv6:2401:4900:1c68:25d4:fa24:78d1:31:7a56])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EC9B2227;\n\tWed, 22 Jul 2026 13:23:56 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"AcLkkLUu\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1784719437;\n\tbh=cf6wpGKR2KCk5BiqjCHllai+xyMyN8efOP8EN/jcD8o=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=AcLkkLUuTmqEJ+AHBhLjhoqbyhmzScmXGxSs8+tvJnq9qfv54wxDj2PNEfdbibuUL\n\t78lY+CqnUu7ITWi9fWb0BE2VBr/nOczlnAjbJPWC9zL6UER3EIPXpYwNGuPDl5zwqT\n\t+A67wxNssoHzOLWpGFDMTkzVnk4pC91civK0hKhw=", "From": "Jai Luthra <jai.luthra@ideasonboard.com>", "Date": "Wed, 22 Jul 2026 16:53:19 +0530", "Subject": "[PATCH v2 3/8] ipa: rpi: vc4: Add Bcm2835Params helper", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20260722-pi4-upstream-v2-3-eb44d3c6fd92@ideasonboard.com>", "References": "<20260722-pi4-upstream-v2-0-eb44d3c6fd92@ideasonboard.com>", "In-Reply-To": "<20260722-pi4-upstream-v2-0-eb44d3c6fd92@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Naushir Patuck <naush@raspberrypi.com>, \n\tDavid Plowman <david.plowman@raspberrypi.com>, \n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>, \n\tKieran Bingham <kieran.bingham@ideasonboard.com>, \n\tJacopo Mondi <jacopo.mondi@ideasonboard.com>, \n\tDaniel Scally <dan.scally@ideasonboard.com>, \n\tJai Luthra <jai.luthra@ideasonboard.com>", "X-Mailer": "b4 0.14.3", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=2547;\n\ti=jai.luthra@ideasonboard.com; h=from:subject:message-id;\n\tbh=cf6wpGKR2KCk5BiqjCHllai+xyMyN8efOP8EN/jcD8o=;\n\tb=owEBbQKS/ZANAwAKAUPekfkkmnFFAcsmYgBqYKhpTo6Dh5fd3NGXI240oVCSmGg9KfB7V0MUP\n\ta78StGZr/SJAjMEAAEKAB0WIQRN4NgY5dV16NRar8VD3pH5JJpxRQUCamCoaQAKCRBD3pH5JJpx\n\tRRpVEACZHDKurSTE46kt1tGoiSwKyQ7A0ieM7sOvGNIigHh2bVrmckeLtQKtBk2d7EPBkOV+AAB\n\tiOynIAJNRoarNkVZcfp5Hmm/QpXRiuWgvEwNrIBu5S/t7CKoSg0Umq88t1BXUsp/pNvpV448Et0\n\tLrhf8cgzbRj5l7QJKc3uTxORQp7xd1fjSvJVmIAJDwlJJUs4qplYpY/A6VLWsxXv1J8+7yThcb9\n\t//F8jxkVmexX2VSx9n55zg639f4UCB5xuVGdrKssnqCPWRrKb3KvRLxqDcZtfn2tFNSGkawWovW\n\tILGzynDnfgZcplrzwan7ZVX+vxOk1BqbKFCLq8AF83L+40VuRbMDb/pI7piHoDVUvXLFGkjOM1l\n\tI7JvBoAaD6Eri4vMuGo202CpFqXfCd2h5QzD8qwxuFO3cubmo2fXJwW3oml5HlzbGCDFBGXOzPG\n\ty3lsP1TFDfaU5K+joVEO3qWG1Xf6hjANwsD+ZWScix9GvK261CHwRULuOLx/Pm2J/BhA8wF+Tu+\n\tqUqGn/PA0YzZgcY1FFwi9KpPE1xYUPK1S5i/B6cTzJnH5orCM8buxY6P+fcmSVE1tpUE+gdtHwj\n\tej/ya2D8KzNl+re9IkCDZGR/9xOqNScD/i08QJqtlv7IncP2cAjSs8+4eBZKlvY1HGL40sxautX\n\tTa8vxPnS86hp20A==", "X-Developer-Key": "i=jai.luthra@ideasonboard.com; a=openpgp;\n\tfpr=4DE0D818E5D575E8D45AAFC543DE91F9249A7145", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Implement Bcm2835Params to derive from V4L2Params. The mailine driver\nuses extensible V4L2 parameter for configuration instead of custom V4L2\ncontrols.\n\nSigned-off-by: Jai Luthra <jai.luthra@ideasonboard.com>\n---\n src/ipa/rpi/vc4/params.h | 79 ++++++++++++++++++++++++++++++++++++++++++++++++\n 1 file changed, 79 insertions(+)", "diff": "diff --git a/src/ipa/rpi/vc4/params.h b/src/ipa/rpi/vc4/params.h\nnew file mode 100644\nindex 000000000..c936f8812\n--- /dev/null\n+++ b/src/ipa/rpi/vc4/params.h\n@@ -0,0 +1,79 @@\n+/* SPDX-License-Identifier: LGPL-2.1-or-later */\n+/*\n+ * Copyright (C) 2026, Ideas On Board\n+ *\n+ * Raspberry Pi VC4/BCM2835 ISP Parameters\n+ */\n+\n+#pragma once\n+\n+#include <stdint.h>\n+\n+#include <linux/bcm2835-isp.h>\n+\n+#include <libipa/v4l2_params.h>\n+\n+namespace libcamera {\n+\n+namespace ipa::RPi {\n+\n+enum class BlockType : uint16_t {\n+\tBlackLevel,\n+\tGeq,\n+\tGamma,\n+\tDenoise,\n+\tSharpen,\n+\tDpc,\n+\tCdn,\n+\tCcMatrix,\n+\tLensShading,\n+\tAwbGains,\n+\tDGain,\n+};\n+\n+namespace details {\n+\n+template<BlockType B>\n+struct block_type {\n+};\n+\n+#define BCM2835_DEFINE_BLOCK_TYPE(id, structName, blockId) \\\n+\ttemplate<> \\\n+\tstruct block_type<BlockType::id> { \\\n+\t\tusing type = struct bcm2835_isp_params_##structName; \\\n+\t\tstatic constexpr bcm2835_isp_param_block_type blockType = \\\n+\t\t\tBCM2835_ISP_PARAM_BLOCK_##blockId; \\\n+\t};\n+\n+BCM2835_DEFINE_BLOCK_TYPE(BlackLevel, black_level, BLACK_LEVEL)\n+BCM2835_DEFINE_BLOCK_TYPE(Geq, geq, GEQ)\n+BCM2835_DEFINE_BLOCK_TYPE(Gamma, gamma, GAMMA)\n+BCM2835_DEFINE_BLOCK_TYPE(Denoise, denoise, DENOISE)\n+BCM2835_DEFINE_BLOCK_TYPE(Sharpen, sharpen, SHARPEN)\n+BCM2835_DEFINE_BLOCK_TYPE(Dpc, dpc, DPC)\n+BCM2835_DEFINE_BLOCK_TYPE(Cdn, cdn, CDN)\n+BCM2835_DEFINE_BLOCK_TYPE(CcMatrix, cc_matrix, CC_MATRIX)\n+BCM2835_DEFINE_BLOCK_TYPE(LensShading, lens_shading, LENS_SHADING)\n+BCM2835_DEFINE_BLOCK_TYPE(AwbGains, awb_gains, AWB_GAINS)\n+BCM2835_DEFINE_BLOCK_TYPE(DGain, digital_gain, DIGITAL_GAIN)\n+\n+struct params_traits {\n+\tusing id_type = BlockType;\n+\ttemplate<id_type Id>\n+\tusing id_to_details = block_type<Id>;\n+};\n+\n+} /* namespace details */\n+\n+class Bcm2835Params : public V4L2Params<details::params_traits>\n+{\n+public:\n+\tBcm2835Params(Span<uint8_t> data) : V4L2Params(data,\n+\t\t\t\t\t\t BCM2835_ISP_PARAM_BUFFER_V1)\n+\t{\n+\t}\n+};\n+\n+} /* namespace ipa::RPi */\n+\n+} /* namespace libcamera */\n", "prefixes": [ "v2", "3/8" ] }