Patch Detail
Show a patch.
GET /api/patches/27410/?format=api
{ "id": 27410, "url": "https://patchwork.libcamera.org/api/patches/27410/?format=api", "web_url": "https://patchwork.libcamera.org/patch/27410/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260720-libipa-algorithms-v6-19-ececb73f97cb@ideasonboard.com>", "date": "2026-07-20T14:59:37", "name": "[v6,19/31] ipa: libipa: lsc_base: Add sampleForCrop documentation", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "088ffed4f35d6ebfb7aa5a607ee3e4baa48a4a83", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/27410/mbox/", "series": [ { "id": 6067, "url": "https://patchwork.libcamera.org/api/series/6067/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6067", "date": "2026-07-20T14:59:18", "name": "ipa: libipa: Introduce libipa algorithms", "version": 6, "mbox": "https://patchwork.libcamera.org/series/6067/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/27410/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/27410/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5D44BC3334\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 20 Jul 2026 15:00:10 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D572067E9E;\n\tMon, 20 Jul 2026 17:00:09 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DFC8567E6A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 20 Jul 2026 16:59:51 +0200 (CEST)", "from [192.168.1.106] (mob-5-90-63-152.net.vodafone.it\n\t[5.90.63.152])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 14688258D;\n\tMon, 20 Jul 2026 16:58:53 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"EY0IdF4C\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1784559533;\n\tbh=WYRREtMMsGnWekfpemz4LN4fohagCWU8KMsfNpvYOME=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=EY0IdF4CathMbXPKFTRI7MCV6KmDKYN8ZbX0DW9XrwHpBP4xG94/ax7z5ozwgvnKe\n\t38sDJMjU5OJbV2bOoIN/lXEtaFCg2Odsz1HG+bT8VMS5nGPKYeFXyHwQUIbSMADKvq\n\tgfLOuVobEG8j33IscU2t1nOaZcjQhCxgSp4vTx7U=", "From": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Date": "Mon, 20 Jul 2026 16:59:37 +0200", "Subject": "[PATCH v6 19/31] ipa: libipa: lsc_base: Add sampleForCrop\n\tdocumentation", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20260720-libipa-algorithms-v6-19-ececb73f97cb@ideasonboard.com>", "References": "<20260720-libipa-algorithms-v6-0-ececb73f97cb@ideasonboard.com>", "In-Reply-To": "<20260720-libipa-algorithms-v6-0-ececb73f97cb@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org, \n\tStefan Klug <stefan.klug@ideasonboard.com>, \n\tMilan Zamazal <mzamazal@redhat.com>", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "X-Mailer": "b4 0.14.3", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=1459;\n\ti=jacopo.mondi@ideasonboard.com; h=from:subject:message-id;\n\tbh=WYRREtMMsGnWekfpemz4LN4fohagCWU8KMsfNpvYOME=;\n\tb=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBqXjfY/Sfb4nPV6mPVmSsANnJEBHtj50MKPuN2a\n\tSQZiBpxx0iJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCal432AAKCRByNAaPFqFW\n\tPPETD/9H0mJiFKwvWD3105IXCK1Gx0f2DcPVmz26e0wW/5o+PlHCBDaNoelIfh5YnI5Bn4sU6Hl\n\tOuhRJ2D8Q/Cw4Nf7tYZztWYPltlATxLsMvhLtSCpE1HRK+hriOIdH1L2/ZlRL9+nRsFHSBmWjEQ\n\tTQItwQgL8sh8dCaOpBuVMRe6lfqrWOs+oP9EtrYUMyaIG8IMNOLDkaLMW1UoL4duGJ3M4T3BBKC\n\tlTWMm6Qt8+bIH7FRTq1n1nti9ys3srv96hWRvmu0nGNK3MeD/0Luhi5sJc5lJbeY1vm7IPksY0g\n\tQXquHDKr80K46M1vd4Li8jbu+6JnslXaENB8E/8kGUoULSogBlwGQq4Hne/grO2nqLKY0sSs6Iy\n\tZ7ckEBzXtIuLgcS/AXiQ257bvLWF90ueo1O9y46FLbw+5H+aHGLB6pqTD1awBH8Ac7zhUGnQ5/Q\n\tfGqJNsMhxPQEgH+lELke1v5ryk7WOddlCGcNPb+NSdV3qjpYQ81XtNj5aS9KFJZTj4/mE7dI55b\n\tc/YsuMxlJ798dITHJ05/akDlcnwPazcSeZPBWk9/avUZD/U8Ij9Aslmt3czUuJocsMHcE3B2DfZ\n\thg4IBhugsATpmpeFCHlYEfUm1l/PTsJyZes1i5semjBQo2ywL0mQszf8Cgrt6djkpjR+0l9vE47\n\toGgxeJgCIQ0XrbQ==", "X-Developer-Key": "i=jacopo.mondi@ideasonboard.com; a=openpgp;\n\tfpr=72392EDC88144A65C701EA9BA5826A2587AD026B", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Now that we have two in-tree implementations of LscImplementation\ndetail how the two perform lsc gain re-sampling.\n\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\n src/ipa/libipa/lsc_base.cpp | 15 +++++++++++++++\n 1 file changed, 15 insertions(+)", "diff": "diff --git a/src/ipa/libipa/lsc_base.cpp b/src/ipa/libipa/lsc_base.cpp\nindex b50460394925..1015cdc7cf4c 100644\n--- a/src/ipa/libipa/lsc_base.cpp\n+++ b/src/ipa/libipa/lsc_base.cpp\n@@ -103,6 +103,21 @@ void Interpolator<lsc::Components>::\n * each segment of size 0.0625 and the list of nodes position will be\n * [0, 0.0625, 0.125, 0.1875, ... , 1]. It is expected that the first position\n * is 0 and the last position is 1.\n+ *\n+ * LSC tables are expressed in two formats:\n+ * - A list of gain values (LscTable)\n+ * - A radial polynomial (LscPolynomial)\n+ *\n+ * Table-based LSC tables are generated using an image at a fixed resolution and\n+ * can't at the moment be re-sampled when a different resolution is used for a\n+ * streaming session. Re-sampling a grid LSC table will return the same table\n+ * as loaded from the tuning file.\n+ *\n+ * \\todo: Implement grid based re-sampling\n+ *\n+ * Polynomial configurations are more flexible and can be re-sampled for a given\n+ * sensor frame resolution using a list of horizontal and vertical nodes that\n+ * define the LSC grid on which the polynomial is re-sampled on.\n */\n \n } /* namespace ipa */\n", "prefixes": [ "v6", "19/31" ] }