Patch Detail
Show a patch.
GET /api/patches/27404/?format=api
{ "id": 27404, "url": "https://patchwork.libcamera.org/api/patches/27404/?format=api", "web_url": "https://patchwork.libcamera.org/patch/27404/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260720-libipa-algorithms-v6-12-ececb73f97cb@ideasonboard.com>", "date": "2026-07-20T14:59:30", "name": "[v6,12/31] ipa: libipa: lsc_polynomial: Don't inline ValueNode accessor", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "dd4cb13fac34030e00c1a9537a4428eae62df079", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/27404/mbox/", "series": [ { "id": 6067, "url": "https://patchwork.libcamera.org/api/series/6067/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6067", "date": "2026-07-20T14:59:18", "name": "ipa: libipa: Introduce libipa algorithms", "version": 6, "mbox": "https://patchwork.libcamera.org/series/6067/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/27404/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/27404/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5A7F0C3306\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 20 Jul 2026 15:00:02 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 126DE67E80;\n\tMon, 20 Jul 2026 17:00:01 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1282C67E4C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 20 Jul 2026 16:59:48 +0200 (CEST)", "from [192.168.1.106] (mob-5-90-63-152.net.vodafone.it\n\t[5.90.63.152])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1E1091CE6;\n\tMon, 20 Jul 2026 16:58:49 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"YB2fttu5\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1784559529;\n\tbh=yXwIPDDYuWnxiEQ7pfsAy2nzJEmWvfcuWcpTAAq3aio=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=YB2fttu5HIUPxwdsxreNg5vHR1shh5Sfsfkcmv4n0gsNLKt3yQ/Oqz2I/dKdKqxNi\n\tGqkxeVEH2HdRIwYspNNDtYbig4gYZ9j5LdqHmJBDpOt5rBRWZ4Nmqn70goEdShA9Ui\n\tC2QoeR93I5q7H9+KF1+KSFiCR62QmuW7hVfgFaLM=", "From": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Date": "Mon, 20 Jul 2026 16:59:30 +0200", "Subject": "[PATCH v6 12/31] ipa: libipa: lsc_polynomial: Don't inline\n\tValueNode accessor", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20260720-libipa-algorithms-v6-12-ececb73f97cb@ideasonboard.com>", "References": "<20260720-libipa-algorithms-v6-0-ececb73f97cb@ideasonboard.com>", "In-Reply-To": "<20260720-libipa-algorithms-v6-0-ececb73f97cb@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org, \n\tStefan Klug <stefan.klug@ideasonboard.com>, \n\tMilan Zamazal <mzamazal@redhat.com>", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>, \n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>, \n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "X-Mailer": "b4 0.14.3", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=3022;\n\ti=jacopo.mondi@ideasonboard.com; h=from:subject:message-id;\n\tbh=gKG7oMvPdTnWPY3Xqu6aZDyF064c3RNYURQAJyWHzUw=;\n\tb=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBqXjfVGg1sKi/VnboIm8dmzF/XpqZsProJZkwGP\n\tjWSmElYAKWJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCal431QAKCRByNAaPFqFW\n\tPBjQEACw2aSQV1RQPkJwqlf16apbO+/HCb1FXNDhXQZSdHpbjtCfjmTUBj/rkKgfcVNXLpP3CB5\n\tUfkQjLRLSP4pC0jc5GSMABUtxKOOajXuIG5lchG4NpPMZWrFlqIHQhgXdnQ4Sk7l4SOrTcsO2Xr\n\tPTMRIL2vuIeUbwbyn6wLxQYdAdnMmkXTl4xE06IOk/xiS9EhgnwpntrJekjYyQgS8qLb49TcKY2\n\tXUD9yWKDPIzfG1fvkL9ED10eskOm++2EXiNgmphTxdTz9WtLlEAJN+2KTeUIch4fgtb8i64+jyR\n\tudn5ERLYvDJnfvHIiZZ6riJLBM1MVowyScw6xPOgo6ZB/W8TMt7f0fSMWNsafWAs6jK6Eo/7uFG\n\tD6jSaIrd5j1pEBFlnRLG3aL9iV52AblE+BJ3N4jOAL6vWQ8yDfUF18w642BxgLsWUyC4ItYLqde\n\t98bKxy1KeKAUGd/X3TGJ05vc2MQ0NkZpIdW3J4uAT4wxod7oFIr2Jzrryymw5PZEZtfyZ5tTZyH\n\t+29ESPe+EnLLzaOOyLQFifHCdQpKA+eAUP7c35Bzbm5C5fQuXJu08mpH1fcb5dMOrwTW5YVPERy\n\tjHr3ZSQnjH/1p8yPqpvh/U9wQtDWJHR6n53tmu9Luii1FitACl5EONgLzBssEDLTNTh/aOu/XwF\n\tBYD0tCEMUw1QBtA==", "X-Developer-Key": "i=jacopo.mondi@ideasonboard.com; a=openpgp;\n\tfpr=72392EDC88144A65C701EA9BA5826A2587AD026B", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nThere's no need to inline the ValueNode::Accessor::get() function for\nLscPolynomial. Move it to from lsc_polynomial.h to lsc_polynomial.cpp.\n\nWhile at it, replace C++-style comments with C-style comments according\nto the libcamera coding style.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\n src/ipa/libipa/lsc_polynomial.cpp | 28 ++++++++++++++++++++++++++--\n src/ipa/libipa/lsc_polynomial.h | 26 --------------------------\n 2 files changed, 26 insertions(+), 28 deletions(-)", "diff": "diff --git a/src/ipa/libipa/lsc_polynomial.cpp b/src/ipa/libipa/lsc_polynomial.cpp\nindex f607d86c54c3..921af0b0bd13 100644\n--- a/src/ipa/libipa/lsc_polynomial.cpp\n+++ b/src/ipa/libipa/lsc_polynomial.cpp\n@@ -77,5 +77,29 @@ namespace ipa {\n * \\param size The size of the reference image\n */\n \n-} // namespace ipa\n-} // namespace libcamera\n+} /* namespace ipa */\n+\n+#ifndef __DOXYGEN__\n+template<>\n+std::optional<ipa::LscPolynomial>\n+ValueNode::Accessor<ipa::LscPolynomial>::get(const ValueNode &obj) const\n+{\n+\tstd::optional<double> cx = obj[\"cx\"].get<double>();\n+\tstd::optional<double> cy = obj[\"cy\"].get<double>();\n+\tstd::optional<double> k0 = obj[\"k0\"].get<double>();\n+\tstd::optional<double> k1 = obj[\"k1\"].get<double>();\n+\tstd::optional<double> k2 = obj[\"k2\"].get<double>();\n+\tstd::optional<double> k3 = obj[\"k3\"].get<double>();\n+\tstd::optional<double> k4 = obj[\"k4\"].get<double>();\n+\n+\tif (!(cx && cy && k0 && k1 && k2 && k3 && k4)) {\n+\t\tLOG(LscPolynomial, Error)\n+\t\t\t<< \"Polynomial is missing a parameter\";\n+\t\treturn std::nullopt;\n+\t}\n+\n+\treturn ipa::LscPolynomial(*cx, *cy, *k0, *k1, *k2, *k3, *k4);\n+}\n+#endif /* __DOXYGEN__ */\n+\n+} /* namespace libcamera */\ndiff --git a/src/ipa/libipa/lsc_polynomial.h b/src/ipa/libipa/lsc_polynomial.h\nindex a0d27c4b21d6..d52ec86946b1 100644\n--- a/src/ipa/libipa/lsc_polynomial.h\n+++ b/src/ipa/libipa/lsc_polynomial.h\n@@ -80,30 +80,4 @@ private:\n \n } /* namespace ipa */\n \n-#ifndef __DOXYGEN__\n-\n-template<>\n-struct ValueNode::Accessor<ipa::LscPolynomial> {\n-\tstd::optional<ipa::LscPolynomial> get(const ValueNode &obj) const\n-\t{\n-\t\tstd::optional<double> cx = obj[\"cx\"].get<double>();\n-\t\tstd::optional<double> cy = obj[\"cy\"].get<double>();\n-\t\tstd::optional<double> k0 = obj[\"k0\"].get<double>();\n-\t\tstd::optional<double> k1 = obj[\"k1\"].get<double>();\n-\t\tstd::optional<double> k2 = obj[\"k2\"].get<double>();\n-\t\tstd::optional<double> k3 = obj[\"k3\"].get<double>();\n-\t\tstd::optional<double> k4 = obj[\"k4\"].get<double>();\n-\n-\t\tif (!(cx && cy && k0 && k1 && k2 && k3 && k4)) {\n-\t\t\tLOG(LscPolynomial, Error)\n-\t\t\t\t<< \"Polynomial is missing a parameter\";\n-\t\t\treturn std::nullopt;\n-\t\t}\n-\n-\t\treturn ipa::LscPolynomial(*cx, *cy, *k0, *k1, *k2, *k3, *k4);\n-\t}\n-};\n-\n-#endif\n-\n } /* namespace libcamera */\n", "prefixes": [ "v6", "12/31" ] }