Patch Detail
Show a patch.
GET /api/patches/27384/?format=api
{ "id": 27384, "url": "https://patchwork.libcamera.org/api/patches/27384/?format=api", "web_url": "https://patchwork.libcamera.org/patch/27384/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260720095951.49979-7-mzamazal@redhat.com>", "date": "2026-07-20T09:59:50", "name": "[RFC,v9,6/6] libcamera: software_isp: debayer_egl: Add LSC support", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "c51a651943994f493befd3bb1d4bcc4d8fd81a32", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/27384/mbox/", "series": [ { "id": 6062, "url": "https://patchwork.libcamera.org/api/series/6062/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6062", "date": "2026-07-20T09:59:44", "name": "LSC for SoftISP simple pipeline", "version": 9, "mbox": "https://patchwork.libcamera.org/series/6062/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/27384/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/27384/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5465FBF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 20 Jul 2026 10:00:27 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 09C7D67E42;\n\tMon, 20 Jul 2026 12:00:27 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 568E66614D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 20 Jul 2026 12:00:25 +0200 (CEST)", "from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-148-IT8P3aWYNXSJsAnQKMEcyw-1;\n\tMon, 20 Jul 2026 06:00:20 -0400", "from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 11F6B195E911; Mon, 20 Jul 2026 10:00:19 +0000 (UTC)", "from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.33.73])\n\tby mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 739F23004190; Mon, 20 Jul 2026 10:00:16 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"FiMjhzu1\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1784541624;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=Aw8T0d/oMTQXKQG70OlMb0iE3CTD43kgeFevjj+HxyQ=;\n\tb=FiMjhzu1dShPNobVoe62i9/hfj9n3Fuz6ZaCfBGoN7cbsFKCIpkfEkXausnJ3n4buf8Wlc\n\tfcpntjHdfxxFKv5G/4uMJouwwhVDmyqXEMLzVbvASaNyDN8t8mqGNGEwNWUPTO42emaqcG\n\txmqYfLK9bqHmFmPi4W6mUfm2+xfQYrQ=", "X-MC-Unique": "IT8P3aWYNXSJsAnQKMEcyw-1", "X-Mimecast-MFC-AGG-ID": "IT8P3aWYNXSJsAnQKMEcyw_1784541619", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Xander Pronk <xander.c.pronk@gmail.com>,\n\tBryan O'Donoghue <bod.linux@nxsw.ie>,\n\tHans de Goede <johannes.goede@oss.qualcomm.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tRick ten Wolde <rick_libcamera@wolde.info>,\n\tMilan Zamazal <mzamazal@redhat.com>", "Subject": "[RFC PATCH v9 6/6] libcamera: software_isp: debayer_egl: Add LSC\n\tsupport", "Date": "Mon, 20 Jul 2026 11:59:50 +0200", "Message-ID": "<20260720095951.49979-7-mzamazal@redhat.com>", "In-Reply-To": "<20260720095951.49979-1-mzamazal@redhat.com>", "References": "<20260720095951.49979-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.4", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "PFHrefS1tRpiegRtiIDCKRdymG40Z4b9ufuFD6l-A9Y_1784541619", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Xander Pronk <xander.c.pronk@gmail.com>\n\nAdd support for passing the LSC table from debayerParams to the shaders.\n\nThe LSC table values are floats, we must add `type' parameter to\ncreateTexture2D to support this. Moreover, we use 16-bit internal\nformat for the values, primarily because this works for me, unlike\n32-bit floats.\n\nWhen LSC is disabled by the runtime control, we provide a constant 1.0\ncorrection table, i.e. a no-op table. This is preferred to having a\nruntime flag, to not disturb GPU computation with runtime switches,\nassuming that disabling LSC in runtime is not a common use case.\n\nCo-developed-by: Rick ten Wolde <rick_libcamera@wolde.info>\nSigned-off-by: Rick ten Wolde <rick_libcamera@wolde.info>\nSigned-off-by: Xander Pronk <xander.c.pronk@gmail.com>\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n include/libcamera/internal/egl.h | 6 +++-\n .../internal/software_isp/debayer_params.h | 2 ++\n src/ipa/simple/algorithms/lsc.cpp | 11 ++++---\n src/libcamera/egl.cpp | 12 +++++--\n src/libcamera/software_isp/debayer.cpp | 5 +++\n src/libcamera/software_isp/debayer_egl.cpp | 32 +++++++++++++++++--\n src/libcamera/software_isp/debayer_egl.h | 6 ++++\n 7 files changed, 64 insertions(+), 10 deletions(-)", "diff": "diff --git a/include/libcamera/internal/egl.h b/include/libcamera/internal/egl.h\nindex 9edc28ea4..441599a1d 100644\n--- a/include/libcamera/internal/egl.h\n+++ b/include/libcamera/internal/egl.h\n@@ -107,7 +107,11 @@ public:\n \n \tint createInputDMABufTexture2D(eGLImage &eglImage, int fd);\n \tint createOutputDMABufTexture2D(eGLImage &eglImage, int fd);\n-\tvoid createTexture2D(eGLImage &eglImage, void *data, GLint filter);\n+\tvoid createTexture2D(eGLImage &eglImage,\n+\t\t\t GLint internalFormat,\n+\t\t\t GLenum type,\n+\t\t\t const void *data,\n+\t\t\t GLint filter);\n \tvoid updateTexture2D(eGLImage &eglImage, void *data);\n \tvoid createOutputTexture2D(eGLImage &eglImage);\n \ndiff --git a/include/libcamera/internal/software_isp/debayer_params.h b/include/libcamera/internal/software_isp/debayer_params.h\nindex e3e01bc04..76825e6c8 100644\n--- a/include/libcamera/internal/software_isp/debayer_params.h\n+++ b/include/libcamera/internal/software_isp/debayer_params.h\n@@ -29,6 +29,8 @@ struct DebayerParams {\n \n \tstatic constexpr unsigned int kLscGridSize = 16;\n \tstatic constexpr unsigned int kLscValuesPerCell = 3;\n+\tstatic constexpr unsigned int kLscBytesPerCell =\n+\t\tkLscValuesPerCell * sizeof(float);\n \tusing LscLookupTable =\n \t\tstd::array<float, kLscGridSize * kLscGridSize * kLscValuesPerCell>;\n \tLscLookupTable lscLut{};\ndiff --git a/src/ipa/simple/algorithms/lsc.cpp b/src/ipa/simple/algorithms/lsc.cpp\nindex c531937c7..51c5b63d5 100644\n--- a/src/ipa/simple/algorithms/lsc.cpp\n+++ b/src/ipa/simple/algorithms/lsc.cpp\n@@ -46,13 +46,16 @@ void Lsc::prepare([[maybe_unused]] IPAContext &context,\n \t\t IPAFrameContext &frameContext,\n \t\t DebayerParams *params)\n {\n-\tparams->lscEnabled = frameContext.lsc.enabled;\n-\n \tunsigned int ct = frameContext.awb.colourTemperature;\n \tconstexpr unsigned int minTemperatureChange = 100;\n \n-\tif (!frameContext.lsc.enabled ||\n-\t utils::abs_diff(ct, lastAppliedCt_) < minTemperatureChange)\n+\tif (!frameContext.lsc.enabled) {\n+\t\tparams->lscLut.fill(1.0);\n+\t\tlastAppliedCt_ = 0;\n+\t\treturn;\n+\t}\n+\n+\tif (utils::abs_diff(ct, lastAppliedCt_) < minTemperatureChange)\n \t\treturn;\n \n \tconst lsc::Components<uint8_t> &set = lscAlgo_.interpolateComponents(ct);\ndiff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp\nindex 53390f370..1e876e51f 100644\n--- a/src/libcamera/egl.cpp\n+++ b/src/libcamera/egl.cpp\n@@ -274,6 +274,8 @@ int eGL::createOutputDMABufTexture2D(eGLImage &eglImage, int fd)\n /**\n * \\brief Create a 2D texture from a memory buffer\n * \\param[in,out] eglImage EGL image to associate with the texture\n+ * \\param[in] internalFormat OpenGL internal storage format (e.g., GL_RGB8, GL_RGBA8)\n+ * \\param[in] type OpenGL pixel data type (e.g., GL_UNSIGNED_BYTE, GL_FLOAT)\n * \\param[in] data Pointer to pixel data, or nullptr for uninitialised texture\n * \\param[in] filter GL texture filter setting\n *\n@@ -282,14 +284,18 @@ int eGL::createOutputDMABufTexture2D(eGLImage &eglImage, int fd)\n * is useful for uploading static data like lookup tables or uniform color\n * matrices to the GPU.\n */\n-void eGL::createTexture2D(eGLImage &eglImage, void *data, GLint filter)\n+void eGL::createTexture2D(eGLImage &eglImage,\n+\t\t\t GLint internalFormat,\n+\t\t\t GLenum type,\n+\t\t\t const void *data,\n+\t\t\t GLint filter)\n {\n \tASSERT(tid_ == Thread::currentId());\n \n \tactivateBindTexture(eglImage);\n \n \t// Generate texture, bind, associate image to texture, configure, unbind\n-\tglTexImage2D(GL_TEXTURE_2D, 0, eglImage.format_, eglImage.width_, eglImage.height_, 0, eglImage.format_, GL_UNSIGNED_BYTE, data);\n+\tglTexImage2D(GL_TEXTURE_2D, 0, internalFormat, eglImage.width_, eglImage.height_, 0, eglImage.format_, type, data);\n \n \t// Nearest filtering\n \tglTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, filter);\n@@ -370,7 +376,7 @@ void eGL::updateTexture2D(eGLImage &eglImage, void *data)\n */\n void eGL::createOutputTexture2D(eGLImage &eglImage)\n {\n-\tcreateTexture2D(eglImage, NULL, GL_NEAREST);\n+\tcreateTexture2D(eglImage, eglImage.format_, GL_UNSIGNED_BYTE, NULL, GL_NEAREST);\n \tattachTextureToFBO(eglImage);\n }\n \ndiff --git a/src/libcamera/software_isp/debayer.cpp b/src/libcamera/software_isp/debayer.cpp\nindex 5ae9f032f..70c0e3336 100644\n--- a/src/libcamera/software_isp/debayer.cpp\n+++ b/src/libcamera/software_isp/debayer.cpp\n@@ -53,6 +53,11 @@ namespace libcamera {\n * \\brief Number of pixel values per each of the lens shading grid areas\n */\n \n+/**\n+ * \\var DebayerParams::kLscBytesPerCell\n+ * \\brief Number of bytes per each of the lens shading grid areas\n+ */\n+\n /**\n * \\typedef DebayerParams::LscLookupTable\n * \\brief Lookup table for lens shading correction\ndiff --git a/src/libcamera/software_isp/debayer_egl.cpp b/src/libcamera/software_isp/debayer_egl.cpp\nindex 7cb0ee6ff..98ba5b24b 100644\n--- a/src/libcamera/software_isp/debayer_egl.cpp\n+++ b/src/libcamera/software_isp/debayer_egl.cpp\n@@ -128,6 +128,8 @@ int DebayerEGL::getShaderVariableLocations(void)\n \ttextureUniformBayerFirstRed_ = glGetUniformLocation(programId_, \"tex_bayer_first_red\");\n \ttextureUniformProjMatrix_ = glGetUniformLocation(programId_, \"proj_matrix\");\n \n+\ttextureUniformLsc_ = glGetUniformLocation(programId_, \"lsc_tex\");\n+\n \tLOG(Debayer, Debug) << \"vertexIn \" << attributeVertex_ << \" textureIn \" << attributeTexture_\n \t\t\t << \" tex_y \" << textureUniformBayerDataIn_\n \t\t\t << \" awb \" << awbUniformDataIn_\n@@ -139,7 +141,8 @@ int DebayerEGL::getShaderVariableLocations(void)\n \t\t\t << \" tex_size \" << textureUniformSize_\n \t\t\t << \" stride_factor \" << textureUniformStrideFactor_\n \t\t\t << \" tex_bayer_first_red \" << textureUniformBayerFirstRed_\n-\t\t\t << \" proj_matrix \" << textureUniformProjMatrix_;\n+\t\t\t << \" proj_matrix \" << textureUniformProjMatrix_\n+\t\t\t << \" tex_lsc \" << textureUniformLsc_;\n \treturn 0;\n }\n \n@@ -156,6 +159,9 @@ int DebayerEGL::initBayerShaders(PixelFormat inputFormat, PixelFormat outputForm\n \t/* Specify GL_OES_EGL_image_external */\n \tegl_.pushEnv(shaderEnv, \"#extension GL_OES_EGL_image_external: enable\");\n \n+\tif (lscEnabled_)\n+\t\tegl_.pushEnv(shaderEnv, \"#define APPLY_LSC\");\n+\n \t/*\n \t * Tell shaders how to re-order output taking account of how the pixels\n \t * are actually stored by EGL.\n@@ -351,6 +357,18 @@ int DebayerEGL::configure(const StreamConfiguration &inputCfg,\n \tinputBufferCount_ = inputCfg.bufferCount;\n \toutputBufferCount_ = outputCfg.bufferCount;\n \n+\tif (lscEnabled_) {\n+\t\tconstexpr unsigned int gridSize = DebayerParams::kLscGridSize;\n+\t\tconst unsigned int stride = gridSize * DebayerParams::kLscBytesPerCell;\n+\t\teglImageLscLookup_ =\n+\t\t\tstd::make_unique<eGLImage>(GL_RGB,\n+\t\t\t\t\t\t gridSize,\n+\t\t\t\t\t\t gridSize,\n+\t\t\t\t\t\t stride,\n+\t\t\t\t\t\t GL_TEXTURE2,\n+\t\t\t\t\t\t 2);\n+\t}\n+\n \treturn 0;\n }\n \n@@ -486,6 +504,12 @@ void DebayerEGL::setShaderVariableValues(eGLImage &eglImageIn, const DebayerPara\n \tglUniformMatrix3fv(ccmUniformDataIn_, 1, GL_TRUE, params.combinedMatrix.data().data());\n \tLOG(Debayer, Debug) << \" ccmUniformDataIn_ \" << ccmUniformDataIn_ << \" data \" << params.combinedMatrix;\n \n+\tif (lscEnabled_) {\n+\t\tegl_.createTexture2D(*eglImageLscLookup_, GL_RGB16F, GL_FLOAT,\n+\t\t\t\t params.lscLut.data(), GL_LINEAR);\n+\t\tglUniform1i(textureUniformLsc_, eglImageLscLookup_->texture_unit_uniform_id_);\n+\t}\n+\n \t/*\n \t * 0 = Red, 1 = Green, 2 = Blue\n \t */\n@@ -552,7 +576,11 @@ eGLImage *DebayerEGL::getCachedInputFrameBuffer(FrameBuffer *input, std::optiona\n \t\treturn nullptr;\n \t}\n \tif (cache_miss)\n-\t\tegl_.createTexture2D(*eglImageIn, inMapped->value().planes()[0].data(), GL_NEAREST);\n+\t\tegl_.createTexture2D(*eglImageIn,\n+\t\t\t\t eglImageIn->format_,\n+\t\t\t\t GL_UNSIGNED_BYTE,\n+\t\t\t\t inMapped->value().planes()[0].data(),\n+\t\t\t\t GL_NEAREST);\n \telse\n \t\tegl_.updateTexture2D(*eglImageIn, inMapped->value().planes()[0].data());\n \ndiff --git a/src/libcamera/software_isp/debayer_egl.h b/src/libcamera/software_isp/debayer_egl.h\nindex 26b009da4..f12c0aef3 100644\n--- a/src/libcamera/software_isp/debayer_egl.h\n+++ b/src/libcamera/software_isp/debayer_egl.h\n@@ -84,7 +84,10 @@ private:\n \tunsigned int inputBufferCount_;\n \tunsigned int outputBufferCount_;\n \n+\t/* LSC lookup table */\n+\tstd::unique_ptr<eGLImage> eglImageLscLookup_;\n \tbool lscEnabled_;\n+\n \t/* Shader parameters */\n \tfloat firstRed_x_;\n \tfloat firstRed_y_;\n@@ -101,6 +104,9 @@ private:\n \t/* Per-frame AWB gains */\n \tGLint awbUniformDataIn_;\n \n+\t/* Lens shading correction */\n+\tGLint textureUniformLsc_;\n+\n \t/* Represent per-frame CCM as a uniform vector of floats 3 x 3 */\n \tGLint ccmUniformDataIn_;\n \n", "prefixes": [ "RFC", "v9", "6/6" ] }