Patch Detail
Show a patch.
GET /api/patches/27246/?format=api
{ "id": 27246, "url": "https://patchwork.libcamera.org/api/patches/27246/?format=api", "web_url": "https://patchwork.libcamera.org/patch/27246/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260706113900.2530549-2-bryan.odonoghue@linaro.org>", "date": "2026-07-06T11:38:54", "name": "[v5,1/7] libcamera: software_isp: debayer_egl: Pass eglImage as parameter to setShaderVariables", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "6cfa7f4ff004a514ed7180481ae8fa4a2a191a73", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/27246/mbox/", "series": [ { "id": 6041, "url": "https://patchwork.libcamera.org/api/series/6041/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6041", "date": "2026-07-06T11:38:53", "name": "libcamera: software_isp: gpu: Add go faster stripes", "version": 5, "mbox": "https://patchwork.libcamera.org/series/6041/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/27246/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/27246/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AD278C330A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 6 Jul 2026 11:39:14 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1BFE466023;\n\tMon, 6 Jul 2026 13:39:14 +0200 (CEST)", "from mail-wm1-x336.google.com (mail-wm1-x336.google.com\n\t[IPv6:2a00:1450:4864:20::336])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5F34265EFF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 6 Jul 2026 13:39:12 +0200 (CEST)", "by mail-wm1-x336.google.com with SMTP id\n\t5b1f17b1804b1-493c1950518so19422195e9.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 06 Jul 2026 04:39:12 -0700 (PDT)", "from inspiron14p-linux ([109.77.44.220])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-47a9de1e6ccsm24796084f8f.5.2026.07.06.04.39.11\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 06 Jul 2026 04:39:11 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"jv6ch5f5\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1783337952; x=1783942752;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=s3J/NrfJsMXq4eaqAQimcvyIokeKF2MgvnNr4M7DXMo=;\n\tb=jv6ch5f5sy41XS74LiRTV0INiZ4dYhr/P3zUci17PlA15ceeDOZqeKvxdMbzhVqjt6\n\tIa6dwf6LiQByDDWELTA2HIg5VLUZud0gTLAvx+Nl+RzH146EtU+brA89Hsf/xXkwd96W\n\tmbrYwbu6A0HPi/k6FqDRy1RMVxb7p3zjpVZ0vHs7i/PdgUtqGWI8FvBmz5w/OwjzSmOw\n\tcJ2Y1022arBjr8GmuiouXMfgpAsZS+kDPPzM+izFxXS5WRL8oyJwXCIQ6spE6b/2kDc8\n\tWkMt5BQyqtBs/NyJgsf8BjZUKuZruG3zj/w0Rjit7tXtjv3QO2wsWyhoFjrbrtP6uRId\n\tppAA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20251104; t=1783337952; x=1783942752;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=s3J/NrfJsMXq4eaqAQimcvyIokeKF2MgvnNr4M7DXMo=;\n\tb=JzXWKYRM3VjXxE/fC/VFfVxDNnK5qQvOqNonX13tWEWfVbaLRNEeH79w+dR5kEErh2\n\tAalOkJ7TSKscGZE3L0/WBB+woIUXGUHxcX/jKAQrZ1L1lXhaxT1qvv68ZGVFuPhA6ASO\n\tBpLSH8xyf27vEyslV1VfF8KMkqnTYDPewKOkKWSsJD3/4hPslMESJ5qglX2drFyz/mU+\n\t+2EdZFnjycw8nZ62yx0GlcP3WczS6V3OpwsLPEbXBFDnNqY+duFOqum1trBHN/IwlFQr\n\tke3MHCy1OoexlChnPqxSLbh4Fi5sF2uMT7ElBfIshHcNF0IVj5JNxZxfSMGRbC82BExt\n\tcPyw==", "X-Gm-Message-State": "AOJu0YxCr+303pQlckGVXKZ8XdUQGqiDwEIH2eATd9c9WdwcJmiv9oGm\n\tTPsElrzrzvREcKcRBowppy8OElicVH+112Tq8XwCaDG/mdtngVOuLXSh/bVvgBwlevNyzVIjUGA\n\tcpdHo", "X-Gm-Gg": "AfdE7clQ2lEExzHfH+bOsZ6nJlhMOpcVR2zBAIG8N78fUsqIYmpABSDs39d0r6Y5lJa\n\t4rwm/Y/n6P340vE4LMb2JLwIHAtzC3na1GpZ1V6frYxlpQnZDik8s22yGqspNwYqEerHeHPOuG7\n\trpZ/SmaCxOhyWs8FF//cRIbiZI2Zh4hUl3p+wOcDRQx+33BgsdVCc9sPBSWibPETMRbj97lkpIO\n\tPG+NIyrnLH7pkg4T1pbT8FCqMTXvYn2yXmZmSWTop/01qZNTF7wnuwSZIpNY0oCrcwisndEVWW1\n\tUGGtE/rPc2jaI7uMKdbyH5RSeg8d5DeBBG2alMpC/hgOC0k2AJZdT/NGYEyrXPE5dxD4JIgQWyJ\n\t5vuWp9aomNTuibtm+YEe/I1Q4hafuZXD4thIVFTuT7F2fD0s3rbVGuS+nGrLGEVZT/a9Pv33oZI\n\tXslRxpi0zoMYRYy80rWkTfVB2wGPhe", "X-Received": "by 2002:a05:600c:1908:b0:493:d3c5:6c32 with SMTP id\n\t5b1f17b1804b1-493decbf10amr4212745e9.6.1783337951887; \n\tMon, 06 Jul 2026 04:39:11 -0700 (PDT)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "bryan.odonoghue@linaro.org, pavel@ucw.cz,\n\tRobert Mader <robert.mader@collabora.com>,\n\tMilan Zamazal <mzamazal@redhat.com>", "Subject": "[PATCH v5 1/7] libcamera: software_isp: debayer_egl: Pass eglImage\n\tas parameter to setShaderVariables", "Date": "Mon, 6 Jul 2026 12:38:54 +0100", "Message-ID": "<20260706113900.2530549-2-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.54.0", "In-Reply-To": "<20260706113900.2530549-1-bryan.odonoghue@linaro.org>", "References": "<20260706113900.2530549-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "We will create a cache of textures and eGLImages which means the value\nassigned to the shader texture unit will come from one of those now cached\neGLImage objects.\n\nPass eGLImage as a parameter to facilitate future differentiation.\n\nReviewed-by: Robert Mader <robert.mader@collabora.com>\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/software_isp/debayer_egl.cpp | 6 +++---\n src/libcamera/software_isp/debayer_egl.h | 2 +-\n 2 files changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/libcamera/software_isp/debayer_egl.cpp b/src/libcamera/software_isp/debayer_egl.cpp\nindex 56545816e..c3a7b7952 100644\n--- a/src/libcamera/software_isp/debayer_egl.cpp\n+++ b/src/libcamera/software_isp/debayer_egl.cpp\n@@ -388,7 +388,7 @@ uint32_t DebayerEGL::preferredInputStride(const PixelFormat &inputFormat, const\n \treturn info.stride(size.width, 0, 256);\n }\n \n-void DebayerEGL::setShaderVariableValues(const DebayerParams ¶ms)\n+void DebayerEGL::setShaderVariableValues(eGLImage &eglImageIn, const DebayerParams ¶ms)\n {\n \t/*\n \t * Raw Bayer 8-bit, and packed raw Bayer 10-bit/12-bit formats\n@@ -444,7 +444,7 @@ void DebayerEGL::setShaderVariableValues(const DebayerParams ¶ms)\n \t * To simultaneously sample multiple textures we need to use multiple\n \t * texture units\n \t */\n-\tglUniform1i(textureUniformBayerDataIn_, eglImageBayerIn_->texture_unit_uniform_id_);\n+\tglUniform1i(textureUniformBayerDataIn_, eglImageIn.texture_unit_uniform_id_);\n \n \t/*\n \t * These values are:\n@@ -533,7 +533,7 @@ int DebayerEGL::debayerGPU(FrameBuffer *input, FrameBuffer *output, const Debaye\n \t/* Generate the output render framebuffer as render to texture */\n \tegl_.createOutputDMABufTexture2D(*eglImageBayerOut_, output->planes()[0].fd.get());\n \n-\tsetShaderVariableValues(params);\n+\tsetShaderVariableValues(*eglImageBayerIn_, params);\n \tglViewport(0, 0, width_, height_);\n \tglClear(GL_COLOR_BUFFER_BIT);\n \tglDrawArrays(GL_TRIANGLE_FAN, 0, DEBAYER_OPENGL_COORDS);\ndiff --git a/src/libcamera/software_isp/debayer_egl.h b/src/libcamera/software_isp/debayer_egl.h\nindex 4c7c86472..348d7305b 100644\n--- a/src/libcamera/software_isp/debayer_egl.h\n+++ b/src/libcamera/software_isp/debayer_egl.h\n@@ -65,7 +65,7 @@ private:\n \tstatic int getOutputConfig(PixelFormat outputFormat, DebayerOutputConfig &config);\n \tint initBayerShaders(PixelFormat inputFormat, PixelFormat outputFormat);\n \tint getShaderVariableLocations();\n-\tvoid setShaderVariableValues(const DebayerParams ¶ms);\n+\tvoid setShaderVariableValues(eGLImage &eGLImageIn, const DebayerParams ¶ms);\n \tint debayerGPU(FrameBuffer *input, FrameBuffer *output, const DebayerParams ¶ms, std::optional<MappedFrameBuffer> *mappedInputBuffer, std::optional<DmaSyncer> *inputBufferDmaSyncer);\n \n \t/* Shader program identifiers */\n", "prefixes": [ "v5", "1/7" ] }