Patch Detail
Show a patch.
GET /api/patches/27214/?format=api
{ "id": 27214, "url": "https://patchwork.libcamera.org/api/patches/27214/?format=api", "web_url": "https://patchwork.libcamera.org/patch/27214/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260706-libipa-algorithms-v3-14-968757b038bb@ideasonboard.com>", "date": "2026-07-06T08:01:34", "name": "[v3,14/35] ipa: libipa: lsc: Move Interpolator<lsc::Components> to lsc_base", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "4aff27e4a768a912ecc4a2e6a30d9d9f693b1774", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/27214/mbox/", "series": [ { "id": 6038, "url": "https://patchwork.libcamera.org/api/series/6038/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6038", "date": "2026-07-06T08:01:20", "name": "ipa: libipa: Introduce libipa algorithms", "version": 3, "mbox": "https://patchwork.libcamera.org/series/6038/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/27214/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/27214/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id ED594C3308\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 6 Jul 2026 08:02:19 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 92A2F66029;\n\tMon, 6 Jul 2026 10:02:19 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1AC4065EFF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 6 Jul 2026 10:02:07 +0200 (CEST)", "from [192.168.125.177] (mob-109-113-60-81.net.vodafone.it\n\t[109.113.60.81])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C46363DCB;\n\tMon, 6 Jul 2026 10:01:18 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Ph6LJNb0\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1783324879;\n\tbh=k8xx+n2HYzN5DqXOt0UsO1jSOSRlbXvar8LoCiAJnEk=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=Ph6LJNb0OLjfuy8BNNyfEFqQPaqNhEVwaWlIBzGnVvE/xb6oeBjGQrBxrCRK7Itly\n\tjACeDqbTHTk9CGkGFttR7jmbiFYr+W2lqHKYpdbVbcK3RM9s1b2rH0c2elfMhbOzvb\n\t84rN3ovYmXjAIzGUq8x98t1FdvfzuNUqw6mi8XiE=", "From": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Date": "Mon, 06 Jul 2026 10:01:34 +0200", "Subject": "[PATCH v3 14/35] ipa: libipa: lsc: Move\n\tInterpolator<lsc::Components> to lsc_base", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20260706-libipa-algorithms-v3-14-968757b038bb@ideasonboard.com>", "References": "<20260706-libipa-algorithms-v3-0-968757b038bb@ideasonboard.com>", "In-Reply-To": "<20260706-libipa-algorithms-v3-0-968757b038bb@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org, \n\tStefan Klug <stefan.klug@ideasonboard.com>", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "X-Mailer": "b4 0.14.3", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=3266;\n\ti=jacopo.mondi@ideasonboard.com; h=from:subject:message-id;\n\tbh=k8xx+n2HYzN5DqXOt0UsO1jSOSRlbXvar8LoCiAJnEk=;\n\tb=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBqS2Dw9U/pmS4lu3hPkbq1LnMtHOKbRUeEghzFB\n\tyqAalZr/RqJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCaktg8AAKCRByNAaPFqFW\n\tPMu9D/9dAsTes+GRqDtHvk/EUJuz5hBig2ElM0nTcpggiH040dSm3RKvUBBzZfOzYgLeS0pUdlw\n\tEmLfhMADb7bgNq9x5kDU+6zjCYZzRWU0aS54j8sHYA7O7YBJdt1mfZZ7qnpirQnqRpzPiQlYjTe\n\tg7B3pnb+UpxQQ0J01c2hKh/FRnJeo7ts5wJWvGZpCUThe7zn21Z4dIRWTvM2tiM2Y5UTrF5TGUU\n\taQ1q32X1mm3YisTI4Zt4kamGMaP38XWhtOm2vX5V69AbrBvyu5KrZmeoKySg/mIpfV2RRtM3Sgh\n\tJflR/kfkDESpEZtee1skRFlg4yse0Cwn4Red8RQtVJYucBLnr5y95n4N3CTX4OpL/KMB9nQ8R4m\n\tnztFYJlp20VJQE77eH5eFoSLlJmrOqQl1X+jIeyWkfwWwR9p429DtRtxEX7bRqbr18s9Cw8x+Zo\n\t2AAoeZR+WJaJLkJ0CsUq9q9Ygmb7cpO5zQIcmOnno64v4/Bz/QfANqAvlFk1zFSVznke4PegRlj\n\tcUYaAK3p2WVmTfnRGQMJN6Esqmee67FjyNkW66XARz2dxS3BWb48aSRzZSM8VXOWQk4msxgeA0u\n\tmZwyHC0M991qhks2Ok46dt7FipxGwOMBmIpFlr21kNtk0+iIRm0ba8nGNJn5kzCp1wmC5RbYJSB\n\tNOt0+IArx5UAYKQ==", "X-Developer-Key": "i=jacopo.mondi@ideasonboard.com; a=openpgp;\n\tfpr=72392EDC88144A65C701EA9BA5826A2587AD026B", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Move the Interpolator<lsc::Components>: specialization from the RkISP1\nIPA to the lsc_base header.\n\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\n src/ipa/libipa/lsc_base.cpp | 15 +++++++++++++++\n src/ipa/libipa/lsc_base.h | 21 +++++++++++++++++++++\n src/ipa/rkisp1/algorithms/lsc.cpp | 27 ---------------------------\n 3 files changed, 36 insertions(+), 27 deletions(-)", "diff": "diff --git a/src/ipa/libipa/lsc_base.cpp b/src/ipa/libipa/lsc_base.cpp\nindex d545e9a5f7ed..bddf131b85e2 100644\n--- a/src/ipa/libipa/lsc_base.cpp\n+++ b/src/ipa/libipa/lsc_base.cpp\n@@ -49,6 +49,21 @@ namespace lsc {\n \n } /* namespace lsc */\n \n+#ifndef __DOXYGEN__\n+template<>\n+void Interpolator<lsc::Components>::\n+\tinterpolate(const lsc::Components &a,\n+\t\t const lsc::Components &b,\n+\t\t lsc::Components &dest,\n+\t\t double lambda)\n+{\n+\tinterpolateVector(a.r, b.r, dest.r, lambda);\n+\tinterpolateVector(a.gr, b.gr, dest.gr, lambda);\n+\tinterpolateVector(a.gb, b.gb, dest.gb, lambda);\n+\tinterpolateVector(a.b, b.b, dest.b, lambda);\n+}\n+#endif\n+\n /**\n * \\class LscImplementation\n * \\brief Pure virtual base class for lsc algorithm implementations\ndiff --git a/src/ipa/libipa/lsc_base.h b/src/ipa/libipa/lsc_base.h\nindex 93f819d3c2af..51cc35888209 100644\n--- a/src/ipa/libipa/lsc_base.h\n+++ b/src/ipa/libipa/lsc_base.h\n@@ -18,6 +18,8 @@\n \n #include \"libcamera/internal/value_node.h\"\n \n+#include \"interpolator.h\"\n+\n namespace libcamera {\n \n namespace ipa {\n@@ -35,6 +37,25 @@ using ComponentsMap = std::map<unsigned int, Components>;\n \n } /* namespace lsc */\n \n+#ifndef __DOXYGEN__\n+template<typename T>\n+void interpolateVector(const std::vector<T> &a, const std::vector<T> &b,\n+\t\t std::vector<T> &dest, double lambda)\n+{\n+\tASSERT(a.size() == b.size());\n+\tdest.resize(a.size());\n+\tfor (size_t i = 0; i < a.size(); i++)\n+\t\tdest[i] = a[i] * (1.0 - lambda) + b[i] * lambda;\n+}\n+\n+template<>\n+void Interpolator<lsc::Components>::\n+\tinterpolate(const lsc::Components &a,\n+\t\t const lsc::Components &b,\n+\t\t lsc::Components &dest,\n+\t\t double lambda);\n+#endif /* __DOXYGEN__ */\n+\n class LscImplementation\n {\n public:\ndiff --git a/src/ipa/rkisp1/algorithms/lsc.cpp b/src/ipa/rkisp1/algorithms/lsc.cpp\nindex 6c6dce08704c..fec698234583 100644\n--- a/src/ipa/rkisp1/algorithms/lsc.cpp\n+++ b/src/ipa/rkisp1/algorithms/lsc.cpp\n@@ -25,33 +25,6 @@\n \n namespace libcamera {\n \n-namespace ipa {\n-\n-template<typename T>\n-void interpolateVector(const std::vector<T> &a, const std::vector<T> &b,\n-\t\t std::vector<T> &dest, double lambda)\n-{\n-\tASSERT(a.size() == b.size());\n-\tdest.resize(a.size());\n-\tfor (size_t i = 0; i < a.size(); i++)\n-\t\tdest[i] = a[i] * (1.0 - lambda) + b[i] * lambda;\n-}\n-\n-template<>\n-void Interpolator<lsc::Components>::\n-\tinterpolate(const lsc::Components &a,\n-\t\t const lsc::Components &b,\n-\t\t lsc::Components &dest,\n-\t\t double lambda)\n-{\n-\tinterpolateVector(a.r, b.r, dest.r, lambda);\n-\tinterpolateVector(a.gr, b.gr, dest.gr, lambda);\n-\tinterpolateVector(a.gb, b.gb, dest.gb, lambda);\n-\tinterpolateVector(a.b, b.b, dest.b, lambda);\n-}\n-\n-} /* namespace ipa */\n-\n namespace ipa::rkisp1::algorithms {\n \n \n", "prefixes": [ "v3", "14/35" ] }