Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 272,
    "url": "https://patchwork.libcamera.org/api/patches/272/?format=api",
    "web_url": "https://patchwork.libcamera.org/patch/272/",
    "project": {
        "id": 1,
        "url": "https://patchwork.libcamera.org/api/projects/1/?format=api",
        "name": "libcamera",
        "link_name": "libcamera",
        "list_id": "libcamera_core",
        "list_email": "libcamera-devel@lists.libcamera.org",
        "web_url": "",
        "scm_url": "",
        "webscm_url": ""
    },
    "msgid": "<20190118130823.22541-1-laurent.pinchart@ideasonboard.com>",
    "date": "2019-01-18T13:08:23",
    "name": "[libcamera-devel] libcamera: utils: Don't use C++17 nested namespaces",
    "commit_ref": "576c9454cfc9529852a7b0da3e5bfb465fb4baa5",
    "pull_url": null,
    "state": "accepted",
    "archived": false,
    "hash": "fb1681610d29b749bb12b849a341f58e46c031df",
    "submitter": {
        "id": 2,
        "url": "https://patchwork.libcamera.org/api/people/2/?format=api",
        "name": "Laurent Pinchart",
        "email": "laurent.pinchart@ideasonboard.com"
    },
    "delegate": null,
    "mbox": "https://patchwork.libcamera.org/patch/272/mbox/",
    "series": [
        {
            "id": 92,
            "url": "https://patchwork.libcamera.org/api/series/92/?format=api",
            "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=92",
            "date": "2019-01-18T13:08:23",
            "name": "[libcamera-devel] libcamera: utils: Don't use C++17 nested namespaces",
            "version": 1,
            "mbox": "https://patchwork.libcamera.org/series/92/mbox/"
        }
    ],
    "comments": "https://patchwork.libcamera.org/api/patches/272/comments/",
    "check": "pending",
    "checks": "https://patchwork.libcamera.org/api/patches/272/checks/",
    "tags": {},
    "headers": {
        "Return-Path": "<laurent.pinchart@ideasonboard.com>",
        "Received": [
            "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7499C60B21\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 18 Jan 2019 14:08:28 +0100 (CET)",
            "from pendragon.bb.dnainternet.fi\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 875CA53E;\n\tFri, 18 Jan 2019 14:08:27 +0100 (CET)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1547816907;\n\tbh=OOj6KAG732QihTkrUVvs6MhGvt3ktxZrf9xPiTMi7lI=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=REfdyUO9FR9THPza3Bt3xgN4gBU8mcX1Mf35XH87mwBxbycnxAcm+blsjjqDeextL\n\toYNMUcYyywimjrGKmaFa7FsQYUWs8AbPlcKkCdx/5VOqkPeLdxMlNCQHtJRIR+VVTs\n\t6sXir6xj1DHnoipwB3/VGx7PAG7mmcB4CBEW4G7A=",
        "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>",
        "To": "libcamera-devel@lists.libcamera.org",
        "Date": "Fri, 18 Jan 2019 15:08:23 +0200",
        "Message-Id": "<20190118130823.22541-1-laurent.pinchart@ideasonboard.com>",
        "X-Mailer": "git-send-email 2.19.2",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[libcamera-devel] [PATCH] libcamera: utils: Don't use C++17 nested\n\tnamespaces",
        "X-BeenThere": "libcamera-devel@lists.libcamera.org",
        "X-Mailman-Version": "2.1.23",
        "Precedence": "list",
        "List-Id": "<libcamera-devel.lists.libcamera.org>",
        "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>",
        "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>",
        "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>",
        "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>",
        "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>",
        "X-List-Received-Date": "Fri, 18 Jan 2019 13:08:28 -0000"
    },
    "content": "Nesting namespace names in a single namespace declaration is a C++17\nfeature. As libcamera depends on C++11 only, nest two separate namespace\ndeclarations instead.\n\nReported-by: Shik Chen <shik@google.com>\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/include/utils.h | 8 ++++++--\n 1 file changed, 6 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/src/libcamera/include/utils.h b/src/libcamera/include/utils.h\nindex a2e450b35372..73fa2e69b029 100644\n--- a/src/libcamera/include/utils.h\n+++ b/src/libcamera/include/utils.h\n@@ -11,7 +11,9 @@\n \n #define ARRAY_SIZE(a)\t(sizeof(a) / sizeof(a[0]))\n \n-namespace libcamera::utils {\n+namespace libcamera {\n+\n+namespace utils {\n \n /* C++11 doesn't provide std::make_unique */\n template<typename T, typename... Args>\n@@ -20,6 +22,8 @@ std::unique_ptr<T> make_unique(Args&&... args)\n \treturn std::unique_ptr<T>(new T(std::forward<Args>(args)...));\n }\n \n-} /* namespace libcamera::utils */\n+} /* namespace utils */\n+\n+} /* namespace libcamera */\n \n #endif /* __LIBCAMERA_UTILS_H__ */\n",
    "prefixes": [
        "libcamera-devel"
    ]
}