Patch Detail
Show a patch.
GET /api/patches/27184/?format=api
{ "id": 27184, "url": "https://patchwork.libcamera.org/api/patches/27184/?format=api", "web_url": "https://patchwork.libcamera.org/patch/27184/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260703153819.1088752-6-barnabas.pocze@ideasonboard.com>", "date": "2026-07-03T15:38:07", "name": "[RFC,v1,05/17] ipa: rkisp1: Move sensor control info map to context", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "6a6ce112d9b18cae99ab21d19e042bab2294cd07", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/27184/mbox/", "series": [ { "id": 6036, "url": "https://patchwork.libcamera.org/api/series/6036/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6036", "date": "2026-07-03T15:38:02", "name": "ipa: libipa: agc rework", "version": 1, "mbox": "https://patchwork.libcamera.org/series/6036/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/27184/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/27184/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8062DC3261\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 3 Jul 2026 15:38:38 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3074065FFC;\n\tFri, 3 Jul 2026 17:38:31 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DC5A865FCB\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 3 Jul 2026 17:38:23 +0200 (CEST)", "from pb-laptop.local (185.221.140.128.nat.pool.zt.hu\n\t[185.221.140.128])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D3152DF3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 3 Jul 2026 17:37:37 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"khJPFneL\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1783093057;\n\tbh=qj6xAoXwMzwAsdLgf2Etgr5CiR0/gXBNUh7XMvtKIvs=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=khJPFneLi4ZMHiHoYnBueSV8aUpAN01JSw3+ThPARvERdN5idyTxBp4OhpRcSlbq7\n\thfKoki9vqFgHnUUt8yUl2mmef3ecjHtqiGjyDkn5zBnH2IAr/7VQYGnlsuEO6nslGK\n\tixnDXZk4yJkJyMGNH2jl6wZy9vpGsOnL/FOm2dRY=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[RFC PATCH v1 05/17] ipa: rkisp1: Move sensor control info map to\n\tcontext", "Date": "Fri, 3 Jul 2026 17:38:07 +0200", "Message-ID": "<20260703153819.1088752-6-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.54.0", "In-Reply-To": "<20260703153819.1088752-1-barnabas.pocze@ideasonboard.com>", "References": "<20260703153819.1088752-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "So that it is available to each algorithm. This will be used\nby the AGC algorithm.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n src/ipa/rkisp1/ipa_context.cpp | 3 +++\n src/ipa/rkisp1/ipa_context.h | 2 ++\n src/ipa/rkisp1/rkisp1.cpp | 25 +++++++++++--------------\n 3 files changed, 16 insertions(+), 14 deletions(-)", "diff": "diff --git a/src/ipa/rkisp1/ipa_context.cpp b/src/ipa/rkisp1/ipa_context.cpp\nindex 302b4cfd70..1f94afda6b 100644\n--- a/src/ipa/rkisp1/ipa_context.cpp\n+++ b/src/ipa/rkisp1/ipa_context.cpp\n@@ -488,6 +488,9 @@ namespace libcamera::ipa::rkisp1 {\n *\n * \\var IPAContext::frameContexts\n * \\brief Ring buffer of per-frame contexts\n+ *\n+ * \\var IPAContext::sensorControls\n+ * \\brief V4L2 controls of the sensor\n */\n \n } /* namespace libcamera::ipa::rkisp1 */\ndiff --git a/src/ipa/rkisp1/ipa_context.h b/src/ipa/rkisp1/ipa_context.h\nindex 9a4e0f12c6..eff88b72f5 100644\n--- a/src/ipa/rkisp1/ipa_context.h\n+++ b/src/ipa/rkisp1/ipa_context.h\n@@ -252,6 +252,8 @@ struct IPAContext {\n \n \tControlInfoMap::Map ctrlMap;\n \n+\tControlInfoMap sensorControls;\n+\n \tDebugMetadata debugMetadata;\n \n \t/* Interface to the Camera Helper */\ndiff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex 273540a330..9f1f133e6f 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -75,15 +75,12 @@ protected:\n \n private:\n \tvoid updateControls(const IPACameraSensorInfo &sensorInfo,\n-\t\t\t const ControlInfoMap &sensorControls,\n \t\t\t ControlInfoMap *ipaControls);\n \tvoid setControls(unsigned int frame);\n \n \tstd::map<unsigned int, FrameBuffer> buffers_;\n \tstd::map<unsigned int, MappedFrameBuffer> mappedBuffers_;\n \n-\tControlInfoMap sensorControls_;\n-\n \t/* Local parameter storage */\n \tstruct IPAContext context_;\n };\n@@ -163,6 +160,7 @@ int IPARkISP1::init(const IPASettings &settings, unsigned int hwRevision,\n \tLOG(IPARkISP1, Debug) << \"Hardware revision is \" << hwRevision;\n \n \tcontext_.sensorInfo = sensorInfo;\n+\tcontext_.sensorControls = sensorControls;\n \n \tcontext_.camHelper = CameraSensorHelperFactoryBase::create(settings.sensorModel);\n \tif (!context_.camHelper) {\n@@ -207,7 +205,7 @@ int IPARkISP1::init(const IPASettings &settings, unsigned int hwRevision,\n \t\treturn ret;\n \n \t/* Initialize controls. */\n-\tupdateControls(sensorInfo, sensorControls, ipaControls);\n+\tupdateControls(sensorInfo, ipaControls);\n \n \treturn 0;\n }\n@@ -227,13 +225,13 @@ int IPARkISP1::configure(const IPAConfigInfo &ipaConfig,\n \t\t\t const std::map<uint32_t, IPAStream> &streamConfig,\n \t\t\t ControlInfoMap *ipaControls)\n {\n-\tsensorControls_ = ipaConfig.sensorControls;\n+\tcontext_.sensorControls = ipaConfig.sensorControls;\n \n-\tconst auto itExp = sensorControls_.find(V4L2_CID_EXPOSURE);\n+\tconst auto itExp = context_.sensorControls.find(V4L2_CID_EXPOSURE);\n \tint32_t minExposure = itExp->second.min().get<int32_t>();\n \tint32_t maxExposure = itExp->second.max().get<int32_t>();\n \n-\tconst auto itGain = sensorControls_.find(V4L2_CID_ANALOGUE_GAIN);\n+\tconst auto itGain = context_.sensorControls.find(V4L2_CID_ANALOGUE_GAIN);\n \tint32_t minGain = itGain->second.min().get<int32_t>();\n \tint32_t maxGain = itGain->second.max().get<int32_t>();\n \n@@ -253,7 +251,7 @@ int IPARkISP1::configure(const IPAConfigInfo &ipaConfig,\n \tcontext_.configuration.sensor.lineDuration = info.minLineLength * 1.0s / info.pixelRate;\n \n \t/* Update the camera controls using the new sensor settings. */\n-\tupdateControls(info, sensorControls_, ipaControls);\n+\tupdateControls(info, ipaControls);\n \n \t/*\n \t * When the AGC computes the new exposure values for a frame, it needs\n@@ -385,7 +383,6 @@ void IPARkISP1::processStats(const uint32_t frame, const uint32_t bufferId,\n }\n \n void IPARkISP1::updateControls(const IPACameraSensorInfo &sensorInfo,\n-\t\t\t const ControlInfoMap &sensorControls,\n \t\t\t ControlInfoMap *ipaControls)\n {\n \tControlInfoMap::Map ctrlMap = rkisp1Controls;\n@@ -395,7 +392,7 @@ void IPARkISP1::updateControls(const IPACameraSensorInfo &sensorInfo,\n \t * limits and the line duration.\n \t */\n \tdouble lineDuration = context_.configuration.sensor.lineDuration.get<std::micro>();\n-\tconst ControlInfo &v4l2Exposure = sensorControls.find(V4L2_CID_EXPOSURE)->second;\n+\tconst ControlInfo &v4l2Exposure = context_.sensorControls.find(V4L2_CID_EXPOSURE)->second;\n \tint32_t minExposure = v4l2Exposure.min().get<int32_t>() * lineDuration;\n \tint32_t maxExposure = v4l2Exposure.max().get<int32_t>() * lineDuration;\n \tint32_t defExposure = v4l2Exposure.def().get<int32_t>() * lineDuration;\n@@ -404,7 +401,7 @@ void IPARkISP1::updateControls(const IPACameraSensorInfo &sensorInfo,\n \t\t\tstd::forward_as_tuple(minExposure, maxExposure, defExposure));\n \n \t/* Compute the analogue gain limits. */\n-\tconst ControlInfo &v4l2Gain = sensorControls.find(V4L2_CID_ANALOGUE_GAIN)->second;\n+\tconst ControlInfo &v4l2Gain = context_.sensorControls.find(V4L2_CID_ANALOGUE_GAIN)->second;\n \tfloat minGain = context_.camHelper->gain(v4l2Gain.min().get<int32_t>());\n \tfloat maxGain = context_.camHelper->gain(v4l2Gain.max().get<int32_t>());\n \tfloat defGain = context_.camHelper->gain(v4l2Gain.def().get<int32_t>());\n@@ -418,11 +415,11 @@ void IPARkISP1::updateControls(const IPACameraSensorInfo &sensorInfo,\n \t * The frame length is computed assuming a fixed line length combined\n \t * with the vertical frame sizes.\n \t */\n-\tconst ControlInfo &v4l2HBlank = sensorControls.find(V4L2_CID_HBLANK)->second;\n+\tconst ControlInfo &v4l2HBlank = context_.sensorControls.find(V4L2_CID_HBLANK)->second;\n \tuint32_t hblank = v4l2HBlank.def().get<int32_t>();\n \tuint32_t lineLength = sensorInfo.outputSize.width + hblank;\n \n-\tconst ControlInfo &v4l2VBlank = sensorControls.find(V4L2_CID_VBLANK)->second;\n+\tconst ControlInfo &v4l2VBlank = context_.sensorControls.find(V4L2_CID_VBLANK)->second;\n \tstd::array<uint32_t, 3> frameHeights{\n \t\tv4l2VBlank.min().get<int32_t>() + sensorInfo.outputSize.height,\n \t\tv4l2VBlank.max().get<int32_t>() + sensorInfo.outputSize.height,\n@@ -460,7 +457,7 @@ void IPARkISP1::setControls(unsigned int frame)\n \t\t<< \"Set controls for frame \" << frame << \": exposure \" << exposure\n \t\t<< \", gain \" << frameContext.agc.gain << \", vblank \" << vblank;\n \n-\tControlList ctrls(sensorControls_);\n+\tControlList ctrls(context_.sensorControls);\n \tctrls.set(V4L2_CID_EXPOSURE, static_cast<int32_t>(exposure));\n \tctrls.set(V4L2_CID_ANALOGUE_GAIN, static_cast<int32_t>(gain));\n \tctrls.set(V4L2_CID_VBLANK, static_cast<int32_t>(vblank));\n", "prefixes": [ "RFC", "v1", "05/17" ] }