Patch Detail
Show a patch.
GET /api/patches/27180/?format=api
{ "id": 27180, "url": "https://patchwork.libcamera.org/api/patches/27180/?format=api", "web_url": "https://patchwork.libcamera.org/patch/27180/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260703153819.1088752-2-barnabas.pocze@ideasonboard.com>", "date": "2026-07-03T15:38:03", "name": "[RFC,v1,01/17] ipa: simple: Fix control presence sanity check", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "d429a08e66869d372cbee686e79d01ea6eac51ab", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/27180/mbox/", "series": [ { "id": 6036, "url": "https://patchwork.libcamera.org/api/series/6036/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6036", "date": "2026-07-03T15:38:02", "name": "ipa: libipa: agc rework", "version": 1, "mbox": "https://patchwork.libcamera.org/series/6036/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/27180/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/27180/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B42D9C3261\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 3 Jul 2026 15:38:30 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 50F3765FEF;\n\tFri, 3 Jul 2026 17:38:27 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 567FC65FC1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 3 Jul 2026 17:38:23 +0200 (CEST)", "from pb-laptop.local (185.221.140.128.nat.pool.zt.hu\n\t[185.221.140.128])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E77D81121\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 3 Jul 2026 17:37:36 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"fTV0hEWg\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1783093057;\n\tbh=2uoOx1wfKuNJtedF4ojlGyj05mcIY26CqhY3YV3/jTc=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=fTV0hEWgPEytBEBYNIfdeNdVlsPjydx39M6OZwlyVjZVWxsbZCO9/B3dy9tIjI/YS\n\tFRm0x9oXq8xKjLtbgjSL1VZ0GbC2/pbCoujGjPW9KOaD8XsSU4DY9360vfMfJN8MMQ\n\trZlovqyMWeRd1LXL8F/wGlBJurxm4wqTYAGDZLJ0=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[RFC PATCH v1 01/17] ipa: simple: Fix control presence sanity check", "Date": "Fri, 3 Jul 2026 17:38:03 +0200", "Message-ID": "<20260703153819.1088752-2-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.54.0", "In-Reply-To": "<20260703153819.1088752-1-barnabas.pocze@ideasonboard.com>", "References": "<20260703153819.1088752-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Check existence before the values are retrieved.\n\nLink: https://gitlab.freedesktop.org/camera/libcamera/-/work_items/241\nFixes: fb8ad13dc3e3 (\"libcamera: software_isp: Move exposure+gain to an algorithm module\")\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n src/ipa/simple/soft_simple.cpp | 14 +++++++-------\n 1 file changed, 7 insertions(+), 7 deletions(-)", "diff": "diff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp\nindex 629e1a32de..2a41b5bac8 100644\n--- a/src/ipa/simple/soft_simple.cpp\n+++ b/src/ipa/simple/soft_simple.cpp\n@@ -299,6 +299,13 @@ void IPASoftSimple::processStats(const uint32_t frame,\n \t\t\t\t [[maybe_unused]] const uint32_t bufferId,\n \t\t\t\t const ControlList &sensorControls)\n {\n+\t/* Sanity check */\n+\tif (!sensorControls.contains(V4L2_CID_EXPOSURE) ||\n+\t !sensorControls.contains(V4L2_CID_ANALOGUE_GAIN)) {\n+\t\tLOG(IPASoft, Error) << \"Control(s) missing\";\n+\t\treturn;\n+\t}\n+\n \tIPAFrameContext &frameContext = context_.frameContexts.get(frame);\n \n \tframeContext.sensor.exposure =\n@@ -311,13 +318,6 @@ void IPASoftSimple::processStats(const uint32_t frame,\n \t\talgo->process(context_, frame, frameContext, stats_, metadata);\n \tmetadataReady.emit(frame, metadata);\n \n-\t/* Sanity check */\n-\tif (!sensorControls.contains(V4L2_CID_EXPOSURE) ||\n-\t !sensorControls.contains(V4L2_CID_ANALOGUE_GAIN)) {\n-\t\tLOG(IPASoft, Error) << \"Control(s) missing\";\n-\t\treturn;\n-\t}\n-\n \tControlList ctrls(sensorInfoMap_);\n \n \tauto &againNew = frameContext.sensor.gain;\n", "prefixes": [ "RFC", "v1", "01/17" ] }