Patch Detail
Show a patch.
GET /api/patches/27149/?format=api
{ "id": 27149, "url": "https://patchwork.libcamera.org/api/patches/27149/?format=api", "web_url": "https://patchwork.libcamera.org/patch/27149/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260701040721.145659-2-hpa@redhat.com>", "date": "2026-07-01T04:07:18", "name": "[v4,1/4] libcamera: pub_key: Add ML-DSA-65 signature algorithm for PQC compliance", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "fa21674643a94aee04922180f96756cebc0f97f8", "submitter": { "id": 105, "url": "https://patchwork.libcamera.org/api/people/105/?format=api", "name": "Kate Hsuan", "email": "hpa@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/27149/mbox/", "series": [ { "id": 6030, "url": "https://patchwork.libcamera.org/api/series/6030/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6030", "date": "2026-07-01T04:07:17", "name": "Implement ML-DSA-65 for Post-Quantum Cryptographic compliance", "version": 4, "mbox": "https://patchwork.libcamera.org/series/6030/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/27149/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/27149/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8FB48C3301\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 1 Jul 2026 04:07:54 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3254065F8D;\n\tWed, 1 Jul 2026 06:07:54 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5883465F29\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 1 Jul 2026 06:07:53 +0200 (CEST)", "from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-711-ooas6dszPwesBubIlm5kNA-1;\n\tWed, 01 Jul 2026 00:07:48 -0400", "from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.95])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 3D6221964CCF; Wed, 1 Jul 2026 04:07:47 +0000 (UTC)", "from fedora.redhat.com (unknown [10.67.32.18])\n\tby mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 1E3F436936; Wed, 1 Jul 2026 04:07:43 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"i1E3bKUF\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1782878872;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=z4v9OmyikCG6t4glmU0P1PyKbCqy0i6mJeJVlwWYDDs=;\n\tb=i1E3bKUFOKT2nYq6773eiw0MKIKp3EMNYgDfSoHw48ORZtDLF4WzmMzNIuJht1L9GGiK+Y\n\tA7YIy30HB2/O4RdfAEhyTUHU2VfT2GCiRhZN+0A1Y5XvjHrW/i1arn43Af203m1m9beZ6e\n\tgKlPulYwv92/CIt7IpQ5TzmqLQhdiao=", "X-MC-Unique": "ooas6dszPwesBubIlm5kNA-1", "X-Mimecast-MFC-AGG-ID": "ooas6dszPwesBubIlm5kNA_1782878867", "From": "Kate Hsuan <hpa@redhat.com>", "To": "libcamera-devel@lists.libcamera.org, =?utf-8?b?QmFybmFiw6FzIFDFkWN6?=\n\t=?utf-8?q?e?= <barnabas.pocze@ideasonboard.com>, Kieran Bingham\n\t<kieran.bingham@ideasonboard.com>, Laurent Pinchart\n\t<laurent.pinchart@ideasonboard.com>", "Cc": "Kate Hsuan <hpa@redhat.com>", "Subject": "[PATCH v4 1/4] libcamera: pub_key: Add ML-DSA-65 signature algorithm\n\tfor PQC compliance", "Date": "Wed, 1 Jul 2026 12:07:18 +0800", "Message-ID": "<20260701040721.145659-2-hpa@redhat.com>", "In-Reply-To": "<20260701040721.145659-1-hpa@redhat.com>", "References": "<20260701040721.145659-1-hpa@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.6 on 10.30.177.95", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "7CHVK2hj8kEvQEh8HMxAIXT3K8ntPWebeC7l2EE3s6s_1782878867", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "With RSA slated for deprecation by 2035, the IPA signature algorithm must\nbe migrated to a Post-Quantum Cryptography (PQC) standard. Accordingly,\nwe are adopting the NIST-finalized ML-DSA signature scheme. Among the\navailable variants, ML-DSA-44, ML-DSA-65, and ML-DSA-87, which offer\nvarying levels of data integrity protection. ML-DSA-65 has been selected\nto sign the IPA due to its balanced performance for general-purpose\napplications.\n\nLink: https://csrc.nist.gov/projects/post-quantum-cryptography/post-quantum-cryptography-standardization/evaluation-criteria/security-(evaluation-criteria)\nLink: https://nvlpubs.nist.gov/nistpubs/ir/2024/NIST.IR.8547.ipd.pdf\nSigned-off-by: Kate Hsuan <hpa@redhat.com>\n---\n src/libcamera/pub_key.cpp | 45 ++++++++++++++++++++++-----------------\n 1 file changed, 25 insertions(+), 20 deletions(-)", "diff": "diff --git a/src/libcamera/pub_key.cpp b/src/libcamera/pub_key.cpp\nindex f1d73a5c..539a4e6d 100644\n--- a/src/libcamera/pub_key.cpp\n+++ b/src/libcamera/pub_key.cpp\n@@ -14,8 +14,13 @@\n #include <openssl/x509.h>\n #elif HAVE_GNUTLS\n #include <gnutls/abstract.h>\n+#include <gnutls/gnutls.h>\n #endif\n \n+#include <libcamera/base/utils.h>\n+\n+#include \"libcamera/internal/pub_key.h\"\n+\n /**\n * \\file pub_key.h\n * \\brief Public key signature verification\n@@ -28,12 +33,17 @@ namespace libcamera {\n * \\brief Public key wrapper for signature verification\n *\n * The PubKey class wraps a public key and implements signature verification. It\n- * only supports RSA keys and the RSA-SHA256 signature algorithm.\n+ * supports RSA keys with the RSA-SHA256 signature algorithm, or ML-DSA-65 keys\n+ * as specified in NIST FIPS 204. The signature algorithm is determined at\n+ * compile time.\n */\n \n /**\n * \\brief Construct a PubKey from key data\n * \\param[in] key Key data encoded in DER format\n+ *\n+ * Supported key types are RSA (verified with RSA-SHA256) and ML-DSA-65\n+ * (verified as ML-DSA-65 according to FIPS 204).\n */\n PubKey::PubKey([[maybe_unused]] Span<const uint8_t> key)\n \t: valid_(false)\n@@ -83,7 +93,7 @@ PubKey::~PubKey()\n * \\param[in] sig The signature\n *\n * Verify that the signature \\a sig matches the signed \\a data for the public\n- * key. The signture algorithm is hardcoded to RSA-SHA256.\n+ * key.\n *\n * \\return True if the signature is valid, false otherwise\n */\n@@ -94,30 +104,21 @@ bool PubKey::verify([[maybe_unused]] Span<const uint8_t> data,\n \t\treturn false;\n \n #if HAVE_CRYPTO\n-\t/*\n-\t * Create and initialize a public key algorithm context for signature\n-\t * verification.\n-\t */\n-\tEVP_PKEY_CTX *ctx = EVP_PKEY_CTX_new(pubkey_, nullptr);\n+\tEVP_MD_CTX *ctx = EVP_MD_CTX_new();\n \tif (!ctx)\n \t\treturn false;\n \n-\tif (EVP_PKEY_verify_init(ctx) <= 0 ||\n-\t EVP_PKEY_CTX_set_rsa_padding(ctx, RSA_PKCS1_PADDING) <= 0 ||\n-\t EVP_PKEY_CTX_set_signature_md(ctx, EVP_sha256()) <= 0) {\n-\t\tEVP_PKEY_CTX_free(ctx);\n+\tutils::scope_exit ctxGuard([&] { EVP_MD_CTX_free(ctx); });\n+\n+\tif (EVP_DigestVerifyInit(ctx, nullptr, nullptr, nullptr,\n+\t\t\t\t pubkey_) <= 0)\n \t\treturn false;\n-\t}\n \n-\t/* Calculate the SHA256 digest of the data. */\n-\tuint8_t digest[SHA256_DIGEST_LENGTH];\n-\tSHA256(data.data(), data.size(), digest);\n+\tint ret = EVP_DigestVerify(ctx, sig.data(), sig.size(),\n+\t\t\t\t data.data(), data.size());\n \n-\t/* Decrypt the signature and verify it matches the digest. */\n-\tint ret = EVP_PKEY_verify(ctx, sig.data(), sig.size(), digest,\n-\t\t\t\t SHA256_DIGEST_LENGTH);\n-\tEVP_PKEY_CTX_free(ctx);\n \treturn ret == 1;\n+\n #elif HAVE_GNUTLS\n \tconst gnutls_datum_t gnuTlsData{\n \t\tconst_cast<unsigned char *>(data.data()),\n@@ -129,8 +130,12 @@ bool PubKey::verify([[maybe_unused]] Span<const uint8_t> data,\n \t\tstatic_cast<unsigned int>(sig.size())\n \t};\n \n-\tint ret = gnutls_pubkey_verify_data2(pubkey_, GNUTLS_SIGN_RSA_SHA256, 0,\n+\tconstexpr gnutls_sign_algorithm_t algo =\n+\t\tstd::string(IPA_MODULE_DIR_SIGNATURE_ALGO) == std::string(\"ml-dsa-65\") ? GNUTLS_SIGN_MLDSA65 : GNUTLS_SIGN_RSA_SHA256;\n+\n+\tint ret = gnutls_pubkey_verify_data2(pubkey_, algo, 0,\n \t\t\t\t\t &gnuTlsData, &gnuTlsSig);\n+\n \treturn ret >= 0;\n #else\n \treturn false;\n", "prefixes": [ "v4", "1/4" ] }