Patch Detail
Show a patch.
GET /api/patches/27136/?format=api
{ "id": 27136, "url": "https://patchwork.libcamera.org/api/patches/27136/?format=api", "web_url": "https://patchwork.libcamera.org/patch/27136/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260630083031.3197714-2-laurent.pinchart@ideasonboard.com>", "date": "2026-06-30T08:30:28", "name": "[1/4] libcamera: shaders: Move header generation to shaders directory", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "8e5cda7fb709d7989d9e7b4162ff4d5ea13dc224", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/27136/mbox/", "series": [ { "id": 6027, "url": "https://patchwork.libcamera.org/api/series/6027/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6027", "date": "2026-06-30T08:30:27", "name": "libcamera: Improve shader header generation", "version": 1, "mbox": "https://patchwork.libcamera.org/series/6027/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/27136/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/27136/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5489BC3264\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 30 Jun 2026 08:30:36 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0DA7165F44;\n\tTue, 30 Jun 2026 10:30:36 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E61B465F3D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 30 Jun 2026 10:30:34 +0200 (CEST)", "from killaraus.ideasonboard.com\n\t(2001-14ba-70f3-e800--a06.rev.dnainternet.fi\n\t[IPv6:2001:14ba:70f3:e800::a06])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E86ECD52;\n\tTue, 30 Jun 2026 10:29:50 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"TkPNS0ad\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1782808191;\n\tbh=DrcjWOg6Ivq0gSPYlbd8/w+kFElaFQqO7rfUPeoQ+bc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=TkPNS0adtELyDXRAQzOpIZHnk6PTOc/lSX9VCWv16EeEJARqTjSdOByRVeAPdKt8v\n\twcb6BjTqkgSbzBFFJ5Cf1F4ldh2BXCTzYIVM7IBOc+nXB6VLZ5DEKWgnYv4SnxZMZW\n\tKXHUSHnkeL0npt8O4ZPTFyS6sRjMn4J+cnvFMF1k=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "Subject": "[PATCH 1/4] libcamera: shaders: Move header generation to shaders\n\tdirectory", "Date": "Tue, 30 Jun 2026 11:30:28 +0300", "Message-ID": "<20260630083031.3197714-2-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260630083031.3197714-1-laurent.pinchart@ideasonboard.com>", "References": "<20260630083031.3197714-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The src/libcamera/shaders/ directory contains all libcamera shaders for\nthe software ISP. Move the related build logic to convert shaders to\nheaders to the same directory to make shaders self-contained.\n\nThis changes the location of the glsl_shaders.h header, update\ndebayer_egl.cpp accordingly.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/meson.build | 10 ----------\n src/libcamera/shaders/meson.build | 10 ++++++++++\n src/libcamera/software_isp/debayer_egl.cpp | 2 +-\n 3 files changed, 11 insertions(+), 11 deletions(-)", "diff": "diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\nindex 6aedacbdb04d..17c1b2cb3479 100644\n--- a/src/libcamera/meson.build\n+++ b/src/libcamera/meson.build\n@@ -184,16 +184,6 @@ libcamera_deps += [\n libyaml,\n ]\n \n-# Generate headers from shaders\n-libcamera_shader_headers = custom_target(\n- 'gen-shader-headers',\n- input : [shader_files],\n- output : 'glsl_shaders.h',\n- command : [gen_shader_headers, meson.project_source_root(), '@OUTPUT@', '@INPUT@'],\n-)\n-\n-libcamera_internal_headers += libcamera_shader_headers\n-\n # We add '/' to the build_rpath as a 'safe' path to act as a boolean flag.\n # The build_rpath is stripped at install time by meson, so we determine at\n # runtime if the library is running from an installed location by checking\ndiff --git a/src/libcamera/shaders/meson.build b/src/libcamera/shaders/meson.build\nindex dd441a577670..adac77327a3b 100644\n--- a/src/libcamera/shaders/meson.build\n+++ b/src/libcamera/shaders/meson.build\n@@ -8,3 +8,13 @@ shader_files = files([\n 'bayer_unpacked.vert',\n 'identity.vert',\n ])\n+\n+# Generate headers from shaders\n+libcamera_shader_headers = custom_target(\n+ 'gen-shader-headers',\n+ input : [shader_files],\n+ output : 'glsl_shaders.h',\n+ command : [gen_shader_headers, meson.project_source_root(), '@OUTPUT@', '@INPUT@'],\n+)\n+\n+libcamera_internal_headers += libcamera_shader_headers\ndiff --git a/src/libcamera/software_isp/debayer_egl.cpp b/src/libcamera/software_isp/debayer_egl.cpp\nindex 0ec2a98cfafb..af9b9d426920 100644\n--- a/src/libcamera/software_isp/debayer_egl.cpp\n+++ b/src/libcamera/software_isp/debayer_egl.cpp\n@@ -24,7 +24,7 @@\n #include \"libcamera/internal/formats.h\"\n #include \"libcamera/internal/framebuffer.h\"\n \n-#include \"../glsl_shaders.h\"\n+#include \"../shaders/glsl_shaders.h\"\n \n namespace libcamera {\n \n", "prefixes": [ "1/4" ] }