Patch Detail
Show a patch.
GET /api/patches/27113/?format=api
{ "id": 27113, "url": "https://patchwork.libcamera.org/api/patches/27113/?format=api", "web_url": "https://patchwork.libcamera.org/patch/27113/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260629163017.863145-34-barnabas.pocze@ideasonboard.com>", "date": "2026-06-29T16:29:56", "name": "[RFC,v1,33/54] libcamera: pipeline_handler: Use `std::deque`", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "e08fa96eddc681282520a75281835cab48b5e8a9", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/27113/mbox/", "series": [ { "id": 6025, "url": "https://patchwork.libcamera.org/api/series/6025/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6025", "date": "2026-06-29T16:29:23", "name": "libcamera: Split requests and buffers", "version": 1, "mbox": "https://patchwork.libcamera.org/series/6025/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/27113/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/27113/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 26418C3261\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 29 Jun 2026 16:31:25 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9BFCD65F9D;\n\tMon, 29 Jun 2026 18:31:24 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 574D165F5D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 29 Jun 2026 18:30:28 +0200 (CEST)", "from pb-laptop.local (185.221.140.128.nat.pool.zt.hu\n\t[185.221.140.128])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2E488E91\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 29 Jun 2026 18:29:45 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"T6nfMgIM\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1782750585;\n\tbh=L5i53BnAprfOLEtDEsx738K9H6ut2Q3E9lZn67Z1evo=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=T6nfMgIMsbqecOO2Og80SmRIekHc1LXmw6oyni3K6BXavU4CpG/lNrJxB0MJkptl9\n\taaJSvUrIiaHBp2b+d5p0dA16wJM6rkEaNaDSPFg7UkZPmmVjNToOwCE1dqrdGc+TLb\n\tK76HQL4WPL8UobV65iu32vMfMULrFl2na3DUfKn8=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[RFC PATCH v1 33/54] libcamera: pipeline_handler: Use `std::deque`", "Date": "Mon, 29 Jun 2026 18:29:56 +0200", "Message-ID": "<20260629163017.863145-34-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.54.0", "In-Reply-To": "<20260629163017.863145-1-barnabas.pocze@ideasonboard.com>", "References": "<20260629163017.863145-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "`std::queue` already uses `std::deque` as its implementation, so there is\nno difference there. And getting a specific index of `std::list` is a linear\noperation, so replace it with an `std::deque`, to enable pipeline handlers\nto look into the list more easily.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n include/libcamera/internal/camera.h | 7 +++----\n src/libcamera/pipeline_handler.cpp | 8 ++++----\n 2 files changed, 7 insertions(+), 8 deletions(-)", "diff": "diff --git a/include/libcamera/internal/camera.h b/include/libcamera/internal/camera.h\nindex 13b72258ff..7298b150e5 100644\n--- a/include/libcamera/internal/camera.h\n+++ b/include/libcamera/internal/camera.h\n@@ -8,9 +8,8 @@\n #pragma once\n \n #include <atomic>\n-#include <list>\n+#include <deque>\n #include <memory>\n-#include <queue>\n #include <set>\n #include <stdint.h>\n #include <string>\n@@ -40,8 +39,8 @@ public:\n \tPipelineHandler *pipe() { return pipe_.get(); }\n \tconst PipelineHandler *pipe() const { return pipe_.get(); }\n \n-\tstd::list<Request *> queuedRequests_;\n-\tstd::queue<Request *> waitingRequests_;\n+\tstd::deque<Request *> queuedRequests_;\n+\tstd::deque<Request *> waitingRequests_;\n \tControlInfoMap controlInfo_;\n \tControlList properties_;\n \ndiff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\nindex 16f218831c..ad1174d043 100644\n--- a/src/libcamera/pipeline_handler.cpp\n+++ b/src/libcamera/pipeline_handler.cpp\n@@ -399,7 +399,7 @@ void PipelineHandler::stop(Camera *camera)\n \t * after the device to keep them in order.\n \t */\n \tCamera::Private *data = camera->_d();\n-\tstd::queue<Request *> waitingRequests;\n+\tstd::deque<Request *> waitingRequests;\n \twaitingRequests.swap(data->waitingRequests_);\n \n \t/* Stop the pipeline handler and let the queued requests complete. */\n@@ -408,7 +408,7 @@ void PipelineHandler::stop(Camera *camera)\n \t/* Cancel and signal as complete all waiting requests. */\n \twhile (!waitingRequests.empty()) {\n \t\tRequest *request = waitingRequests.front();\n-\t\twaitingRequests.pop();\n+\t\twaitingRequests.pop_front();\n \n \t\t/*\n \t\t * Cancel all requests by marking them as cancelled and calling\n@@ -498,7 +498,7 @@ void PipelineHandler::queueRequest(Request *request)\n \n \tCamera *camera = request->_d()->camera();\n \tCamera::Private *data = camera->_d();\n-\tdata->waitingRequests_.push(request);\n+\tdata->waitingRequests_.push_back(request);\n \n \tdoQueueRequests(camera);\n }\n@@ -582,7 +582,7 @@ void PipelineHandler::doQueueRequests(Camera *camera)\n \t\t * Pop the request first, in case doQueueRequests() is called\n \t\t * recursively from within doQueueRequest()\n \t\t */\n-\t\tdata->waitingRequests_.pop();\n+\t\tdata->waitingRequests_.pop_front();\n \t\tdoQueueRequest(request);\n \t}\n }\n", "prefixes": [ "RFC", "v1", "33/54" ] }