Patch Detail
Show a patch.
GET /api/patches/27091/?format=api
{ "id": 27091, "url": "https://patchwork.libcamera.org/api/patches/27091/?format=api", "web_url": "https://patchwork.libcamera.org/patch/27091/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260629163017.863145-13-barnabas.pocze@ideasonboard.com>", "date": "2026-06-29T16:29:35", "name": "[RFC,v1,12/54] v4l2: v4l2_camera: Use buffer cookie for indexing", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "c2cef62185b8b64b32d9e24b57b8e2c4b90450db", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/27091/mbox/", "series": [ { "id": 6025, "url": "https://patchwork.libcamera.org/api/series/6025/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6025", "date": "2026-06-29T16:29:23", "name": "libcamera: Split requests and buffers", "version": 1, "mbox": "https://patchwork.libcamera.org/series/6025/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/27091/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/27091/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D0DDDC3261\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 29 Jun 2026 16:30:56 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2889F65F82;\n\tMon, 29 Jun 2026 18:30:43 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 977CC65F39\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 29 Jun 2026 18:30:23 +0200 (CEST)", "from pb-laptop.local (185.221.140.128.nat.pool.zt.hu\n\t[185.221.140.128])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 60B13E91;\n\tMon, 29 Jun 2026 18:29:40 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"iGzZ79M9\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1782750580;\n\tbh=tnSy/eZmIIF5YrJtuFfnYAzv1u7FY/Wjzbz6Ecb77Us=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=iGzZ79M92UDDcFQibz8ZKGWkzqLtsXar5p8u5F901qHtb8d1smE4DdLpach9B1IRk\n\tgPbFGa05o1wfTP2ukmm77a9aF50LLWrTyeKYvKOtV/LLL+0hiGOFnFv/4fTvBytHNS\n\tccWmTvKerdPj1KC90Asxk3vfrbVvu5rjyOi/waMk=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>", "Subject": "[RFC PATCH v1 12/54] v4l2: v4l2_camera: Use buffer cookie for\n\tindexing", "Date": "Mon, 29 Jun 2026 18:29:35 +0200", "Message-ID": "<20260629163017.863145-13-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.54.0", "In-Reply-To": "<20260629163017.863145-1-barnabas.pocze@ideasonboard.com>", "References": "<20260629163017.863145-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Use the buffer cookie to store the index of the buffer instead of\nrelying on the 1-to-1 association between requests and buffers,\nwhich will be broken by the split of requests and buffers.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\nReviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/v4l2/v4l2_camera.cpp | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/v4l2/v4l2_camera.cpp b/src/v4l2/v4l2_camera.cpp\nindex 75428b8adc..7dd0ea1ef9 100644\n--- a/src/v4l2/v4l2_camera.cpp\n+++ b/src/v4l2/v4l2_camera.cpp\n@@ -87,7 +87,7 @@ void V4L2Camera::requestComplete(Request *request)\n \t/* We only have one stream at the moment. */\n \tbufferLock_.lock();\n \tFrameBuffer *buffer = request->buffers().begin()->second;\n-\tcompletedBuffers_.emplace_back(request->cookie(), buffer->metadata());\n+\tcompletedBuffers_.emplace_back(buffer->cookie(), buffer->metadata());\n \tbufferLock_.unlock();\n \n \tuint64_t data = 1;\n@@ -171,6 +171,8 @@ int V4L2Camera::allocBuffers()\n \t\t\treturn -ENOMEM;\n \t\t}\n \t\trequestPool_.push_back(std::move(request));\n+\n+\t\tbuffers[i]->setCookie(i);\n \t}\n \n \treturn buffers.size();\n", "prefixes": [ "RFC", "v1", "12/54" ] }