Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 27034,
    "url": "https://patchwork.libcamera.org/api/patches/27034/?format=api",
    "web_url": "https://patchwork.libcamera.org/patch/27034/",
    "project": {
        "id": 1,
        "url": "https://patchwork.libcamera.org/api/projects/1/?format=api",
        "name": "libcamera",
        "link_name": "libcamera",
        "list_id": "libcamera_core",
        "list_email": "libcamera-devel@lists.libcamera.org",
        "web_url": "",
        "scm_url": "",
        "webscm_url": ""
    },
    "msgid": "<20260624085849.873784-9-bryan.odonoghue@linaro.org>",
    "date": "2026-06-24T08:58:47",
    "name": "[08/10] libcamera: software_isp: debayer_egl: Pass eglImage as parameter to setShaderVariables",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": false,
    "hash": "6cfa7f4ff004a514ed7180481ae8fa4a2a191a73",
    "submitter": {
        "id": 175,
        "url": "https://patchwork.libcamera.org/api/people/175/?format=api",
        "name": "Bryan O'Donoghue",
        "email": "bryan.odonoghue@linaro.org"
    },
    "delegate": null,
    "mbox": "https://patchwork.libcamera.org/patch/27034/mbox/",
    "series": [
        {
            "id": 6015,
            "url": "https://patchwork.libcamera.org/api/series/6015/?format=api",
            "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6015",
            "date": "2026-06-24T08:58:39",
            "name": "libcamera: software_isp: gpu: Add go faster stripes",
            "version": 1,
            "mbox": "https://patchwork.libcamera.org/series/6015/mbox/"
        }
    ],
    "comments": "https://patchwork.libcamera.org/api/patches/27034/comments/",
    "check": "pending",
    "checks": "https://patchwork.libcamera.org/api/patches/27034/checks/",
    "tags": {},
    "headers": {
        "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>",
        "X-Original-To": "parsemail@patchwork.libcamera.org",
        "Delivered-To": "parsemail@patchwork.libcamera.org",
        "Received": [
            "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0ACD2C3308\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 24 Jun 2026 08:59:20 +0000 (UTC)",
            "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AB16D658A6;\n\tWed, 24 Jun 2026 10:59:19 +0200 (CEST)",
            "from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com\n\t[IPv6:2a00:1450:4864:20::32f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5EDE365881\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 24 Jun 2026 10:59:06 +0200 (CEST)",
            "by mail-wm1-x32f.google.com with SMTP id\n\t5b1f17b1804b1-49258ac7294so5342045e9.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 24 Jun 2026 01:59:06 -0700 (PDT)",
            "from inspiron14p-linux ([109.76.100.231])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-49261063d6esm25128375e9.2.2026.06.24.01.59.05\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 24 Jun 2026 01:59:05 -0700 (PDT)"
        ],
        "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"vpSEMMCB\"; dkim-atps=neutral",
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1782291546; x=1782896346;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=nRwCPeGqJXiXkiIP/SKGTBYoNGqKiysO7kBIfJxUMRk=;\n\tb=vpSEMMCBMr6HXaY+g33V7PF5PDeULohpEDuurDh96uEyRlb1FDijlNhmbP/kZYFs+L\n\tYi84o2hCI2M2Oz6MOoy7RfXcPwQ3XMf4N6G50g3+bl3xXHIihFOiZfzD+x8uNvPwYqA8\n\t9bOm42BXkXxs7I+ZW248zxZoU53E9zCARPnhJq7MhHF6FC18ugHIDx6Lr5yz2AT6HBv8\n\th7gbLVk6AM3NG98pB3RAhcizZ+JAURCDGFbcHeNCbBUfLRNR1r1miBI3FOD3CNVB1MYm\n\t8oUYzRtMyAIL/encVL+ObcvYND+5GWCAdPiPff3GfBBT9E881cqnt7Qz1dxqwGp3MWCj\n\tH3OA==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20251104; t=1782291546; x=1782896346;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=nRwCPeGqJXiXkiIP/SKGTBYoNGqKiysO7kBIfJxUMRk=;\n\tb=I2fDzgEtLlSPp8SkSSjzn0acrH79XvT1iaZUEz8hfgm38f55/qpSWbpT7Djp4qG2VM\n\tod1BcfUO3e1eMCDZBnf2YFToyCYP3TZ/DRYtG7984N4qTjM7PcnGYkfHKpbRuy5rhwrE\n\tYOo1RaaYh7rfiyBVlGjCXTsFURyegTL/hMhKAOXGFFDyxlhZ1LJgvHZYGlnlzBFLmRPs\n\t9sZY9NietQeL1H4rbPtvCkxf+0wHZQVZuddyvt7g9iqmDzPh2HnT+bWU95fR9H++Ilu2\n\tLTIrSCOq3LiQFhF+0MuP3Z4FQWZ7HMK74j9LulM7DlO7Hwsag7S45gHPCM7zhocHff1j\n\tQptg==",
        "X-Gm-Message-State": "AOJu0Yw4zEhWNblmJTPSpYYezBHZV/dWlMN/HFAvp+szHkF0UrF6IW0n\n\tzNEWKT5fwkb0LTK9R/eKhBLQ+jsHPe45KaYSWy42dnMxWPXSGrsQEQScidh1K1M/6zBizydCxys\n\tyWd2zwoQ=",
        "X-Gm-Gg": "AfdE7cmD61pIFhfuo6xUHvH26Kx5OpjKNg1xTYer2EuAJpzUEuJzQLpZQe1u1KT8Q+u\n\taLfPuc+B7Up319CoGdx52vT8rpeKHbo4UnICW/MPxK/kMldo9KNbxhlia6jBtZYQC5C2W6nymEJ\n\txKBjxLfw3ubdLrjDDymrwIS0mdsItud2dck8UbnER+/Ahg7gi1YOw9HbbPkHLfaTqkLGFB+wq0M\n\tAMz0TweaeR/j/GIO50oz+JRiarJzn2c2U88s7iYtGOnJHRuZ22B3VBqcqp3G5WKeE5jl9miziuc\n\th8jzj57ZBVPBfOF91tjYgR+mrwoflEXutOEosfD0llXE7uMzSoLGNIVaNgI6UEu4I9xzhrydg40\n\t95E+N1nNw43xekHDhhriFndOCcqNV+WwVE6wllAEYDc6EuO178/E0mwt+wa4tpB/blRhZ3fbC9E\n\tCVswh2ni/J5QUTm1iTMBHKb51ZBlMYc1cqeFE4kpA=",
        "X-Received": "by 2002:a05:600c:3f07:b0:490:c024:2eba with SMTP id\n\t5b1f17b1804b1-49260872b71mr31522885e9.22.1782291545875; \n\tWed, 24 Jun 2026 01:59:05 -0700 (PDT)",
        "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>",
        "To": "libcamera-devel@lists.libcamera.org",
        "Cc": "bryan.odonoghue@linaro.org,\n\tpavel@ucw.cz",
        "Subject": "[PATCH 08/10] libcamera: software_isp: debayer_egl: Pass eglImage as\n\tparameter to setShaderVariables",
        "Date": "Wed, 24 Jun 2026 09:58:47 +0100",
        "Message-ID": "<20260624085849.873784-9-bryan.odonoghue@linaro.org>",
        "X-Mailer": "git-send-email 2.54.0",
        "In-Reply-To": "<20260624085849.873784-1-bryan.odonoghue@linaro.org>",
        "References": "<20260624085849.873784-1-bryan.odonoghue@linaro.org>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "X-BeenThere": "libcamera-devel@lists.libcamera.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "<libcamera-devel.lists.libcamera.org>",
        "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>",
        "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>",
        "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>",
        "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>",
        "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>",
        "Errors-To": "libcamera-devel-bounces@lists.libcamera.org",
        "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"
    },
    "content": "We will create a cache of textures and eGLImages which means the value\nassigned to the shader texture unit will come from one of those now cached\neGLImage objects.\n\nPass eGLImage as a parameter to facilitate future differentiation.\n\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/software_isp/debayer_egl.cpp | 6 +++---\n src/libcamera/software_isp/debayer_egl.h   | 2 +-\n 2 files changed, 4 insertions(+), 4 deletions(-)",
    "diff": "diff --git a/src/libcamera/software_isp/debayer_egl.cpp b/src/libcamera/software_isp/debayer_egl.cpp\nindex cdceacf96..f6b7b11e1 100644\n--- a/src/libcamera/software_isp/debayer_egl.cpp\n+++ b/src/libcamera/software_isp/debayer_egl.cpp\n@@ -397,7 +397,7 @@ uint32_t DebayerEGL::preferredInputStride(const PixelFormat &inputFormat, const\n \treturn info.stride(size.width, 0, 256);\n }\n \n-void DebayerEGL::setShaderVariableValues(const DebayerParams &params)\n+void DebayerEGL::setShaderVariableValues(eGLImage &eglImageIn, const DebayerParams &params)\n {\n \t/*\n \t * Raw Bayer 8-bit, and packed raw Bayer 10-bit/12-bit formats\n@@ -453,7 +453,7 @@ void DebayerEGL::setShaderVariableValues(const DebayerParams &params)\n \t * To simultaneously sample multiple textures we need to use multiple\n \t * texture units\n \t */\n-\tglUniform1i(textureUniformBayerDataIn_, eglImageBayerIn_->texture_unit_uniform_id_);\n+\tglUniform1i(textureUniformBayerDataIn_, eglImageIn.texture_unit_uniform_id_);\n \n \t/*\n \t * These values are:\n@@ -542,7 +542,7 @@ int DebayerEGL::debayerGPU(FrameBuffer *input, FrameBuffer *output, const Debaye\n \t/* Generate the output render framebuffer as render to texture */\n \tegl_.createOutputDMABufTexture2D(*eglImageBayerOut_, output->planes()[0].fd.get());\n \n-\tsetShaderVariableValues(params);\n+\tsetShaderVariableValues(*eglImageBayerIn_, params);\n \tglViewport(0, 0, width_, height_);\n \tglClear(GL_COLOR_BUFFER_BIT);\n \tglDrawArrays(GL_TRIANGLE_FAN, 0, DEBAYER_OPENGL_COORDS);\ndiff --git a/src/libcamera/software_isp/debayer_egl.h b/src/libcamera/software_isp/debayer_egl.h\nindex 4c7c86472..348d7305b 100644\n--- a/src/libcamera/software_isp/debayer_egl.h\n+++ b/src/libcamera/software_isp/debayer_egl.h\n@@ -65,7 +65,7 @@ private:\n \tstatic int getOutputConfig(PixelFormat outputFormat, DebayerOutputConfig &config);\n \tint initBayerShaders(PixelFormat inputFormat, PixelFormat outputFormat);\n \tint getShaderVariableLocations();\n-\tvoid setShaderVariableValues(const DebayerParams &params);\n+\tvoid setShaderVariableValues(eGLImage &eGLImageIn, const DebayerParams &params);\n \tint debayerGPU(FrameBuffer *input, FrameBuffer *output, const DebayerParams &params, std::optional<MappedFrameBuffer> *mappedInputBuffer, std::optional<DmaSyncer> *inputBufferDmaSyncer);\n \n \t/* Shader program identifiers */\n",
    "prefixes": [
        "08/10"
    ]
}