Patch Detail
Show a patch.
GET /api/patches/27028/?format=api
{ "id": 27028, "url": "https://patchwork.libcamera.org/api/patches/27028/?format=api", "web_url": "https://patchwork.libcamera.org/patch/27028/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260624085849.873784-3-bryan.odonoghue@linaro.org>", "date": "2026-06-24T08:58:41", "name": "[02/10] libcamera: egl: Add new helper attachTextureToFBO", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "ab7e7374ad9f125c072ddf3e4a2bd1cd1cfd2f4e", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/27028/mbox/", "series": [ { "id": 6015, "url": "https://patchwork.libcamera.org/api/series/6015/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6015", "date": "2026-06-24T08:58:39", "name": "libcamera: software_isp: gpu: Add go faster stripes", "version": 1, "mbox": "https://patchwork.libcamera.org/series/6015/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/27028/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/27028/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0A9DFC3306\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 24 Jun 2026 08:59:10 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 74A7465890;\n\tWed, 24 Jun 2026 10:59:07 +0200 (CEST)", "from mail-wm1-x331.google.com (mail-wm1-x331.google.com\n\t[IPv6:2a00:1450:4864:20::331])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0856265881\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 24 Jun 2026 10:59:02 +0200 (CEST)", "by mail-wm1-x331.google.com with SMTP id\n\t5b1f17b1804b1-490ace40f4bso7839925e9.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 24 Jun 2026 01:59:02 -0700 (PDT)", "from inspiron14p-linux ([109.76.100.231])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-49261063d6esm25128375e9.2.2026.06.24.01.59.00\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 24 Jun 2026 01:59:01 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"z2Vy+Mm9\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1782291541; x=1782896341;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=DGSX4mJkH/NgV4HkrvHTAen8yB9jSEbQDaqlO5PH55E=;\n\tb=z2Vy+Mm9PhuTr3ApY5O29hlXis/BXAx36Ph4zocNYSzxWk4GwHHjAk2H2Bej5jLsIk\n\tzE35UYTovo7Fh5WDZuCKJ5jmWiL1UXXf88xn9PlQcOzVdnqY+b0DxP2AR2FW0oIuh0Yk\n\tJlLPwHISTj55xkx7sIGJ4W5qeoi8NFFQuh9/J+xNCslJd71FF4DgQglsn06ymRe6FrwE\n\tv6O+Q057BRQUms4So1GKzPQiaalxLxYxxMvuauqWDR80X189A0uBxqquQKqGMAKp4yeF\n\tRCEfURXTEktle//v08++EAfK3NOH1nDvmOchBh3QEbuZJH7jBDYSzNOSHCKV4vZRo/0g\n\t/vug==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20251104; t=1782291541; x=1782896341;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=DGSX4mJkH/NgV4HkrvHTAen8yB9jSEbQDaqlO5PH55E=;\n\tb=FOayKRD8ro3nCvFSIDdsnnFYQnWdTzTbNAmri8lY/cdtKRXSNIzmb224WkXBi9JQmS\n\tVIDqpk8TcVQ2qA/svr858MXmloJQ5Y6pHDz0QXcS+QQxoqHJunwR9kescy7QQYzNub8F\n\tVngkvFg5pho2hjvj5Bv/52OZS1ZcmfEhMvyneqmMeZofsfJAjQrGL3DfQewpsSWH/RLh\n\tApa9j2H0DNlv5rhYPRmu7T0ahxD1dCG8zlUpUtJOzCyBqgiRbvYrkumY2n9F3Wwar6At\n\tDTEVjYRN+BwNcQvdrbRA+FmHhQfdQmqTxOCR3cqV1GdUAC55tqyxHqFPNLQ5qI/9lA4u\n\te8DQ==", "X-Gm-Message-State": "AOJu0YyyZByKwlZ1N4YbW/GxIkkjq0eGALbcEI5MEYM2SYEVWidNwwTM\n\tX2AG1akH5569X4xcwP8VV04Ck+D8mGiJFg4sYLsoR0fMmQ22j/QOk8Qfrm/EQYEXPvQvpr28clD\n\tz02uRZuo=", "X-Gm-Gg": "AfdE7clvfcaPq55Cmjj/RgNxdbE11cYixmjo4Gu5cSdgypIs1XWbgvIu9iaXIe2c0k0\n\tIhHB752RU5/JumA4Vpng8MTDBkohVrS1WegiM2GWii/qEp/NgYmo9aBIiSoPWDQt5RwgBqxQwZV\n\td5iXmB4FHxaGJiS3bNTdHVETyULO7XnBXH5GXeT9UeJl+GAl/U6Ob2E1NdZGOGv5GqLJdzwVFmE\n\tu0TYr0Vd8aZOvIXkvPcUqtAlAcfhKIqX9arkaS722jtyNd7ns2n75h/GRAgkmjXT9hWSeXslK31\n\tCHljVdU20SMqAdS+9KUlTqFday790CcCD/iPHt66D9/FI5oAszZAGxajSkFptnR4KgkFXWWn9Cs\n\tONipXpXFj0xnAqdJTHeO1VEhE2j1FhP4Y18GmtbYmtrzdccOhAnkYejyUbbB0tUt0/iEyNIqVqy\n\toy7Q37A1lSNGTwcDzZlnsf0EFNauhiMBN5Cq9sciM=", "X-Received": "by 2002:a05:600c:4ecb:b0:492:37b7:607a with SMTP id\n\t5b1f17b1804b1-492608796bemr33705045e9.31.1782291541557; \n\tWed, 24 Jun 2026 01:59:01 -0700 (PDT)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "bryan.odonoghue@linaro.org,\n\tpavel@ucw.cz", "Subject": "[PATCH 02/10] libcamera: egl: Add new helper attachTextureToFBO", "Date": "Wed, 24 Jun 2026 09:58:41 +0100", "Message-ID": "<20260624085849.873784-3-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.54.0", "In-Reply-To": "<20260624085849.873784-1-bryan.odonoghue@linaro.org>", "References": "<20260624085849.873784-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This method does what it says on the tin. It attaches a texture to a\nframebuffer object, splitting existing code into a helper function which we\nwill use in subsequent patches.\n\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n include/libcamera/internal/egl.h | 2 ++\n src/libcamera/egl.cpp | 42 +++++++++++++++++++++++---------\n 2 files changed, 32 insertions(+), 12 deletions(-)", "diff": "diff --git a/include/libcamera/internal/egl.h b/include/libcamera/internal/egl.h\nindex f7bfb28d4..4b0757afd 100644\n--- a/include/libcamera/internal/egl.h\n+++ b/include/libcamera/internal/egl.h\n@@ -109,6 +109,8 @@ public:\n \tint createOutputDMABufTexture2D(eGLImage &eglImage, int fd);\n \tvoid createTexture2D(eGLImage &eglImage, void *data);\n \n+\tint attachTextureToFBO(eGLImage &eglImage);\n+\n \tvoid pushEnv(std::vector<std::string> &shaderEnv, const char *str);\n \tvoid makeCurrent();\n \ndiff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp\nindex f03abb8ae..e83e24606 100644\n--- a/src/libcamera/egl.cpp\n+++ b/src/libcamera/egl.cpp\n@@ -112,6 +112,32 @@ void eGL::flushOutput()\n \tglFlush();\n }\n \n+/**\n+ * \\brief Attach a texture to a frame-buffer-object\n+ *\n+ * \\param[in,out] eglImage EGL image containing texture to attach to FBO\n+ *\n+ * Helper function to make attachment of texture to FBO easy to reuse.\n+ *\n+ * \\return 0 on success, or -ENODEV on failure\n+ */\n+int eGL::attachTextureToFBO(eGLImage &eglImage)\n+{\n+\tint ret = 0;\n+\n+\t// Generate a framebuffer from our texture direct to dma-buf handle buffer\n+\tglBindFramebuffer(GL_FRAMEBUFFER, eglImage.fbo_);\n+\tglFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, eglImage.texture_, 0);\n+\n+\tGLenum err = glCheckFramebufferStatus(GL_FRAMEBUFFER);\n+\tif (err != GL_FRAMEBUFFER_COMPLETE) {\n+\t\tLOG(eGL, Error) << \"glFrameBufferTexture2D error \" << err;\n+\t\tret = -ENODEV;\n+\t}\n+\n+\treturn ret;\n+}\n+\n /**\n * \\brief Create a DMA-BUF backed 2D texture\n * \\param[in,out] eglImage EGL image to associate with the DMA-BUF\n@@ -127,6 +153,7 @@ void eGL::flushOutput()\n int eGL::createDMABufTexture2D(eGLImage &eglImage, int fd, bool output)\n {\n \tEGLint drm_format;\n+\tint ret = 0;\n \n \tASSERT(tid_ == Thread::currentId());\n \n@@ -186,19 +213,10 @@ int eGL::createDMABufTexture2D(eGLImage &eglImage, int fd, bool output)\n \tglTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_S, GL_CLAMP_TO_EDGE);\n \tglTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_T, GL_CLAMP_TO_EDGE);\n \n-\tif (output) {\n-\t\t// Generate a framebuffer from our texture direct to dma-buf handle buffer\n-\t\tglBindFramebuffer(GL_FRAMEBUFFER, eglImage.fbo_);\n-\t\tglFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, eglImage.texture_, 0);\n+\tif (output)\n+\t\tret = attachTextureToFBO(eglImage);\n \n-\t\tGLenum err = glCheckFramebufferStatus(GL_FRAMEBUFFER);\n-\t\tif (err != GL_FRAMEBUFFER_COMPLETE) {\n-\t\t\tLOG(eGL, Error) << \"glFrameBufferTexture2D error \" << err;\n-\t\t\treturn -ENODEV;\n-\t\t}\n-\t}\n-\n-\treturn 0;\n+\treturn ret;\n }\n \n /**\n", "prefixes": [ "02/10" ] }