Patch Detail
Show a patch.
GET /api/patches/26989/?format=api
{ "id": 26989, "url": "https://patchwork.libcamera.org/api/patches/26989/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26989/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260618123844.656396-24-barnabas.pocze@ideasonboard.com>", "date": "2026-06-18T12:38:40", "name": "[RFC,v1,23/27] v4l2: v4l2_camera: Use actually allocated buffer count", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "4dafa0678bb6a441e9293ea5dab6918b848b3483", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26989/mbox/", "series": [ { "id": 6006, "url": "https://patchwork.libcamera.org/api/series/6006/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6006", "date": "2026-06-18T12:38:17", "name": "Misc. changes before request-buffer split", "version": 1, "mbox": "https://patchwork.libcamera.org/series/6006/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26989/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26989/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BBDD4C3330\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 18 Jun 2026 12:39:29 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DBC406571F;\n\tThu, 18 Jun 2026 14:39:28 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2432B656EE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 18 Jun 2026 14:38:53 +0200 (CEST)", "from pb-laptop.local (185.182.214.63.nat.pool.zt.hu\n\t[185.182.214.63])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3D9D22F8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 18 Jun 2026 14:38:18 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Cj3jTjSE\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1781786298;\n\tbh=5s0Z+l6TGSaezBCuWFzaKWnSxqQ7o6cTa1zn+6LVF1s=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=Cj3jTjSE0C7lBxnHQAP1234auoWMRSoKvYV7krdtd/Q5JP3ygOz0yiLTjVhAcfsB4\n\tO2GujWFCNlfqAz6gZWSgS4lmqLkRci2ibir0AMhnR0YW39I7h42qj5hHAv6rjNzmOO\n\t5mtrrP/3Nvo7oijs4ybioCyZqBlHa0FM4uWwB44U=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[RFC PATCH v1 23/27] v4l2: v4l2_camera: Use actually allocated\n\tbuffer count", "Date": "Thu, 18 Jun 2026 14:38:40 +0200", "Message-ID": "<20260618123844.656396-24-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.54.0", "In-Reply-To": "<20260618123844.656396-1-barnabas.pocze@ideasonboard.com>", "References": "<20260618123844.656396-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Make `V4L2Camera::allocBuffers()` simply create as many requests as the\nnumber of buffers allocated instead of taking it as an argument. The two\nshould be the same, so no functional changes intended.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n src/v4l2/v4l2_camera.cpp | 8 +++++---\n src/v4l2/v4l2_camera.h | 2 +-\n src/v4l2/v4l2_camera_proxy.cpp | 11 +++++------\n 3 files changed, 11 insertions(+), 10 deletions(-)", "diff": "diff --git a/src/v4l2/v4l2_camera.cpp b/src/v4l2/v4l2_camera.cpp\nindex 648578c22b..75428b8adc 100644\n--- a/src/v4l2/v4l2_camera.cpp\n+++ b/src/v4l2/v4l2_camera.cpp\n@@ -154,7 +154,7 @@ int V4L2Camera::validateConfiguration(const PixelFormat &pixelFormat,\n \treturn 0;\n }\n \n-int V4L2Camera::allocBuffers(unsigned int count)\n+int V4L2Camera::allocBuffers()\n {\n \tStream *stream = config_->at(0).stream();\n \n@@ -162,7 +162,9 @@ int V4L2Camera::allocBuffers(unsigned int count)\n \tif (ret < 0)\n \t\treturn ret;\n \n-\tfor (unsigned int i = 0; i < count; i++) {\n+\tconst auto &buffers = bufferAllocator_->buffers(stream);\n+\n+\tfor (size_t i = 0; i < buffers.size(); i++) {\n \t\tstd::unique_ptr<Request> request = camera_->createRequest(i);\n \t\tif (!request) {\n \t\t\trequestPool_.clear();\n@@ -171,7 +173,7 @@ int V4L2Camera::allocBuffers(unsigned int count)\n \t\trequestPool_.push_back(std::move(request));\n \t}\n \n-\treturn ret;\n+\treturn buffers.size();\n }\n \n void V4L2Camera::freeBuffers()\ndiff --git a/src/v4l2/v4l2_camera.h b/src/v4l2/v4l2_camera.h\nindex 1528f9aad8..8a58169d89 100644\n--- a/src/v4l2/v4l2_camera.h\n+++ b/src/v4l2/v4l2_camera.h\n@@ -54,7 +54,7 @@ public:\n \tlibcamera::ControlList &controls() { return controls_; }\n \tconst libcamera::ControlInfoMap &controlInfo() { return camera_->controls(); }\n \n-\tint allocBuffers(unsigned int count);\n+\tint allocBuffers();\n \tvoid freeBuffers();\n \tint getBufferFd(unsigned int index);\n \ndiff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\nindex 03cd4810cc..5281f10552 100644\n--- a/src/v4l2/v4l2_camera_proxy.cpp\n+++ b/src/v4l2/v4l2_camera_proxy.cpp\n@@ -543,17 +543,16 @@ int V4L2CameraProxy::vidioc_reqbufs(V4L2CameraFile *file, struct v4l2_requestbuf\n \tif (ret < 0)\n \t\treturn -EINVAL;\n \n-\tsetFmtFromConfig(streamConfig_);\n-\n-\targ->count = streamConfig_.bufferCount;\n-\tbufferCount_ = arg->count;\n-\n-\tret = vcam_->allocBuffers(arg->count);\n+\tret = vcam_->allocBuffers();\n \tif (ret < 0) {\n \t\targ->count = 0;\n \t\treturn ret;\n \t}\n \n+\tbufferCount_ = arg->count = ret;\n+\n+\tsetFmtFromConfig(streamConfig_);\n+\n \tbuffers_.resize(arg->count);\n \tfor (unsigned int i = 0; i < arg->count; i++) {\n \t\tstruct v4l2_buffer buf = {};\n", "prefixes": [ "RFC", "v1", "23/27" ] }