Patch Detail
Show a patch.
GET /api/patches/26972/?format=api
{ "id": 26972, "url": "https://patchwork.libcamera.org/api/patches/26972/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26972/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260618123844.656396-9-barnabas.pocze@ideasonboard.com>", "date": "2026-06-18T12:38:25", "name": "[RFC,v1,08/27] libcamera: pipeline: imx8-isi: pipeFromStream(): Take `ISICameraData`", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "25ac3f60285ef4990870c3ba09c9a3ae128ecb5c", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26972/mbox/", "series": [ { "id": 6006, "url": "https://patchwork.libcamera.org/api/series/6006/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6006", "date": "2026-06-18T12:38:17", "name": "Misc. changes before request-buffer split", "version": 1, "mbox": "https://patchwork.libcamera.org/series/6006/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26972/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26972/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EA6DAC328C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 18 Jun 2026 12:39:12 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D223565702;\n\tThu, 18 Jun 2026 14:39:03 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 05B0A62B2B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 18 Jun 2026 14:38:50 +0200 (CEST)", "from pb-laptop.local (185.182.214.63.nat.pool.zt.hu\n\t[185.182.214.63])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 237F11894\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 18 Jun 2026 14:38:15 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"CmCXqXPh\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1781786295;\n\tbh=sGXTWWmMp6Fi3e+EBGURZjujEJ8RE1acQMhO/Uan8q0=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=CmCXqXPhnSCsOIPLWoo7Wmvqeitw0wHR7+J7+oeiwHKj2hHuqDXPyeiUoGaXcuuYW\n\tEKYux4yXh4VG7u+X2tyA75rJSx/xf4dovHAgzv3nNlwz4ABlEz0IUG4LeSXJ99aaEs\n\t7/9DYitOvRG12lOkMjv4w0u2gYyMiQHRtu/T6Se8=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[RFC PATCH v1 08/27] libcamera: pipeline: imx8-isi:\n\tpipeFromStream(): Take `ISICameraData`", "Date": "Thu, 18 Jun 2026 14:38:25 +0200", "Message-ID": "<20260618123844.656396-9-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.54.0", "In-Reply-To": "<20260618123844.656396-1-barnabas.pocze@ideasonboard.com>", "References": "<20260618123844.656396-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The function actually needs the pipeline handler specific camera data,\nand in most callers it is already available, so accept that as argument.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n src/libcamera/pipeline/imx8-isi/imx8-isi.cpp | 17 +++++++++--------\n 1 file changed, 9 insertions(+), 8 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\nindex c3d2695556..5f15fbdc08 100644\n--- a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\n+++ b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\n@@ -136,7 +136,7 @@ private:\n \t\treturn static_cast<ISICameraData *>(camera->_d());\n \t}\n \n-\tPipe *pipeFromStream(Camera *camera, const Stream *stream);\n+\tPipe *pipeFromStream(ISICameraData *data, const Stream *stream);\n \n \tStreamConfiguration generateYUVConfiguration(Camera *camera,\n \t\t\t\t\t\t const Size &size);\n@@ -865,7 +865,7 @@ int PipelineHandlerISI::configure(Camera *camera, CameraConfiguration *c)\n \t */\n \tdata->enabledStreams_.clear();\n \tfor (const auto &config : *c) {\n-\t\tPipe *pipe = pipeFromStream(camera, config.stream());\n+\t\tPipe *pipe = pipeFromStream(data, config.stream());\n \n \t\t/*\n \t\t * Configure the ISI sink compose rectangle to downscale the\n@@ -915,7 +915,7 @@ int PipelineHandlerISI::exportFrameBuffers(Camera *camera, Stream *stream,\n \t\t\t\t\t std::vector<std::unique_ptr<FrameBuffer>> *buffers)\n {\n \tunsigned int count = stream->configuration().bufferCount;\n-\tPipe *pipe = pipeFromStream(camera, stream);\n+\tPipe *pipe = pipeFromStream(cameraData(camera), stream);\n \n \treturn pipe->capture->exportBuffers(count, buffers);\n }\n@@ -926,7 +926,7 @@ int PipelineHandlerISI::start(Camera *camera,\n \tISICameraData *data = cameraData(camera);\n \n \tfor (const auto &stream : data->enabledStreams_) {\n-\t\tPipe *pipe = pipeFromStream(camera, stream);\n+\t\tPipe *pipe = pipeFromStream(data, stream);\n \t\tconst StreamConfiguration &config = stream->configuration();\n \n \t\tint ret = pipe->capture->importBuffers(config.bufferCount);\n@@ -946,7 +946,7 @@ void PipelineHandlerISI::stopDevice(Camera *camera)\n \tISICameraData *data = cameraData(camera);\n \n \tfor (const auto &stream : data->enabledStreams_) {\n-\t\tPipe *pipe = pipeFromStream(camera, stream);\n+\t\tPipe *pipe = pipeFromStream(data, stream);\n \n \t\tpipe->capture->streamOff();\n \t\tpipe->capture->releaseBuffers();\n@@ -955,8 +955,10 @@ void PipelineHandlerISI::stopDevice(Camera *camera)\n \n int PipelineHandlerISI::queueRequestDevice(Camera *camera, Request *request)\n {\n+\tISICameraData *data = cameraData(camera);\n+\n \tfor (auto &[stream, buffer] : request->buffers()) {\n-\t\tPipe *pipe = pipeFromStream(camera, stream);\n+\t\tPipe *pipe = pipeFromStream(data, stream);\n \n \t\tint ret = pipe->capture->queueBuffer(buffer);\n \t\tif (ret)\n@@ -1110,10 +1112,9 @@ bool PipelineHandlerISI::match(DeviceEnumerator *enumerator)\n \treturn numCameras > 0;\n }\n \n-PipelineHandlerISI::Pipe *PipelineHandlerISI::pipeFromStream(Camera *camera,\n+PipelineHandlerISI::Pipe *PipelineHandlerISI::pipeFromStream(ISICameraData *data,\n \t\t\t\t\t\t\t const Stream *stream)\n {\n-\tISICameraData *data = cameraData(camera);\n \tunsigned int pipeIndex = data->pipeIndex(stream);\n \n \tASSERT(pipeIndex < pipes_.size());\n", "prefixes": [ "RFC", "v1", "08/27" ] }