Patch Detail
Show a patch.
GET /api/patches/26956/?format=api
{ "id": 26956, "url": "https://patchwork.libcamera.org/api/patches/26956/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26956/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260618122245.946138-24-bryan.odonoghue@linaro.org>", "date": "2026-06-18T12:22:36", "name": "[23/30] libcamera: software_isp: egl: Add method lookups for GPU benchmark rountines", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "7c2a7f8880354f4db0a19d3554cb885708b7c17d", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26956/mbox/", "series": [ { "id": 6005, "url": "https://patchwork.libcamera.org/api/series/6005/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6005", "date": "2026-06-18T12:22:13", "name": "RFC/RFT: gpuisp: Multipass with speed optimisations on top", "version": 1, "mbox": "https://patchwork.libcamera.org/series/6005/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26956/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26956/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 26C31C332A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 18 Jun 2026 12:23:36 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4ECA4656EB;\n\tThu, 18 Jun 2026 14:23:35 +0200 (CEST)", "from mail-wm1-x335.google.com (mail-wm1-x335.google.com\n\t[IPv6:2a00:1450:4864:20::335])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E03FB656C0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 18 Jun 2026 14:23:15 +0200 (CEST)", "by mail-wm1-x335.google.com with SMTP id\n\t5b1f17b1804b1-490ae94a89eso6314345e9.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 18 Jun 2026 05:23:15 -0700 (PDT)", "from inspiron14p-linux ([109.76.144.236])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-4922fa3a4easm275198015e9.3.2026.06.18.05.23.14\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 18 Jun 2026 05:23:14 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"vMcS6geV\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1781785395; x=1782390195;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=EZJ9JeeKuy/kalHWvSZKmR3Qkntwk99X5kKkipZh7EM=;\n\tb=vMcS6geVpUJlyoxamVHGb2BkV9olOcQVVnIATAT+3X17WXPDV5LpSokxwBpURpHE8e\n\t04nysCj9YDilp0ohH8XZ/IPwvX1SN2/j280S1I2YjDnpTwChoW03RjM6Afegx0onwTT3\n\tE9nWJABIiQNP1wZSHa/ULkC3rldTTZr912dHNG91WtZB8dWMWH9IWwAKcRghxgdCWcSc\n\tiGOXgyIEwSEkvAi9bO2vtvpsS5V0MOrJTMcdcZSI28sOFIYp39aUdk8xL06iUhvgP2bz\n\tmxmxPErSbMWpElWU8t7X1kgntGV68SexFKb7HMjoR1VKqWn1vG53s9ifrpk9bAZEjjt3\n\tZRuA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20251104; t=1781785395; x=1782390195;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=EZJ9JeeKuy/kalHWvSZKmR3Qkntwk99X5kKkipZh7EM=;\n\tb=l0nb8c6ztake8dwhDiOY8JUT9aWvIMVacguEtSmzopl5ApsRHFLpv3FuBrJRML0dxu\n\tGs3zhhfv4c8vdMXyHunl4KxGqZRYjMGMqp9i8liQEOF1hP/oTgV9c+b4d9EY9Qby44mI\n\tp82JRrJuf9rTUrIuqkRwG/Kf+BPl2rpcAy5Jt3BSe07jxGFsv2xFz3lXhJ8E4lKps1TE\n\tpASTRvrhLlSp5hvfHnL9m1x+qYPV04d7UTIIqaMZ/48qpa1buxuIMB7pYFZ4vXOCT0Bx\n\tfZZHwG6WYeJcbf0Ieadk2oCIYnTQaS1JJ/p4FmF7wAN7xNuEHY8kOkg3rFrN4q46DtC6\n\tV5tw==", "X-Gm-Message-State": "AOJu0YxCRgfWunkiMJQQGgKZy0HPPRYEXfRe+s/nRioEPBDVRShnR2ND\n\teUAYvqIVV5FDYV2ritP9TEzP1WJqVDDc5ShwZo9qtQ0yTJSisG/aDb2u8MfKFVtYR9az6156/Nb\n\tja7fHsJY=", "X-Gm-Gg": "AfdE7cksyQInvTBLFi5caOoEFyQ8uLI4KUZ8hw46ato0ttsWlkUWvlgsOgJVg+oMSnt\n\tgwVJS3yCMQ8tfAQkqtJRhiWDRT5SRuaGQjYA+DYS0+T90QwgmDWTRqrkbXcpapM/p89MJVFFibY\n\t3C4dz0E2SVC18TOJG6x17XkbBZdmdqF9kEQ6eZ+BFbzWfqgIHSweksx2nh/c77LOr1tq1lY4RPB\n\tttLKekNL4dxjJqsQigL8w/V8TGVxCeJ9OyxtYXI/5lHQy/v8YEMqUgu/kWJ6eRqJVY4wstKYKJz\n\tthCgwFMtD29MI0nybJtu8Mf9v9j5uX7KZWbvdxHU8uQSdLsclnW2Ct1dbMzlwKAO+CRhEjmymuh\n\tXxy8ewVjY1ryFLm5Jwo3SNbCrW92EiywoOmP/9yo85OazalbZOEAbsrW6xGdLYbSWQsPzavhkqY\n\ttpW2/DSS9tejoz/ulsP2PQaXbzOFCzE8paHy9S3B8=", "X-Received": "by 2002:a05:600c:1550:b0:48f:e26a:1744 with SMTP id\n\t5b1f17b1804b1-492381eba37mr56177075e9.9.1781785395282; \n\tThu, 18 Jun 2026 05:23:15 -0700 (PDT)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "bryan.odonoghue@linaro.org,\n\tpavel@ucw.cz", "Subject": "[PATCH 23/30] libcamera: software_isp: egl: Add method lookups for\n\tGPU benchmark rountines", "Date": "Thu, 18 Jun 2026 13:22:36 +0100", "Message-ID": "<20260618122245.946138-24-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.54.0", "In-Reply-To": "<20260618122245.946138-1-bryan.odonoghue@linaro.org>", "References": "<20260618122245.946138-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add lookups for:\n\n- glBeingQuery\n- glEndQuery\n- glGetAueryObjectuiv\n- glGetAueryObjectui64v\n\nUsed in the right way these methods will allows us to interrogate exactly\nhow long each GPUISP pass takes.\n\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n include/libcamera/internal/egl.h | 5 +++++\n src/libcamera/egl.cpp | 30 ++++++++++++++++++++++++++++++\n 2 files changed, 35 insertions(+)", "diff": "diff --git a/include/libcamera/internal/egl.h b/include/libcamera/internal/egl.h\nindex d3749d2e7..0e57678e8 100644\n--- a/include/libcamera/internal/egl.h\n+++ b/include/libcamera/internal/egl.h\n@@ -146,5 +146,10 @@ private:\n \tPFNEGLCREATEIMAGEKHRPROC eglCreateImageKHR;\n \tPFNEGLDESTROYIMAGEKHRPROC eglDestroyImageKHR;\n \tPFNGLGETSTRINGPROC glGetString;\n+\tPFNGLBEGINQUERYPROC glBeginQuery;\n+\tPFNGLENDQUERYPROC glEndQuery;\n+\tPFNGLGETQUERYOBJECTUIVPROC glGetQueryObjectuiv;\n+\tPFNGLGETQUERYOBJECTUIVPROC glGetQueryObjectui64v;\n+\tPFNGLGENQUERIESPROC glGenQueries;\n };\n } //namespace libcamera\ndiff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp\nindex 8d135e092..2fc10b800 100644\n--- a/src/libcamera/egl.cpp\n+++ b/src/libcamera/egl.cpp\n@@ -390,6 +390,36 @@ int eGL::initEGLContext()\n \t\tgoto fail;\n \t}\n \n+\tglBeginQuery = (PFNGLBEGINQUERYPROC)eglGetProcAddress(\"glBeginQuery\");\n+\tif (!glBeginQuery) {\n+\t\tLOG(eGL, Error) << \"glBegin not found\";\n+\t\tgoto fail;\n+\t}\n+\n+\tglEndQuery = (PFNGLENDQUERYPROC)eglGetProcAddress(\"glEndQuery\");\n+\tif (!glEndQuery) {\n+\t\tLOG(eGL, Error) << \"glEndQuery not found\";\n+\t\tgoto fail;\n+\t}\n+\n+\tglGetQueryObjectuiv = (PFNGLGETQUERYOBJECTUIVPROC)eglGetProcAddress(\"glGetQueryObjectuiv\");\n+\tif (!glGetQueryObjectuiv) {\n+\t\tLOG(eGL, Error) << \"glGetQueryObjectuiv not found\";\n+\t\tgoto fail;\n+\t}\n+\n+\tglGetQueryObjectui64v = (PFNGLGETQUERYOBJECTUIVPROC)eglGetProcAddress(\"glGetQueryObjectui64v\");\n+\tif (!glGetQueryObjectuiv) {\n+\t\tLOG(eGL, Error) << \"glGetQueryObjectui64v not found\";\n+\t\tgoto fail;\n+\t}\n+\n+\tglGenQueries = (PFNGLGENQUERIESPROC)eglGetProcAddress(\"glGenQueries\");\n+\tif (!glGetQueryObjectuiv) {\n+\t\tLOG(eGL, Error) << \"glGenQueries not found\";\n+\t\tgoto fail;\n+\t}\n+\n \tif (eglChooseConfig(display_, configAttribs, &config, 1, &numConfigs) != EGL_TRUE) {\n \t\tLOG(eGL, Error) << \"eglChooseConfig fail\";\n \t\tgoto fail;\n", "prefixes": [ "23/30" ] }