Patch Detail
Show a patch.
GET /api/patches/26953/?format=api
{ "id": 26953, "url": "https://patchwork.libcamera.org/api/patches/26953/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26953/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260618122245.946138-21-bryan.odonoghue@linaro.org>", "date": "2026-06-18T12:22:33", "name": "[20/30] libcamera: software_isp: gpu: Include GpuIspShaderPassBlcNormalise in init sequence", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "b35bb7c55d988aa8914e46f1d7cf35352af3bbd4", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26953/mbox/", "series": [ { "id": 6005, "url": "https://patchwork.libcamera.org/api/series/6005/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6005", "date": "2026-06-18T12:22:13", "name": "RFC/RFT: gpuisp: Multipass with speed optimisations on top", "version": 1, "mbox": "https://patchwork.libcamera.org/series/6005/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26953/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26953/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6E12BC331D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 18 Jun 2026 12:23:33 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B6974656B8;\n\tThu, 18 Jun 2026 14:23:32 +0200 (CEST)", "from mail-wm1-x335.google.com (mail-wm1-x335.google.com\n\t[IPv6:2a00:1450:4864:20::335])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D3FFC656B4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 18 Jun 2026 14:23:13 +0200 (CEST)", "by mail-wm1-x335.google.com with SMTP id\n\t5b1f17b1804b1-490acbb0f89so5107845e9.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 18 Jun 2026 05:23:13 -0700 (PDT)", "from inspiron14p-linux ([109.76.144.236])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-4922fa3a4easm275198015e9.3.2026.06.18.05.23.12\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 18 Jun 2026 05:23:12 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"kP46Al7P\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1781785393; x=1782390193;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=otunOUI1agRrvtm6rTUQ9gqlRxTZmvPpP1vnDqvDaf4=;\n\tb=kP46Al7PlAPXb0dCxWQ+5i0dAJih47h6tCc8OPcIoDn8PMcaDZSdDiFQgiTLVg0BU2\n\tfau3THDQjOOQYgoRFR9DOoawZYiSZxMouNKPpOvklwZKeNVAnzZFob8pH0wVjUuinV1V\n\tQpUjoUXxJRg4yhccYUPm8Rsc3t0q6BOrzAtFIawDk3TfEQQuNnHBW3YqgPV4190FqtC4\n\t8PoqBt+aNIKLMUsbKS2p0P3+JDJt1Eim5w8LnuqD4NUTsF7TMKt2R476OPk0e4Z+b5w6\n\tZ4nPjxKb7Otkb5dhBO4fP2YHhABSt0vQNKL/zBokJ/G86ip+sFapHXht6s4JfWA1EJNr\n\tL/Ng==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20251104; t=1781785393; x=1782390193;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=otunOUI1agRrvtm6rTUQ9gqlRxTZmvPpP1vnDqvDaf4=;\n\tb=o30GpiItBWUh4g//tPLCCGd4qo+m/Sb9oWE7BxKvixrEEciDx2f0th4GRKgDoq11GB\n\thNGaHRRXSCzVoSN69S8uVeWHIDznMr5boJWunvP8k4DmUIGMjqBi4yQaN5xw3gO097IH\n\teMtDK7Jx9YCIXExP0Dv8YuGFnrjHnYOLG55z7f7l5qkWnLM45aRLfUUfNAR8SWf/2JCt\n\txvjsvmheO0R8nxBbAKfF60q1d2Oj5fM/lQWezf1lrRday/rPEXgQCAJ9sjk4Tc24RpJ1\n\tQfKXbsuIP9+Jrme7CHdLAJFTCxlsAVj0XRhNLBqf9nsYSoOX0hSCbGWA8vJiribGRsyQ\n\tJAaA==", "X-Gm-Message-State": "AOJu0Yw0aFpnvZLbQ3d94p3cwtRLsF0lKSURJZI3sO2wk3dY/d7wJ0EH\n\tkOq6eN436HWh7AiG9qlbSZAlPZMPSlfo+mD4ps2QrFZ90SbDRvHTv10tb4hh2LR0y6T+YyJI1pF\n\tRmbmzrag=", "X-Gm-Gg": "AfdE7cknAJ7ajO3KqBJXaWHNVLK7npSeZYF9PVfZg1AbL2woJVPJ76DEEnx1Q9ex/3K\n\txOe2SODVLJxx949qxebrBlFn0G/2fLHR8COMxjy/DA17hkNQrDh0C0xoIxD7j/nDK4JfQv0Y9XP\n\t2O37gl69QzkNKc/Zf31pY9QMZVBUATBYpJttX5Ib5Xu9pQkp7TzOReF2xa6NhjKuzJTYAnrOo6h\n\t/nGy/MZ04u3DzfKQZ2k/W3i3HfgB6/oq8pIE4idptMdiTFUwedlC+8g3An2dHcIiLwYZFQ1m0F+\n\t89ECCXbryEJlw4UxOUwvN78aVudre8mtlCmCffHmreGdh/QrmRFtdvHPDfo3cnQwkAfNg2ag5HE\n\tmoFn1ONurTR9jLeSCFoLlR0D0haXnZ0TimaT/4u38dWpzelGEjyKVKt6d34gTzMLEbZox6L3G7u\n\tFAy809UE4qis5nX9S/W+6YTWdGOM2O", "X-Received": "by 2002:a05:600c:45c5:b0:490:ea88:9d4c with SMTP id\n\t5b1f17b1804b1-4923822b3a3mr54200405e9.32.1781785392988; \n\tThu, 18 Jun 2026 05:23:12 -0700 (PDT)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "bryan.odonoghue@linaro.org,\n\tpavel@ucw.cz", "Subject": "[PATCH 20/30] libcamera: software_isp: gpu: Include\n\tGpuIspShaderPassBlcNormalise in init sequence", "Date": "Thu, 18 Jun 2026 13:22:33 +0100", "Message-ID": "<20260618122245.946138-21-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.54.0", "In-Reply-To": "<20260618122245.946138-1-bryan.odonoghue@linaro.org>", "References": "<20260618122245.946138-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/software_isp/software_isp_pipeline_gpu.cpp | 6 +++++-\n src/libcamera/software_isp/software_isp_pipeline_gpu.h | 2 ++\n 2 files changed, 7 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/software_isp/software_isp_pipeline_gpu.cpp b/src/libcamera/software_isp/software_isp_pipeline_gpu.cpp\nindex 18a8ae17a..3c9b48154 100644\n--- a/src/libcamera/software_isp/software_isp_pipeline_gpu.cpp\n+++ b/src/libcamera/software_isp/software_isp_pipeline_gpu.cpp\n@@ -41,7 +41,7 @@ namespace libcamera {\n * \\param[in] cm The camera manager\n */\n SoftwareIspPipelineGpu::SoftwareIspPipelineGpu(std::unique_ptr<SwStatsCpu> stats, const CameraManager &cm)\n-\t: SoftwareIspPipeline(cm), stats_(std::move(stats)), gpuIspShaderPassDemosiac_(egl_)\n+\t: SoftwareIspPipeline(cm), stats_(std::move(stats)), gpuIspShaderPassBlcNormalise_(egl_), gpuIspShaderPassDemosiac_(egl_)\n {\n }\n \n@@ -113,6 +113,10 @@ int SoftwareIspPipelineGpu::initBayerShaders(PixelFormat inputFormat, PixelForma\n {\n \tint ret;\n \n+\tret = gpuIspShaderPassBlcNormalise_.initShaders(inputFormat, outputFormat);\n+\tif (ret)\n+\t\treturn ret;\n+\n \tret = gpuIspShaderPassDemosiac_.initShaders(inputFormat, outputFormat);\n \n \treturn ret;\ndiff --git a/src/libcamera/software_isp/software_isp_pipeline_gpu.h b/src/libcamera/software_isp/software_isp_pipeline_gpu.h\nindex fcd622492..8a922f658 100644\n--- a/src/libcamera/software_isp/software_isp_pipeline_gpu.h\n+++ b/src/libcamera/software_isp/software_isp_pipeline_gpu.h\n@@ -24,6 +24,7 @@\n #include \"libcamera/internal/software_isp/swstats_cpu.h\"\n \n #include \"software_isp_pipeline.h\"\n+#include \"gpu_pipeline_shader_pass_blc_normalise.h\"\n #include \"gpu_pipeline_shader_pass_demosiac.h\"\n \n namespace libcamera {\n@@ -73,6 +74,7 @@ private:\n \tuint32_t width_;\n \tuint32_t height_;\n \n+\tGpuIspShaderPassBlcNormalise gpuIspShaderPassBlcNormalise_;\n \tGpuIspShaderPassDemosiac gpuIspShaderPassDemosiac_;\n };\n \n", "prefixes": [ "20/30" ] }