Patch Detail
Show a patch.
GET /api/patches/26948/?format=api
{ "id": 26948, "url": "https://patchwork.libcamera.org/api/patches/26948/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26948/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260618122245.946138-16-bryan.odonoghue@linaro.org>", "date": "2026-06-18T12:22:28", "name": "[15/30] libcamera: software_isp: egl: Extend eGL::createTexture2D to understand floats", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "e933e833e0e2a1c97715ee81ffa68bf6e36e3f8b", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26948/mbox/", "series": [ { "id": 6005, "url": "https://patchwork.libcamera.org/api/series/6005/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6005", "date": "2026-06-18T12:22:13", "name": "RFC/RFT: gpuisp: Multipass with speed optimisations on top", "version": 1, "mbox": "https://patchwork.libcamera.org/series/6005/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26948/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26948/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 89704C330F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 18 Jun 2026 12:23:27 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DB047656C7;\n\tThu, 18 Jun 2026 14:23:26 +0200 (CEST)", "from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com\n\t[IPv6:2a00:1450:4864:20::32a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BE48562C7C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 18 Jun 2026 14:23:09 +0200 (CEST)", "by mail-wm1-x32a.google.com with SMTP id\n\t5b1f17b1804b1-490ae94a89eso6313405e9.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 18 Jun 2026 05:23:09 -0700 (PDT)", "from inspiron14p-linux ([109.76.144.236])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-4922fa3a4easm275198015e9.3.2026.06.18.05.23.07\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 18 Jun 2026 05:23:08 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"ahpWDs48\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1781785389; x=1782390189;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=Q1uKl0CNvdgfWO0Mn4aUOTwFartpNuJZP4m4+2UlupY=;\n\tb=ahpWDs489/0GvtY4G99mdVZPs6nesEQFQi5LVRL8NuULOU7mXtoj1kNvm6n+aAeuZJ\n\tc0JqrHZ/G3gdISLDxn57t/J/XnBCKxSGghFhfYo3M/7+gbvxPh+1tv30Igp/IsKzOQGH\n\tDVhatu3KLhivAvyb5Baho8OmWkWwNA0o7F+MQhLJK7FRkKHDacG0Brn3bDoVEEgUNOWB\n\tfp5t4EDNrExSHR3w83H8MV6K+julCQmtuFLRGR424c4aEEgBDZqpO4QHUvtzmmOjaZp5\n\tGjQDgd1GDPQEUve+dshwr2kj8HvndbGEHrlxmjfWqlRa+dPnMYxUOQ9464g1HgdSrrYy\n\tZpDg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20251104; t=1781785389; x=1782390189;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=Q1uKl0CNvdgfWO0Mn4aUOTwFartpNuJZP4m4+2UlupY=;\n\tb=eMcrleTd9oTM4G0XFucIXQZeU6oWva8Sc+/ncwAMNWhGZey44FkLP8R4+JGI+6peIH\n\tve4fHy8wmIUH25W8gw6n6ckRQ4e9qrBI9HRNHheoj5wJTtZJQGgnggGEnjKx+B8HPKnk\n\tfBpqJ5SdaxtoJ3NAnYbw8j91k7hgZUSgMGS2mgos6J3P6SArDNDFnwjutAQjYaCQGDRe\n\tQf2eXZq7szcNb5HsBtjQ0g0ao18wjOwAPN0VdpoN5BSFhChF3eydCX6bkgA425wgRUFp\n\t8EI5qhYoUa5XdmwMJThOPUYO7R0TU5tIQCl3dAA/qH9pgYcOPXLqCsKmDR2th7z34vkD\n\tuHWA==", "X-Gm-Message-State": "AOJu0YxxOG4k/H2zHcWHgaze9kyR1zRhwYPdmjiHVau5iDOwlD7Krym9\n\tBL0giYe9F97ovFoF0Cu66y2KkfiDQpfU/5+Wozfold7Jek3T0fNv0hncWSn6G6Acnb+00qoVuVI\n\tTN4vzwJE=", "X-Gm-Gg": "AfdE7cllGKVf75eQpsl40gNTIlJv+QbGM2Pscq49TMzftERFyvKKeGar1iyZu0t9OxM\n\tZk3H1VnzrGB5jmTspuLGsdPBdyZickwtNdhRf1ePTiHN2rTKnB8C9T0gyB0XnOJ1B5N/m+daHgO\n\tjcw6hAiCcvj0EbjBci7qYr6I41QzMET9IT9gOZ3otf9RhX7GSskClY88nFoNRAstFa/JDoB7s6v\n\tcugHc+tRLuKrzg2PKJyoIH+55qnK4PC2gGmqo8ZTfnL2Labr9NHwa1/r06I1udbBVoixDG7jzs7\n\tLyqkbQh454KkOYBPcpLAgMsVJR1rRP7xOnQzIOyj6MlMbtZgLDuNJFrXMM4YNZgEvBBGWwekYd+\n\td27fnKICU2Xx4YJOEFxSZaPaMtJMwTfrAQgK8auyoN8HN+0Ks/ybnbYZtLTM+ORuDJ558hdz9FG\n\tZjLT/9hSeP1Kd37qgvAOc7PK25QgaX", "X-Received": "by 2002:a05:600c:19d3:b0:490:ba0a:1178 with SMTP id\n\t5b1f17b1804b1-49238226533mr53189805e9.28.1781785389270; \n\tThu, 18 Jun 2026 05:23:09 -0700 (PDT)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "bryan.odonoghue@linaro.org,\n\tpavel@ucw.cz", "Subject": "[PATCH 15/30] libcamera: software_isp: egl: Extend\n\teGL::createTexture2D to understand floats", "Date": "Thu, 18 Jun 2026 13:22:28 +0100", "Message-ID": "<20260618122245.946138-16-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.54.0", "In-Reply-To": "<20260618122245.946138-1-bryan.odonoghue@linaro.org>", "References": "<20260618122245.946138-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/egl.cpp | 18 +++++++++++++++++-\n 1 file changed, 17 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp\nindex 4da335a53..a5e59c09c 100644\n--- a/src/libcamera/egl.cpp\n+++ b/src/libcamera/egl.cpp\n@@ -264,13 +264,29 @@ int eGL::createOutputDMABufTexture2D(eGLImage &eglImage, int fd)\n */\n void eGL::createTexture2D(eGLImage &eglImage, void *data)\n {\n+\tGLenum format;\n+\tGLenum type = GL_UNSIGNED_BYTE;\n+\n \tASSERT(tid_ == Thread::currentId());\n \n \tglActiveTexture(eglImage.texture_unit_);\n \tglBindTexture(GL_TEXTURE_2D, eglImage.texture_);\n \n+\tswitch (eglImage.format_) {\n+\tcase GL_R16F:\n+\t\tformat = GL_RED;\n+\t\ttype = GL_HALF_FLOAT;\n+\t\tbreak;\n+\tcase GL_RG8:\n+\t\tformat = GL_RG;\n+\t\tbreak;\n+\tcase GL_LUMINANCE:\n+\t\tformat = GL_LUMINANCE;\n+\t\tbreak;\n+\t}\n+\n \t// Generate texture, bind, associate image to texture, configure, unbind\n-\tglTexImage2D(GL_TEXTURE_2D, 0, eglImage.format_, eglImage.width_, eglImage.height_, 0, eglImage.format_, GL_UNSIGNED_BYTE, data);\n+\tglTexImage2D(GL_TEXTURE_2D, 0, eglImage.format_, eglImage.width_, eglImage.height_, 0, format, type, data);\n \n \t// Nearest filtering\n \tglTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_NEAREST);\n", "prefixes": [ "15/30" ] }