Patch Detail
Show a patch.
GET /api/patches/2680/?format=api
{ "id": 2680, "url": "https://patchwork.libcamera.org/api/patches/2680/?format=api", "web_url": "https://patchwork.libcamera.org/patch/2680/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200118200015.16531-7-nicolas@ndufresne.ca>", "date": "2020-01-18T20:00:15", "name": "[libcamera-devel,v4,6/6] checkstyle: Add a pre-commit hook script", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "7ee31af5a283bf6af8cae7e6f5070f34656d8d9b", "submitter": { "id": 30, "url": "https://patchwork.libcamera.org/api/people/30/?format=api", "name": "Nicolas Dufresne", "email": "nicolas@ndufresne.ca" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/2680/mbox/", "series": [ { "id": 636, "url": "https://patchwork.libcamera.org/api/series/636/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=636", "date": "2020-01-18T20:00:09", "name": "Add the ability to do pre-commit style check", "version": 4, "mbox": "https://patchwork.libcamera.org/series/636/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/2680/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/2680/checks/", "tags": {}, "headers": { "Return-Path": "<nicolas@ndufresne.ca>", "Received": [ "from bhuna.collabora.co.uk (bhuna.collabora.co.uk\n\t[IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E752460455\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 18 Jan 2020 21:02:56 +0100 (CET)", "from nicolas-tpx395.localdomain (unknown\n\t[IPv6:2002:c0de:c115:0:66fc:8b:2a38:8313])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits))\n\t(No client certificate requested) (Authenticated sender: nicolas)\n\tby bhuna.collabora.co.uk (Postfix) with ESMTPSA id 9B0052911C1;\n\tSat, 18 Jan 2020 20:02:54 +0000 (GMT)" ], "From": "Nicolas Dufresne <nicolas@ndufresne.ca>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Nicolas Dufresne <nicolas.dufresne@collabora.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>", "Date": "Sat, 18 Jan 2020 15:00:15 -0500", "Message-Id": "<20200118200015.16531-7-nicolas@ndufresne.ca>", "X-Mailer": "git-send-email 2.24.1", "In-Reply-To": "<20200118200015.16531-1-nicolas@ndufresne.ca>", "References": "<20200118200015.16531-1-nicolas@ndufresne.ca>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v4 6/6] checkstyle: Add a pre-commit hook\n\tscript", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Sat, 18 Jan 2020 20:02:57 -0000" }, "content": "From: Nicolas Dufresne <nicolas.dufresne@collabora.com>\n\nThis adds support for pre-commit hook workflow. In pre-commit hook we\ncheck the style on the changes currently staged or the combination\nof the index and the last commit if \"git commit --amend\" is being used.\n\nSigned-off-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n utils/hooks/pre-commit | 18 ++++++++++++++++++\n 1 file changed, 18 insertions(+)\n create mode 100755 utils/hooks/pre-commit", "diff": "diff --git a/utils/hooks/pre-commit b/utils/hooks/pre-commit\nnew file mode 100755\nindex 0000000..47fcbc8\n--- /dev/null\n+++ b/utils/hooks/pre-commit\n@@ -0,0 +1,18 @@\n+#!/bin/sh\n+\n+# Execute the checkstyle script before committing any code. This will fail the\n+# commit in case of style issues, ensuring that the developer will notice them.\n+# The pre-commit hook can be bypassed with git commit -n to ignore selective\n+# changes.\n+#\n+# To utilise this hook, install this file with:\n+# cp utils/hooks/pre-commit .git/hooks/pre-commit\n+\n+if ps -ocommand= -p $PPID | grep -- \"--amend\"\n+then\n+\targs=\"--amend\"\n+else\n+\targs=\"--staged\"\n+fi\n+\n+./utils/checkstyle.py $args\n", "prefixes": [ "libcamera-devel", "v4", "6/6" ] }