Patch Detail
Show a patch.
GET /api/patches/26789/?format=api
{ "id": 26789, "url": "https://patchwork.libcamera.org/api/patches/26789/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26789/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260521141006.101016-3-robert.mader@collabora.com>", "date": "2026-05-21T14:10:05", "name": "[v1,2/3] egl: Call glFlush before glFinish", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "42421bc1b919849e4d72d0c0d45aee9396814695", "submitter": { "id": 140, "url": "https://patchwork.libcamera.org/api/people/140/?format=api", "name": "Robert Mader", "email": "robert.mader@collabora.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26789/mbox/", "series": [ { "id": 5959, "url": "https://patchwork.libcamera.org/api/series/5959/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5959", "date": "2026-05-21T14:10:04", "name": "debayer_egl: Sync output buffers after processing stats", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5959/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26789/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26789/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4C24FC32F4\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 21 May 2026 14:10:39 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E249363024;\n\tThu, 21 May 2026 16:10:34 +0200 (CEST)", "from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com\n\t[136.143.188.112])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B0EA162FE1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 21 May 2026 16:10:31 +0200 (CEST)", "by mx.zohomail.com with SMTPS id 1779372626205474.31481325044206; \n\tThu, 21 May 2026 07:10:26 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=collabora.com\n\theader.i=robert.mader@collabora.com header.b=\"HRYz/rUU\"; \n\tdkim-atps=neutral", "ARC-Seal": "i=1; a=rsa-sha256; t=1779372627; cv=none; \n\td=zohomail.com; s=zohoarc; \n\tb=NTkx9+6ww13vKzMG5b/MTeYp1hL6MVuI7OWw75BMlzhZLTnsZ8WTlBH2/hARZV13q37+TfUxjPUaOlAZvB7pE1MhIuudOJexZW5g3lQK+RpAkL/7YO3lDPiyHUFwIW3DCBO/VW8hS+Vn5oGJXdeze0Dkwm8sfk8iDsMND0dkNHA=", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; \n\ts=zohoarc; t=1779372627;\n\th=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To;\n\tbh=TKgp4eFBCV13RWpqr4iN2JjjKqhWVNOT2jg98eLTw6c=; \n\tb=GKDI4L/QPEPklh7S/dTk6Vm7MbLTzfppL7kWIsKpnN/VZVXd0yaB/W0BqEoKqj/aSFfhwJRJZFrpc+gS2yOYLUBVn+23di28FOAAzAKU/A/93HUlnzPGAORJby5CenLQmNWxbxJBM8p3rwTe8pTAjbwc8rJOweLXAll7b6+CNLM=", "ARC-Authentication-Results": "i=1; mx.zohomail.com;\n\tdkim=pass header.i=collabora.com;\n\tspf=pass smtp.mailfrom=robert.mader@collabora.com;\n\tdmarc=pass header.from=<robert.mader@collabora.com>", "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1779372627;\n\ts=zohomail; d=collabora.com; i=robert.mader@collabora.com;\n\th=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To;\n\tbh=TKgp4eFBCV13RWpqr4iN2JjjKqhWVNOT2jg98eLTw6c=;\n\tb=HRYz/rUUPssLU8FBoGAueK7tbKsNwvb2yGVoHhS+CCWcImPgXvhfa/zUyiaxGM99\n\tUJi6wj1uj/fykX7GBGmzwFdwESex6tWMi1Osm7U48H68bhX7YDCMX/eW9jWNyqhWLw4\n\trs3LUskYDAkZybapae+D4k74vIfhfxLuhP8rYoQI=", "From": "Robert Mader <robert.mader@collabora.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Robert Mader <robert.mader@collabora.com>", "Subject": "[PATCH v1 2/3] egl: Call glFlush before glFinish", "Date": "Thu, 21 May 2026 16:10:05 +0200", "Message-ID": "<20260521141006.101016-3-robert.mader@collabora.com>", "X-Mailer": "git-send-email 2.54.0", "In-Reply-To": "<20260521141006.101016-1-robert.mader@collabora.com>", "References": "<20260521141006.101016-1-robert.mader@collabora.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Apparently it is not guaranteed that drivers will do so implicitly,\nwhich may or may not be a driver bug. The impact on performance has been\nobserved to be significant and it's easy enough, so let's do it\nexplicitly.\n\nBelow are some benchmark results. All where done using postmarketOS edge\nwith updates from 21th May 2026 (Mesa 26.1.1). The mentioned pipelines\nwhere run five times each, with the mean value included here, which should\nbe quite representive as the variance was rather small. All devices\nwhere using the powersave governor.\n\ncam -c /base/soc@0/cci@ac4a000/i2c-bus@0/camera@1a -s width=1920,height=1080 --capture=60\nBefore: 47986 us/frame\nAfter: 33596 us/frame !\n\ncam -c /base/soc@0/cci@ac4a000/i2c-bus@1/camera@1a -s width=1920,height=1080 --capture=60\nBefore: 30294 us/frame\nAfter: 14922 us/frame !\n\ncam -c /base/soc@0/cci@ac4b000/i2c-bus@1/camera@10 -s width=1920,height=1080 --capture=60\nBefore: 27373 us/frame\nAfter: 26106 us/frame\n\ncam -c /base/soc@0/cci@ac4a000/i2c-bus@1/camera@29 -s width=1920,height=1080 --capture=60\nBefore: 16339 us/frame\nAfter: 15897 us/frame\n\ncam -c /base/soc@0/cci@ac4a000/i2c-bus@1/camera@10 -s width=1920,height=1080 --capture=60\nBefore: 26206 us/frame\nAfter: 25721 us/frame\n\ncam -c /base/soc@0/cci@ac4a000/i2c-bus@0/camera@10 -s width=1920,height=1080 --capture=60\nBefore: 43723 us/frame\nAfter: 34124 us/frame !\n\ncam -c /base/soc@0/cci@ac4a000/i2c-bus@0/camera@1a -s width=1920,height=1080 --capture=60\nBefore: 23597 us/frame\nAfter: 23707 us/frame\n\ncam -c /base/soc@0/bus@30800000/i2c@30a40000/camera@20 -s width=1280,height=720 --capture=60\nBefore: 91200 us/frame\nAfter: 91649 us/frame\n\ncam -c /base/soc@0/bus@30800000/i2c@30a50000/camera@2d -s width=1280,height=720 --capture=60\nBefore: 76577 us/frame\nAfter: 76956 us/frame\n\ncam -c /base/i2c-csi/front-camera@3c -s width=1280,height=720 --capture=60\nBefore: 188122 us/frame\nAfter: 188500 us/frame\n\ncam -c /base/i2c-csi/rear-camera@4c -s width=1280,height=720 --capture=60\nBefore: 193712 us/frame\nAfter: 190222 us/frame\n\nSigned-off-by: Robert Mader <robert.mader@collabora.com>\n---\n src/libcamera/egl.cpp | 1 +\n 1 file changed, 1 insertion(+)", "diff": "diff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp\nindex 357918711..d9bc4f555 100644\n--- a/src/libcamera/egl.cpp\n+++ b/src/libcamera/egl.cpp\n@@ -94,6 +94,7 @@ void eGL::syncOutput()\n {\n \tASSERT(tid_ == Thread::currentId());\n \n+\tglFlush();\n \tglFinish();\n }\n \n", "prefixes": [ "v1", "2/3" ] }