Patch Detail
Show a patch.
GET /api/patches/26785/?format=api
{ "id": 26785, "url": "https://patchwork.libcamera.org/api/patches/26785/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26785/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260519193907.86812-6-robert.mader@collabora.com>", "date": "2026-05-19T19:39:07", "name": "[v3,5/5] debayer_egl: Sync output buffer after processing stats", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "f916d79be3f4921e7ca82990458352e0e9122acb", "submitter": { "id": 140, "url": "https://patchwork.libcamera.org/api/people/140/?format=api", "name": "Robert Mader", "email": "robert.mader@collabora.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26785/mbox/", "series": [ { "id": 5957, "url": "https://patchwork.libcamera.org/api/series/5957/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5957", "date": "2026-05-19T19:39:02", "name": "software_isp: Implement DMABuf import for input buffers", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5957/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26785/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26785/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 23889C3301\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 19 May 2026 19:39:48 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 85EE663042;\n\tTue, 19 May 2026 21:39:47 +0200 (CEST)", "from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com\n\t[136.143.188.112])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7E53C63039\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 19 May 2026 21:39:44 +0200 (CEST)", "by mx.zohomail.com with SMTPS id 1779219579147677.4954399650786;\n\tTue, 19 May 2026 12:39:39 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=collabora.com\n\theader.i=robert.mader@collabora.com header.b=\"aAZzoyjN\"; \n\tdkim-atps=neutral", "ARC-Seal": "i=1; a=rsa-sha256; t=1779219580; cv=none; \n\td=zohomail.com; s=zohoarc; \n\tb=lQw0oBvo1Fynu5UUsuz1cSSxjy+SCnQ1Qi7hQHDvqqiDiTSzFVlwu5xIU5zA8lX4umEbepaWZ+pvLsuaqR6VkTlNtWEuI4X9uW4fXfY4YWU1Y3HGB7hMRr+sqA+XoTMRepJF8M7o7hSP0JQnT3FxxTFZV5ZJhXJigl30hsn1edI=", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; \n\ts=zohoarc; t=1779219580;\n\th=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To;\n\tbh=9IpGrraSJ7sUGI34EHGr3n24fwxPRGwvRVz0XyOZyZI=; \n\tb=EyccH1Yb2UH2oikNNCzxeXWN4GJ4COBeOEVcW4oB+Yc1zGEQF7HMh6ZSC0wS8Tfp1jleE7x6TvkTSv9HqZDq1Z12Hpd6srqk6kac1k+q74s0493VmqS9CgNQ/jtxVLNVqLVBXKnpRijmTxetxad837KWE+r995SoobXpMpZF9l4=", "ARC-Authentication-Results": "i=1; mx.zohomail.com;\n\tdkim=pass header.i=collabora.com;\n\tspf=pass smtp.mailfrom=robert.mader@collabora.com;\n\tdmarc=pass header.from=<robert.mader@collabora.com>", "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1779219580;\n\ts=zohomail; d=collabora.com; i=robert.mader@collabora.com;\n\th=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To;\n\tbh=9IpGrraSJ7sUGI34EHGr3n24fwxPRGwvRVz0XyOZyZI=;\n\tb=aAZzoyjN+kFGhQO0gZLufXrg+0JLfjLzRvk+2sPybukXSIuiBcojW+eJI+L0qgFR\n\teEfLkroynlVQyx2vBseB2nhBZGYl9UHtgTT42xoFP4y5JHw78QmiahrpQmGLDPRux2y\n\t7RFDy4PCCSrhHzc7Zi0j31n8O4nPBk+sMuH3jl5o=", "From": "Robert Mader <robert.mader@collabora.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Robert Mader <robert.mader@collabora.com>, =?utf-8?q?Barnab=C3=A1s_P?=\n\t=?utf-8?b?xZFjemU=?= <barnabas.pocze@ideasonboard.com>", "Subject": "[PATCH v3 5/5] debayer_egl: Sync output buffer after processing\n\tstats", "Date": "Tue, 19 May 2026 21:39:07 +0200", "Message-ID": "<20260519193907.86812-6-robert.mader@collabora.com>", "X-Mailer": "git-send-email 2.54.0", "In-Reply-To": "<20260519193907.86812-1-robert.mader@collabora.com>", "References": "<20260519193907.86812-1-robert.mader@collabora.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Instead of waiting for the GPU to finish the output buffer *before*\ncomputing stats, do so afterwards. This allows work to happen in\nparallel on the GPU and CPU, potentially improving throughput and\nreducing latency.\n\nThis, however, requires us to include stats computation into the\ndebayer benchmark data.\n\nSigned-off-by: Robert Mader <robert.mader@collabora.com>\nReviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n src/libcamera/software_isp/debayer_egl.cpp | 7 +++----\n 1 file changed, 3 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/libcamera/software_isp/debayer_egl.cpp b/src/libcamera/software_isp/debayer_egl.cpp\nindex 750895d10..41176973b 100644\n--- a/src/libcamera/software_isp/debayer_egl.cpp\n+++ b/src/libcamera/software_isp/debayer_egl.cpp\n@@ -536,8 +536,6 @@ int DebayerEGL::debayerGPU(FrameBuffer *input, std::optional<DmaSyncer> *inputBu\n \tif (err != GL_NO_ERROR) {\n \t\tLOG(eGL, Error) << \"Drawing scene fail \" << err;\n \t\treturn -ENODEV;\n-\t} else {\n-\t\tegl_.syncOutput();\n \t}\n \n \treturn 0;\n@@ -560,8 +558,6 @@ void DebayerEGL::process(uint32_t frame, FrameBuffer *input, FrameBuffer *output\n \t\tgoto error;\n \t}\n \n-\tbench_.finishFrame();\n-\n \tmetadata.planes()[0].bytesused = output->planes()[0].length;\n \n \t/* Calculate stats for the whole frame */\n@@ -570,6 +566,9 @@ void DebayerEGL::process(uint32_t frame, FrameBuffer *input, FrameBuffer *output\n \tstats_->processFrame(frame, 0, input);\n \tinputBufferDmaSyncer.reset();\n \n+\tegl_.syncOutput();\n+\tbench_.finishFrame();\n+\n \toutputBufferReady.emit(output);\n \tinputBufferReady.emit(input);\n \n", "prefixes": [ "v3", "5/5" ] }