Patch Detail
Show a patch.
GET /api/patches/26777/?format=api
{ "id": 26777, "url": "https://patchwork.libcamera.org/api/patches/26777/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26777/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260519030020.408693-5-hpa@redhat.com>", "date": "2026-05-19T03:00:20", "name": "[v3,4/4] meson: Add ipa-signature-algo option", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "12bb3774437505f566f8d5e9893ebdadd5f0740f", "submitter": { "id": 105, "url": "https://patchwork.libcamera.org/api/people/105/?format=api", "name": "Kate Hsuan", "email": "hpa@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26777/mbox/", "series": [ { "id": 5954, "url": "https://patchwork.libcamera.org/api/series/5954/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5954", "date": "2026-05-19T03:00:16", "name": "Implement ML-DSA-65 for Post-Quantum Cryptographic compliance", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5954/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26777/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26777/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D8D28BDCBC\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 19 May 2026 03:01:10 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 874E76302F;\n\tTue, 19 May 2026 05:01:10 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A202462FEC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 19 May 2026 05:01:08 +0200 (CEST)", "from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-392-XYfSSGVINhW7CtIjhmLhCg-1;\n\tMon, 18 May 2026 23:01:05 -0400", "from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.12])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id CBE34180056E; Tue, 19 May 2026 03:01:04 +0000 (UTC)", "from fedora.redhat.com (unknown [10.67.32.77])\n\tby mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 4AD1619560A2; Tue, 19 May 2026 03:01:01 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"BTB83eCt\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1779159667;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=Rph6zznLUJ47oRhEc/YsYF9Mbw7kyC80C/P4tLWBpmE=;\n\tb=BTB83eCtbrELMhuxMY6pQF5EtyaB6ZebbD2et6CxnSGqX4gguTJoY2DGt/9Q7m8sGus5mY\n\tCCvyAK40XnopYA2gQiCngcpaX+nHVlHEmh+C+EzTOeun55HQ6uqULpoobj24HNlL6HnbAZ\n\tcem+di/iDiabe/z5Z/h/B/2ZNCotSVM=", "X-MC-Unique": "XYfSSGVINhW7CtIjhmLhCg-1", "X-Mimecast-MFC-AGG-ID": "XYfSSGVINhW7CtIjhmLhCg_1779159664", "From": "Kate Hsuan <hpa@redhat.com>", "To": "libcamera-devel@lists.libcamera.org, =?utf-8?b?QmFybmFiw6FzIFDFkWN6?=\n\t=?utf-8?q?e?= <barnabas.pocze@ideasonboard.com>, Kieran Bingham\n\t<kieran.bingham@ideasonboard.com>", "Cc": "Kate Hsuan <hpa@redhat.com>", "Subject": "[PATCH v3 4/4] meson: Add ipa-signature-algo option", "Date": "Tue, 19 May 2026 11:00:20 +0800", "Message-ID": "<20260519030020.408693-5-hpa@redhat.com>", "In-Reply-To": "<20260519030020.408693-1-hpa@redhat.com>", "References": "<20260519030020.408693-1-hpa@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.12", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "UGizZmGaezPZLks-oiAWjTEOZ5MhUyXvj1GNB_R0hZQ_1779159664", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add a combo type \"ipa-signature-algo\" meson option to select signature\nalgorithms, including rsa-sha256 and ml-dsa-65.\nras-sha256 is the default setting for now.\n\nSigned-off-by: Kate Hsuan <hpa@redhat.com>\n---\n meson_options.txt | 8 ++++++++\n src/libcamera/meson.build | 6 ++++++\n src/meson.build | 14 +++++++++++---\n utils/gen-ipa-priv-key.sh | 16 ++++++++++++++--\n 4 files changed, 39 insertions(+), 5 deletions(-)", "diff": "diff --git a/meson_options.txt b/meson_options.txt\nindex 20baacc4..18488e6b 100644\n--- a/meson_options.txt\n+++ b/meson_options.txt\n@@ -46,6 +46,14 @@ option('gstreamer',\n value : 'auto',\n description : 'Compile libcamera GStreamer plugin')\n \n+option('ipa-signature-algo',\n+ type : 'combo',\n+ choices : [\n+ 'rsa-sha256',\n+ 'ml-dsa-65',\n+ ],\n+ description : 'Select a signature algorithm to sign IPA libraries.')\n+\n option('ipas',\n type : 'array',\n choices : ['ipu3', 'mali-c55', 'rkisp1', 'rpi/pisp', 'rpi/vc4', 'simple',\ndiff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\nindex 575408b2..55ba6c6d 100644\n--- a/src/libcamera/meson.build\n+++ b/src/libcamera/meson.build\n@@ -97,6 +97,12 @@ else\n endif\n endif\n \n+# comply with FIPS 204\n+signature_algo = get_option('ipa-signature-algo')\n+if signature_algo == 'ml-dsa-65'\n+ config_h.set('WITH_PQC', 1)\n+endif\n+\n if not libcrypto.found()\n warning('Neither gnutls nor libcrypto found, all IPA modules will be isolated')\n summary({'IPA modules signed with': 'None (modules will run isolated)'},\ndiff --git a/src/meson.build b/src/meson.build\nindex 9b63c8e8..7f8909b1 100644\n--- a/src/meson.build\n+++ b/src/meson.build\n@@ -15,11 +15,19 @@ summary({\n }, section : 'Paths')\n \n # Module Signing\n+signature_algo = get_option('ipa-signature-algo')\n openssl = find_program('openssl', required : false)\n if openssl.found()\n- ipa_priv_key = custom_target('ipa-priv-key',\n- output : ['ipa-priv-key.pem'],\n- command : [gen_ipa_priv_key, '@OUTPUT@'])\n+ if signature_algo == 'ml-dsa-65'\n+ ipa_priv_key = custom_target('ipa-priv-key',\n+ output : ['ipa-priv-key.pem'],\n+ command : [gen_ipa_priv_key, 'ML-DSA-65', '@OUTPUT@'])\n+ endif\n+ if signature_algo == 'rsa-sha256'\n+ ipa_priv_key = custom_target('ipa-priv-key',\n+ output : ['ipa-priv-key.pem'],\n+ command : [gen_ipa_priv_key, 'RSA', '@OUTPUT@'])\n+ endif\n config_h.set('HAVE_IPA_PUBKEY', 1)\n ipa_sign_module = true\n else\ndiff --git a/utils/gen-ipa-priv-key.sh b/utils/gen-ipa-priv-key.sh\nindex 2ca7b883..8b86dfb3 100755\n--- a/utils/gen-ipa-priv-key.sh\n+++ b/utils/gen-ipa-priv-key.sh\n@@ -6,6 +6,18 @@\n #\n # Generate an RSA private key to sign IPA modules\n \n-key=\"$1\"\n+algo=\"$1\"\n+key=\"$2\"\n \n-openssl genpkey -algorithm RSA -out \"${key}\" -pkeyopt rsa_keygen_bits:2048\n+# Two possible algorithms: RSA and ML-DSA-65\n+# openssl genpkey -algorithm RSA -out \"${key}\" -pkeyopt rsa_keygen_bits:2048\n+# openssl genpkey -algorithm ML-DSA-65 -out \"${key}\"\n+\n+if [ \"$algo\" = \"RSA\" ]; then\n+ openssl genpkey -algorithm RSA -out \"${key}\" -pkeyopt rsa_keygen_bits:2048\n+elif [ \"$algo\" = \"ML-DSA-65\" ]; then\n+ openssl genpkey -algorithm ML-DSA-65 -out \"${key}\"\n+else\n+ echo \"Invalid algorithm: $algo\"\n+ exit 1\n+fi\n\\ No newline at end of file\n", "prefixes": [ "v3", "4/4" ] }