Patch Detail
Show a patch.
GET /api/patches/2675/?format=api
{ "id": 2675, "url": "https://patchwork.libcamera.org/api/patches/2675/?format=api", "web_url": "https://patchwork.libcamera.org/patch/2675/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200118200015.16531-2-nicolas@ndufresne.ca>", "date": "2020-01-18T20:00:10", "name": "[libcamera-devel,v4,1/6] checkstyle: Move from pep8 to pycodestyle", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "f3bb50d3e1a47b913d00e2f1ea817f669ed09849", "submitter": { "id": 30, "url": "https://patchwork.libcamera.org/api/people/30/?format=api", "name": "Nicolas Dufresne", "email": "nicolas@ndufresne.ca" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/2675/mbox/", "series": [ { "id": 636, "url": "https://patchwork.libcamera.org/api/series/636/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=636", "date": "2020-01-18T20:00:09", "name": "Add the ability to do pre-commit style check", "version": 4, "mbox": "https://patchwork.libcamera.org/series/636/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/2675/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/2675/checks/", "tags": {}, "headers": { "Return-Path": "<nicolas@ndufresne.ca>", "Received": [ "from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EBBF2607B0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 18 Jan 2020 21:02:43 +0100 (CET)", "from nicolas-tpx395.localdomain (unknown\n\t[IPv6:2002:c0de:c115:0:66fc:8b:2a38:8313])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits))\n\t(No client certificate requested) (Authenticated sender: nicolas)\n\tby bhuna.collabora.co.uk (Postfix) with ESMTPSA id 96C902911C1;\n\tSat, 18 Jan 2020 20:02:42 +0000 (GMT)" ], "From": "Nicolas Dufresne <nicolas@ndufresne.ca>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Nicolas Dufresne <nicolas.dufresne@collabora.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>", "Date": "Sat, 18 Jan 2020 15:00:10 -0500", "Message-Id": "<20200118200015.16531-2-nicolas@ndufresne.ca>", "X-Mailer": "git-send-email 2.24.1", "In-Reply-To": "<20200118200015.16531-1-nicolas@ndufresne.ca>", "References": "<20200118200015.16531-1-nicolas@ndufresne.ca>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v4 1/6] checkstyle: Move from pep8 to\n\tpycodestyle", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Sat, 18 Jan 2020 20:02:44 -0000" }, "content": "From: Nicolas Dufresne <nicolas.dufresne@collabora.com>\n\nThe tool has been renamed in 2016 to make it more obvious what it\nis doing. There is no other changes needed on our side.\n\nSee https://github.com/PyCQA/pycodestyle/issues/466\n\nSigned-off-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n utils/checkstyle.py | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/utils/checkstyle.py b/utils/checkstyle.py\nindex 93f0291..7edea25 100755\n--- a/utils/checkstyle.py\n+++ b/utils/checkstyle.py\n@@ -321,10 +321,10 @@ class Pep8Checker(StyleChecker):\n data = ''.join(self.__content).encode('utf-8')\n \n try:\n- ret = subprocess.run(['pep8', '--ignore=E501', '-'],\n+ ret = subprocess.run(['pycodestyle', '--ignore=E501', '-'],\n input=data, stdout=subprocess.PIPE)\n except FileNotFoundError:\n- issues.append(StyleIssue(0, None, \"Please install pep8 to validate python additions\"))\n+ issues.append(StyleIssue(0, None, \"Please install pycodestyle to validate python additions\"))\n return issues\n \n results = ret.stdout.decode('utf-8').splitlines()\n", "prefixes": [ "libcamera-devel", "v4", "1/6" ] }