Patch Detail
Show a patch.
GET /api/patches/26748/?format=api
{ "id": 26748, "url": "https://patchwork.libcamera.org/api/patches/26748/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26748/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260512225505.234522-1-laurent.pinchart@ideasonboard.com>", "date": "2026-05-12T22:55:05", "name": "Documentation: Split public and internal post-install actions", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "9cadcb8554a147d93141093ce888e357c24d9271", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26748/mbox/", "series": [ { "id": 5942, "url": "https://patchwork.libcamera.org/api/series/5942/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5942", "date": "2026-05-12T22:55:05", "name": "Documentation: Split public and internal post-install actions", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5942/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26748/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26748/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 14405BDCBD\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 12 May 2026 22:55:11 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EEC8363025;\n\tWed, 13 May 2026 00:55:09 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6968D62DC4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 13 May 2026 00:55:07 +0200 (CEST)", "from killaraus.ideasonboard.com\n\t(2001-14ba-70f3-e800--a06.rev.dnainternet.fi\n\t[IPv6:2001:14ba:70f3:e800::a06])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 203E5557;\n\tWed, 13 May 2026 00:54:59 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"md5H+sjc\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1778626499;\n\tbh=gtohnQ1K+G8ToWCcKDy5/crk52Xudk1r87Zmf3ZoTJw=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=md5H+sjc918/MlhNzZODLzzn0qiS+Hpyy28ALREtWIUiNlORNfWe3YiAxbkSzswbP\n\tedX2H8WDKmdYDvuo4Zw0pu8lb4bVEeE3rKuDr2o0ONvI+8EBqG0LBZW7p4ozVjBm1z\n\t2LAyqBY28fp7yR7NN9hFYidg2aLXT+PEL2KLi9Jc=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>,\n\tStefan Klug <stefan.klug@ideasonboard.com>", "Subject": "[PATCH] Documentation: Split public and internal post-install\n\tactions", "Date": "Wed, 13 May 2026 01:55:05 +0300", "Message-ID": "<20260512225505.234522-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.53.0", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "We move the Doxygen-generated API documentation to the Sphinx output\ndirectory at installation time, in order to integrate the two parts of\nthe documentation together. This uses a post-install script, arguably as\na hack, for lack of a better solution ([1]).\n\nThe post-install step does not specify tags, which prevents it from\nrunning when installing the doc or doc-internal tags only. To fix it,\nsplit it in two runs, one for the public and one for the internal API,\nand tag them with 'doc' and 'doc-internal' respectively. As the script\nis now called with a single API directory, simplify it and make it print\na more precise message.\n\n[1] See commit 4a9863e05397 (\"Documentation: Improve Sphinx and Doxygen\nintegration\") for a more detailed explanation.\n\nReported-by: Stefan Klug <stefan.klug@ideasonboard.com>\nCloses: https://gitlab.freedesktop.org/camera/libcamera/-/work_items/333\nSuggested-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n Documentation/install-doxygen.sh | 11 ++++-------\n Documentation/meson.build | 6 ++++--\n 2 files changed, 8 insertions(+), 9 deletions(-)\n\n\nbase-commit: b0dbd5100b1b1665dd2bc839d06263d55a89a6bd", "diff": "diff --git a/Documentation/install-doxygen.sh b/Documentation/install-doxygen.sh\nindex ea5a19dc8fda..091f356fe529 100755\n--- a/Documentation/install-doxygen.sh\n+++ b/Documentation/install-doxygen.sh\n@@ -7,12 +7,9 @@\n # Move Doxygen-generated API documentation to correct location\n \n doc_dir=\"${MESON_INSTALL_DESTDIR_PREFIX}/$1\"\n-shift\n-dirs=\"$*\"\n+api_dir=\"$2\"\n \n-echo \"Moving API documentation\"\n+echo \"Moving Doxygen ${api_dir} API documentation\"\n \n-for dir in $dirs ; do\n-\trm -r \"${doc_dir}/html/${dir}\"\n-\tmv \"${doc_dir}/${dir}\" \"${doc_dir}/html/\"\n-done\n+rm -r \"${doc_dir}/html/${api_dir}\"\n+mv \"${doc_dir}/${api_dir}\" \"${doc_dir}/html/\"\ndiff --git a/Documentation/meson.build b/Documentation/meson.build\nindex 51899c19c166..84c05091d5b5 100644\n--- a/Documentation/meson.build\n+++ b/Documentation/meson.build\n@@ -194,8 +194,10 @@ if sphinx.found()\n install_dir : doc_install_dir,\n install_tag : 'doc')\n \n- meson.add_install_script('install-doxygen.sh', doc_install_dir,\n- 'public-api', 'internal-api')\n+ meson.add_install_script('install-doxygen.sh', doc_install_dir, 'public-api',\n+ install_tag : 'doc')\n+ meson.add_install_script('install-doxygen.sh', doc_install_dir, 'internal-api',\n+ install_tag : 'doc-internal')\n \n custom_target('documentation-linkcheck',\n command : [sphinx, '-W', '-b', 'linkcheck',\n", "prefixes": [] }