Patch Detail
Show a patch.
GET /api/patches/26745/?format=api
{ "id": 26745, "url": "https://patchwork.libcamera.org/api/patches/26745/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26745/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260512175340.115153-4-johannes.goede@oss.qualcomm.com>", "date": "2026-05-12T17:53:39", "name": "[v5,3/4] ipa: Allow pipelines to have differently named IPA", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "0b172f06dbaf70a9f38027befdb6c9b398d06f46", "submitter": { "id": 242, "url": "https://patchwork.libcamera.org/api/people/242/?format=api", "name": "Hans de Goede", "email": "johannes.goede@oss.qualcomm.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26745/mbox/", "series": [ { "id": 5940, "url": "https://patchwork.libcamera.org/api/series/5940/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5940", "date": "2026-05-12T17:53:36", "name": "ipa: Allow IPA creation by name", "version": 5, "mbox": "https://patchwork.libcamera.org/series/5940/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26745/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26745/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D527AC32F7\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 12 May 2026 17:53:55 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EA61F63022;\n\tTue, 12 May 2026 19:53:54 +0200 (CEST)", "from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com\n\t[205.220.180.131])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7F3186302E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 12 May 2026 19:53:51 +0200 (CEST)", "from pps.filterd (m0279872.ppops.net [127.0.0.1])\n\tby mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n\t64CHYAaO591816 for <libcamera-devel@lists.libcamera.org>;\n\tTue, 12 May 2026 17:53:50 GMT", "from mail-vs1-f69.google.com (mail-vs1-f69.google.com\n\t[209.85.217.69])\n\tby mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e4319sqy8-1\n\t(version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 12 May 2026 17:53:50 +0000 (GMT)", "by mail-vs1-f69.google.com with SMTP id\n\tada2fe7eead31-6312af70ad0so5405688137.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 12 May 2026 10:53:50 -0700 (PDT)", "from shalem\n\t(2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl.\n\t[2001:1c00:c32:7800:5bfa:a036:83f0:f9ec])\n\tby smtp.gmail.com with ESMTPSA id\n\ta640c23a62f3a-bce128529fbsm463191566b.36.2026.05.12.10.53.47\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 12 May 2026 10:53:47 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=qualcomm.com header.i=@qualcomm.com\n\theader.b=\"iVo+o7o6\"; dkim=pass (2048-bit key;\n\tunprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n\theader.b=\"G7sdFWb4\"; dkim-atps=neutral", "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n\tcc:content-transfer-encoding:date:from:in-reply-to:message-id\n\t:mime-version:references:subject:to; s=qcppdkim1; bh=ZNIDbrZMOBp\n\tukyyc/EOPT+Y55mvet/Oi0tiQabloDNY=; b=iVo+o7o6QI00SbQEms93szQ5/Tk\n\twVYwHI1CS8JzG1tt4ZQGCBs6+1fM5QXiVp5rcOAOFBj2SaMYmx3GFtsdSiIpIX2C\n\tB+y8QF8GvlRTAYL5+oMUBqVbW//ZUf7humjdKbzvLSGJFEx4Rhg59u4hnIGQbiSA\n\tzPMZcSHFIvWe5580xTYNcLq6kP9SvG9gTF8ig59GmwxALtSBbNUKexGcR93f6GDi\n\tUo1DtJq0wymwINbkMtbWqQ63npNYAEf9T14MXxoPU3BloqS6r084o9vyo/eOOHZT\n\tWldswaP7CAse0VFDVD+Funbg4N2Ky1wNER7mA1D0RMaQczqV94jTnnfoOeg==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=oss.qualcomm.com; s=google; t=1778608429; x=1779213229;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=ZNIDbrZMOBpukyyc/EOPT+Y55mvet/Oi0tiQabloDNY=;\n\tb=G7sdFWb4ZrzsaqvMyj6RhbaqYcxtMitksGhFKbfe/E9b/JYbkXWJE6ugBOTbUqHhPy\n\tUWaSzqIrlIhix7lW38Jw4RuF1cx05VRS2Vy6IBQhf7hV6pO/MUMbbfS5mzl3sMQM6vUC\n\tr4/H4aSvtSLOXXhGz3xOY8v7w893N5Ky39x2Vs8gmEcKqlmfo1mJDb4flY4bx61Q2uj6\n\tOtIa0v9BUO5dOmXTpKDGBjxiTBwJelrCk2acG/7sZmF7OFoNVWHdTv+kPXl6JPhg3IET\n\tQ6lyDdcJfhky67T3S/hEsyPezxr9VoMVlfBE17LEPq2t4tdxZzDKWjWGTKOwCWmlGp1d\n\tkscQ==" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20251104; t=1778608429; x=1779213229;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=ZNIDbrZMOBpukyyc/EOPT+Y55mvet/Oi0tiQabloDNY=;\n\tb=sr6/oLMvyH882ZaWEsdMNuBCJN5zod22G5rqi6L3z3LW8Il5FMJP2yoBNiALxKbypW\n\tYVQ+CA3H6UCh6qKmaNwGMjunPEQuhe5E/ZfWCFp743M443j2rj/o8i7UJ9NeiccJV/Ec\n\teGlDFK9hEPk+j2XX17jiJ/spflll8TpkKTD0fQrZhAytnN5yPDn7baCTT+y4B0kKMF07\n\t1ppZrerTIEyJtCURQkaANzW1I6n1/IztjtvX8fcLReSIEgCsjJm2VB/NO4x8AWtSki/5\n\tHUIlihb5MJZjL2zgBXoO4NswUijN+hGq6OTWzLzJ9MbnePe4gc16mP9c2a9jwyLDOb+b\n\thQ6w==", "X-Gm-Message-State": "AOJu0Yye/8m81ryv+7OpKk3n37WJ2PbqIJxIQpZ03K3WLV0xJIHFu6qM\n\t5nlRoyxUDcPNeBobveX1i8Sbt0oswzN8x0jLAtBm7V6zHSQWa5/ooYWXdgT6sYPoAKTW3fWkECn\n\tIN6UQaiofyXHm9ngVijBK8le0moqXPpI6IdglWUSRUW4muutcUCRMZdFK2JzB9J/wGCCPdWh1L5\n\tBIhlQwPKGe", "X-Gm-Gg": "Acq92OEtjweVwqWl63KPrVastn7i34ChhaU8r0H72+m+YbNaKWGfmrkK3JRPNvJ+ew1\n\tCVHpC6sCQKKtSvZ7sG6UDpvkCi0PsYQoGXXRFQSBcH2YBMazkFHzbBtpUE5WocRbvUQvBFfxYfc\n\ttEKzyn7x2KEqVYrfbuL46oAdP3gVNoQ+Th01elIej6WWDIuiOOMqkt/82f9jBoeUf+mDbpHNh6B\n\t78R0+q2HW/ycPglyKgqSnwV+aTy2bkqYj4WRHomT7gIGMgrWLCkbDe6TBdMpeDOY1TLORK4iIMX\n\tObt+B2vjV0oUbl8Vj6K0mMTQV6x0luAXosPM2mGfw9UHsf6m7MCK/5L87ZRVbe7beojx86QnwNx\n\tXj5kcAzqHnsdKpGmSb0rSIcOahlJoxHFw1TD9jPunM9KnjIaFYRWK5cSAwJuf6yoOKNCyoiOWvU\n\tblxUaPS8elz1zy7vwxbM9QUYDeT1ovDz6uxudK", "X-Received": [ "by 2002:a05:6102:f9f:b0:631:ab8b:c348 with SMTP id\n\tada2fe7eead31-63615516eb5mr2422057137.8.1778608429344; \n\tTue, 12 May 2026 10:53:49 -0700 (PDT)", "by 2002:a05:6102:f9f:b0:631:ab8b:c348 with SMTP id\n\tada2fe7eead31-63615516eb5mr2422043137.8.1778608428842; \n\tTue, 12 May 2026 10:53:48 -0700 (PDT)" ], "From": "Hans de Goede <johannes.goede@oss.qualcomm.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Hans de Goede <johannes.goede@oss.qualcomm.com>,\n\tJacopo Mondi <jacopo.mondi@ideasonboard.com>", "Subject": "[PATCH v5 3/4] ipa: Allow pipelines to have differently named IPA", "Date": "Tue, 12 May 2026 19:53:39 +0200", "Message-ID": "<20260512175340.115153-4-johannes.goede@oss.qualcomm.com>", "X-Mailer": "git-send-email 2.54.0", "In-Reply-To": "<20260512175340.115153-1-johannes.goede@oss.qualcomm.com>", "References": "<20260512175340.115153-1-johannes.goede@oss.qualcomm.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwNTEyMDE4NSBTYWx0ZWRfX7gfQmDxopSNZ\n\tqu/CDslubiJ8Vo2z8EmfzWZ/TBTt9Y/ltp2T2Dgu4PyznKzuSD/j8fA14C0anaoWVxf8cpNncM3\n\t0KbAJ6nwB8oENKmgzF3fVLypvt8/Wmn9TCJAf5KUoD8qlxGR8a4+34nhNBa9dzTiv9bPsbSswJl\n\t8jlU15GgruPSD32Id0K16E1sp9EU9wC7B0Zsl8iKRg+uEP6xt5zDQq3MUWQJdshl9C1Vr2TCttK\n\tGp3hIWbLskRdSv8O90hHU1SLXUGPM+lIjQcWMv7Oc20MseXhWbCiffgd1YMKv4vEugcLxl+5t0a\n\t92AcjfTYxf+SK1Ob9saTbIcubIlCZo5pSGyYlDWrMjE7hg8BDx9IVIOQamz1bG4kH0of6ROyFfl\n\txneObmCE4dwb3jZNk+lBIcN/1uCpEzYro7tgZfWvR5D4WIqiJ+pOUfJxMGczZJJoJk0s54mknw2\n\tyBJUEI9whagYCUvEopQ==", "X-Proofpoint-GUID": "OSexeiUJso_nYIuJ8F8Hvb7l0aaskYXL", "X-Authority-Analysis": "v=2.4 cv=bp98wkai c=1 sm=1 tr=0 ts=6a03692e cx=c_pps\n\ta=5HAIKLe1ejAbszaTRHs9Ug==:117 a=xqWC_Br6kY4A:10 a=NGcC8JguVDcA:10\n\ta=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22\n\ta=yx91gb_oNiZeI1HMLzn7:22 a=P1BnusSwAAAA:8 a=EUspDBNiAAAA:8\n\ta=c6ydndUcIca2Pb-fbGsA:9 a=gYDTvv6II1OnSo0itH1n:22\n\ta=D0XLA9XvdZm18NrgonBM:22", "X-Proofpoint-ORIG-GUID": "OSexeiUJso_nYIuJ8F8Hvb7l0aaskYXL", "X-Proofpoint-Virus-Version": "vendor=baseguard\n\tengine=ICAP:2.0.293, Aquarius:18.0.1143, Hydra:6.1.51,\n\tFMLib:17.12.100.49\n\tdefinitions=2026-05-11_05,2026-05-08_02,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n\tpriorityscore=1501 adultscore=0 clxscore=1015 bulkscore=0\n\tmalwarescore=0\n\tlowpriorityscore=0 suspectscore=0 phishscore=0 spamscore=0\n\timpostorscore=0\n\tclassifier=typeunknown authscore=0 authtc= authcc= route=outbound\n\tadjust=0\n\treason=mlx scancount=1 engine=8.22.0-2605050000\n\tdefinitions=main-2605120185", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n\nRight now the build system assumes a 1-to-1 matching between a pipeline\nhandler name and an IPA module.\n\nThis, as also acknowledged by a \\todo comment, is quite a rigid\nrequirement and only allows a 1-to-1 matching between pipeline and IPA\nnames. The more platforms libcamera supports, the more it is likely that\na pipeline handler could re-use an IPA module. This is particularly\nrelevant for the softISP IPA module which could theoretically be plugged\nto any pipeline. Likewise, the forthcoming R-Car Gen4 support uses the\nRkISP1 IPA and at the moment would require building the 'rkisp1'\npipeline in to have the IPA module available.\n\nWhen building IPAs, the build system iterates the list of enabled\npipeline handlers and for each of them tries to verify if the 'ipas'\nlist contains a corresponding entry for it. The 'ipas' meson options is\nan array option and, as no default value is specified for it, it\ncontains by default all its possible choices.\n\nIn this way if no value is specified for the 'ipas' option, compiling\nthe pipeline handlers ['X','Y', 'Z'] will compile the ['X', 'Y', 'Z']\nIPAs. If instead the user specifies '-Dipas=X' during the configuration\nthen only IPA module ['X'] will be built, regardless of which pipeline is\nenabled. Building an IPA module will anyway require to build a\ncorresponding pipeline with the same name.\n\nRelax the 1-to-1 'pipeline'-'IPA' naming requirement by introducing a\ndictionary that associates pipelines with IPA modules.\n\nFor each enabled pipeline:\n1) Make sure an IPA module exists for it\n2) Make sure the IPA module is enabled by the 'ipas' option\n3) Make sure the IPA is compiled once only\n\nThis will require every new pipeline to add an entry to the dictionary\nand specify which IPA module they would like to use.\n\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\nReviewed-by: Hans de Goede <johannes.goede@oss.qualcomm.com>\nSigned-off-by: Hans de Goede <johannes.goede@oss.qualcomm.com>\n---\n src/ipa/meson.build | 40 ++++++++++++++++++++++++++++++----------\n 1 file changed, 30 insertions(+), 10 deletions(-)", "diff": "diff --git a/src/ipa/meson.build b/src/ipa/meson.build\nindex eb7846e47..c583c7efd 100644\n--- a/src/ipa/meson.build\n+++ b/src/ipa/meson.build\n@@ -24,6 +24,16 @@ subdir('libipa')\n \n ipa_sign = files('ipa-sign.sh')\n \n+supported_ipas = {\n+ 'ipu3': 'ipu3',\n+ 'mali-c55': 'mali-c55',\n+ 'rkisp1': 'rkisp1',\n+ 'rpi/pisp': 'rpi/pisp',\n+ 'rpi/vc4': 'rpi/vc4',\n+ 'simple': 'simple',\n+ 'vimc': 'vimc'\n+}\n+\n ipa_modules = get_option('ipas')\n \n # Tests require the vimc IPA, similar to vimc pipline-handler for their\n@@ -39,24 +49,34 @@ ipa_names = []\n \n subdirs = []\n foreach pipeline : pipelines\n- # The current implementation expects the IPA module name to match the\n- # pipeline name.\n- # \\todo Make the IPA naming scheme more flexible.\n- if not ipa_modules.contains(pipeline)\n+ # Make sure an IPA exists for the pipeline\n+ if not supported_ipas.has_key(pipeline)\n continue\n endif\n- enabled_ipa_names += pipeline\n+\n+ ipa = supported_ipas.get(pipeline)\n+\n+ # Only build IPAs specified with '-Dipas'\n+ if not ipa_modules.contains(ipa)\n+ continue\n+ endif\n+\n+ # If enabled already do not add it twice\n+ if enabled_ipa_names.contains(ipa)\n+ continue\n+ endif\n+ enabled_ipa_names += ipa\n \n # Allow multi-level directory structuring for the IPAs if needed.\n- pipeline = pipeline.split('/')[0]\n- if pipeline in subdirs\n+ ipa = ipa.split('/')[0]\n+ if ipa in subdirs\n continue\n endif\n \n- subdirs += pipeline\n- subdir(pipeline)\n+ subdirs += ipa\n+ subdir(ipa)\n \n- # Don't reuse the pipeline variable below, the subdirectory may have\n+ # Don't reuse the ipa variable below, the subdirectory may have\n # overwritten it.\n endforeach\n \n", "prefixes": [ "v5", "3/4" ] }