Patch Detail
Show a patch.
GET /api/patches/26732/?format=api
{ "id": 26732, "url": "https://patchwork.libcamera.org/api/patches/26732/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26732/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260512123619.120068-10-mzamazal@redhat.com>", "date": "2026-05-12T12:36:13", "name": "[RFC,v5,09/10] libcamera: software_isp: Use LSC type instead of LSC enabled", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "e5dc279618cb4600c1f824a5d366b4b07d48c015", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26732/mbox/", "series": [ { "id": 5936, "url": "https://patchwork.libcamera.org/api/series/5936/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5936", "date": "2026-05-12T12:36:04", "name": "LSC for SoftISP simple pipeline", "version": 5, "mbox": "https://patchwork.libcamera.org/series/5936/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26732/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26732/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5D3B6BDB1C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 12 May 2026 12:37:04 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 02DFC63035;\n\tTue, 12 May 2026 14:37:04 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ABA6363040\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 12 May 2026 14:37:00 +0200 (CEST)", "from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-398-qbmrZvBQPYSzSMxMBEKtHA-1;\n\tTue, 12 May 2026 08:36:58 -0400", "from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.17])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 2B6AD1800614; Tue, 12 May 2026 12:36:57 +0000 (UTC)", "from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.50.44])\n\tby mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 1A7C11955D84; Tue, 12 May 2026 12:36:54 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"HuQqZDHH\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1778589419;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=4lVwO/cOUEnaMm7csGaMuC3ip1vYDO+wof8lFUK287g=;\n\tb=HuQqZDHHWC/Un9BMP5GBq+pFvQOp3oiiFPV12QTDEqs3jdq9F4llSugGTrhg3hPkpCBfUr\n\tfszWkovrQz7fEuLgbqSh6pV5feOCM9iJSm9QRTVQ8Va3Dbd0Mg0r4DVtGnBYsFg2w3oLNP\n\t3D7/nRObn3kw60qsrwZutBdyd/m7uE4=", "X-MC-Unique": "qbmrZvBQPYSzSMxMBEKtHA-1", "X-Mimecast-MFC-AGG-ID": "qbmrZvBQPYSzSMxMBEKtHA_1778589417", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>, Bryan O'Donoghue <bod.linux@nxsw.ie>,\n\tHans de Goede <johannes.goede@oss.qualcomm.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>", "Subject": "[RFC PATCH v5 09/10] libcamera: software_isp: Use LSC type instead\n\tof LSC enabled", "Date": "Tue, 12 May 2026 14:36:13 +0200", "Message-ID": "<20260512123619.120068-10-mzamazal@redhat.com>", "In-Reply-To": "<20260512123619.120068-1-mzamazal@redhat.com>", "References": "<20260512123619.120068-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.17", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "_Wh_x4d2_yrc-mAYdlJ2mS7jjUOo8WK9uZEkO8SC6KE_1778589417", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "With the upcoming introduction of polynomial lens shading correction,\nlet's replace the boolean LSC-enabled flag with an enum / integer\nindicating the type of the LSC to apply. For the case when LSC is not\nenabled, LscNone enum value is introduced.\n\nThe switch passed to the shaders is renamed from APPLY_LSC to\nAPPLY_LSC_TABLE to get ready for other LSC types and other APPLY_LSC_*\nswitches for shaders.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n .../internal/software_isp/debayer_params.h | 1 +\n .../internal/software_isp/software_isp.h | 2 +-\n include/libcamera/ipa/soft.mojom | 2 +-\n src/ipa/simple/algorithms/lsc.cpp | 2 +-\n src/ipa/simple/ipa_context.h | 3 ++-\n src/ipa/simple/soft_simple.cpp | 6 +++---\n src/libcamera/shaders/bayer_1x_packed.frag | 4 ++--\n src/libcamera/shaders/bayer_unpacked.frag | 4 ++--\n src/libcamera/software_isp/debayer.cpp | 2 +-\n src/libcamera/software_isp/debayer.h | 2 +-\n src/libcamera/software_isp/debayer_cpu.cpp | 2 +-\n src/libcamera/software_isp/debayer_cpu.h | 2 +-\n src/libcamera/software_isp/debayer_egl.cpp | 21 +++++++++++++------\n src/libcamera/software_isp/debayer_egl.h | 6 +++---\n src/libcamera/software_isp/software_isp.cpp | 4 ++--\n 15 files changed, 37 insertions(+), 26 deletions(-)", "diff": "diff --git a/include/libcamera/internal/software_isp/debayer_params.h b/include/libcamera/internal/software_isp/debayer_params.h\nindex 9e6c9ddb8..37fff49a2 100644\n--- a/include/libcamera/internal/software_isp/debayer_params.h\n+++ b/include/libcamera/internal/software_isp/debayer_params.h\n@@ -35,6 +35,7 @@ struct DebayerParams {\n \tusing LscLookupTable =\n \t\tstd::array<LscValueType, kLscGridSize * kLscGridSize * kLscValuesPerCell>;\n \tenum LscType : uint32_t {\n+\t\tLscNone,\n \t\tLscTable,\n \t};\n \tLscLookupTable lscLut{};\ndiff --git a/include/libcamera/internal/software_isp/software_isp.h b/include/libcamera/internal/software_isp/software_isp.h\nindex 1e30b2d68..ded0c3917 100644\n--- a/include/libcamera/internal/software_isp/software_isp.h\n+++ b/include/libcamera/internal/software_isp/software_isp.h\n@@ -99,7 +99,7 @@ private:\n \tDebayerParams debayerParams_;\n \tDmaBufAllocator dmaHeap_;\n \tbool ccmEnabled_;\n-\tbool lscEnabled_;\n+\tuint32_t lscType_;\n \n \tstd::unique_ptr<ipa::soft::IPAProxySoft> ipa_;\n \tstd::deque<FrameBuffer *> queuedInputBuffers_;\ndiff --git a/include/libcamera/ipa/soft.mojom b/include/libcamera/ipa/soft.mojom\nindex aaefd50c4..e65a6127c 100644\n--- a/include/libcamera/ipa/soft.mojom\n+++ b/include/libcamera/ipa/soft.mojom\n@@ -20,7 +20,7 @@ interface IPASoftInterface {\n \t libcamera.ControlInfoMap sensorControls)\n \t\t=> (int32 ret,\n \t\t libcamera.ControlInfoMap ipaControls,\n-\t\t bool ccmEnabled, bool lscEnabled);\n+\t\t bool ccmEnabled, uint32 lscType);\n \tstart() => (int32 ret);\n \tstop();\n \tconfigure(IPAConfigInfo configInfo)\ndiff --git a/src/ipa/simple/algorithms/lsc.cpp b/src/ipa/simple/algorithms/lsc.cpp\nindex 87023bc9b..ae5179cfc 100644\n--- a/src/ipa/simple/algorithms/lsc.cpp\n+++ b/src/ipa/simple/algorithms/lsc.cpp\n@@ -36,7 +36,7 @@ int Lsc::init(IPAContext &context, const ValueNode &tuningData)\n \t\treturn -EINVAL;\n \t}\n \n-\tcontext.lscEnabled = true;\n+\tcontext.lscType = type_;\n \n \treturn 0;\n }\ndiff --git a/src/ipa/simple/ipa_context.h b/src/ipa/simple/ipa_context.h\nindex d77bbc280..9972efa6d 100644\n--- a/src/ipa/simple/ipa_context.h\n+++ b/src/ipa/simple/ipa_context.h\n@@ -14,6 +14,7 @@\n #include <libcamera/controls.h>\n \n #include \"libcamera/internal/matrix.h\"\n+#include \"libcamera/internal/software_isp/debayer_params.h\"\n #include \"libcamera/internal/vector.h\"\n \n #include <libipa/fc_queue.h>\n@@ -93,7 +94,7 @@ struct IPAContext {\n \tFCQueue<IPAFrameContext> frameContexts;\n \tControlInfoMap::Map ctrlMap;\n \tbool ccmEnabled = false;\n-\tbool lscEnabled = false;\n+\tDebayerParams::LscType lscType = DebayerParams::LscNone;\n };\n \n } /* namespace ipa::soft */\ndiff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp\nindex 4c724183a..d3f4a52cc 100644\n--- a/src/ipa/simple/soft_simple.cpp\n+++ b/src/ipa/simple/soft_simple.cpp\n@@ -58,7 +58,7 @@ public:\n \t\t const ControlInfoMap &sensorControls,\n \t\t ControlInfoMap *ipaControls,\n \t\t bool *ccmEnabled,\n-\t\t bool *lscEnabled) override;\n+\t\t uint32_t *lscType) override;\n \tint configure(const IPAConfigInfo &configInfo) override;\n \n \tint start() override;\n@@ -99,7 +99,7 @@ int IPASoftSimple::init(const IPASettings &settings,\n \t\t\tconst ControlInfoMap &sensorControls,\n \t\t\tControlInfoMap *ipaControls,\n \t\t\tbool *ccmEnabled,\n-\t\t\tbool *lscEnabled)\n+\t\t\tuint32_t *lscType)\n {\n \tcamHelper_ = CameraSensorHelperFactoryBase::create(settings.sensorModel);\n \tif (!camHelper_) {\n@@ -138,7 +138,7 @@ int IPASoftSimple::init(const IPASettings &settings,\n \t\treturn ret;\n \n \t*ccmEnabled = context_.ccmEnabled;\n-\t*lscEnabled = context_.lscEnabled;\n+\t*lscType = context_.lscType;\n \n \tparams_ = nullptr;\n \tstats_ = nullptr;\ndiff --git a/src/libcamera/shaders/bayer_1x_packed.frag b/src/libcamera/shaders/bayer_1x_packed.frag\nindex 228c72309..dc2b582f8 100644\n--- a/src/libcamera/shaders/bayer_1x_packed.frag\n+++ b/src/libcamera/shaders/bayer_1x_packed.frag\n@@ -70,7 +70,7 @@ uniform vec3 blacklevel;\n uniform float gamma;\n uniform float contrastExp;\n \n-#if defined(APPLY_LSC)\n+#if defined(APPLY_LSC_TABLE)\n uniform sampler2D lsc_tex;\n #endif\n \n@@ -231,7 +231,7 @@ void main(void)\n \n \trgb = rgb - blacklevel;\n \n-#if defined(APPLY_LSC)\n+#if defined(APPLY_LSC_TABLE)\n \trgb = rgb * texture2D(lsc_tex, textureOut).rgb;\n #endif\n \ndiff --git a/src/libcamera/shaders/bayer_unpacked.frag b/src/libcamera/shaders/bayer_unpacked.frag\nindex af87bcc0f..df324e6e1 100644\n--- a/src/libcamera/shaders/bayer_unpacked.frag\n+++ b/src/libcamera/shaders/bayer_unpacked.frag\n@@ -29,7 +29,7 @@ uniform vec3 blacklevel;\n uniform float gamma;\n uniform float contrastExp;\n \n-#if defined(APPLY_LSC)\n+#if defined(APPLY_LSC_TABLE)\n uniform sampler2D lsc_tex;\n #endif\n \n@@ -134,7 +134,7 @@ void main(void) {\n \n rgb = rgb - blacklevel;\n \n-#if defined(APPLY_LSC)\n+#if defined(APPLY_LSC_TABLE)\n rgb = rgb * texture2D(lsc_tex, center.xy).rgb;\n #endif\n \ndiff --git a/src/libcamera/software_isp/debayer.cpp b/src/libcamera/software_isp/debayer.cpp\nindex 12c2ec9fd..a77b3c9fc 100644\n--- a/src/libcamera/software_isp/debayer.cpp\n+++ b/src/libcamera/software_isp/debayer.cpp\n@@ -114,7 +114,7 @@ Debayer::~Debayer()\n * \\param[in] inputCfg The input configuration\n * \\param[in] outputCfgs The output configurations\n * \\param[in] ccmEnabled Whether a color correction matrix is applied\n- * \\param[in] lscEnabled Whether lens shading correction grid is provided\n+ * \\param[in] lscType Type of lens shading correction\n *\n * \\return 0 on success, a negative errno on failure\n */\ndiff --git a/src/libcamera/software_isp/debayer.h b/src/libcamera/software_isp/debayer.h\nindex f4e649417..eb3fa7609 100644\n--- a/src/libcamera/software_isp/debayer.h\n+++ b/src/libcamera/software_isp/debayer.h\n@@ -41,7 +41,7 @@ public:\n \tvirtual int configure(const StreamConfiguration &inputCfg,\n \t\t\t const std::vector<std::reference_wrapper<const StreamConfiguration>> &outputCfgs,\n \t\t\t bool ccmEnabled,\n-\t\t\t bool lscEnabled) = 0;\n+\t\t\t uint32_t lscType) = 0;\n \n \tvirtual std::vector<PixelFormat> formats(PixelFormat inputFormat) = 0;\n \ndiff --git a/src/libcamera/software_isp/debayer_cpu.cpp b/src/libcamera/software_isp/debayer_cpu.cpp\nindex 0a410d03d..14019ff41 100644\n--- a/src/libcamera/software_isp/debayer_cpu.cpp\n+++ b/src/libcamera/software_isp/debayer_cpu.cpp\n@@ -544,7 +544,7 @@ int DebayerCpu::setDebayerFunctions(PixelFormat inputFormat,\n int DebayerCpu::configure(const StreamConfiguration &inputCfg,\n \t\t\t const std::vector<std::reference_wrapper<const StreamConfiguration>> &outputCfgs,\n \t\t\t bool ccmEnabled,\n-\t\t\t [[maybe_unused]] bool lscEnabled)\n+\t\t\t [[maybe_unused]] uint32_t lscType)\n {\n \tif (getInputConfig(inputCfg.pixelFormat, inputConfig_) != 0)\n \t\treturn -EINVAL;\ndiff --git a/src/libcamera/software_isp/debayer_cpu.h b/src/libcamera/software_isp/debayer_cpu.h\nindex 6b7d8b677..de8b99b8a 100644\n--- a/src/libcamera/software_isp/debayer_cpu.h\n+++ b/src/libcamera/software_isp/debayer_cpu.h\n@@ -38,7 +38,7 @@ public:\n \tint configure(const StreamConfiguration &inputCfg,\n \t\t const std::vector<std::reference_wrapper<const StreamConfiguration>> &outputCfgs,\n \t\t bool ccmEnabled,\n-\t\t bool lscEnabled) override;\n+\t\t uint32_t lscType) override;\n \tSize patternSize(PixelFormat inputFormat) override;\n \tstd::vector<PixelFormat> formats(PixelFormat input) override;\n \tstd::tuple<unsigned int, unsigned int>\ndiff --git a/src/libcamera/software_isp/debayer_egl.cpp b/src/libcamera/software_isp/debayer_egl.cpp\nindex 293ec2499..03ec5c5da 100644\n--- a/src/libcamera/software_isp/debayer_egl.cpp\n+++ b/src/libcamera/software_isp/debayer_egl.cpp\n@@ -147,8 +147,13 @@ int DebayerEGL::initBayerShaders(PixelFormat inputFormat, PixelFormat outputForm\n \t/* Specify GL_OES_EGL_image_external */\n \tegl_.pushEnv(shaderEnv, \"#extension GL_OES_EGL_image_external: enable\");\n \n-\tif (lscEnabled_)\n-\t\tegl_.pushEnv(shaderEnv, \"#define APPLY_LSC\");\n+\tswitch (lscType_) {\n+\tcase DebayerParams::LscNone:\n+\t\tbreak;\n+\tcase DebayerParams::LscTable:\n+\t\tegl_.pushEnv(shaderEnv, \"#define APPLY_LSC_TABLE\");\n+\t\tbreak;\n+\t}\n \n \t/*\n \t * Tell shaders how to re-order output taking account of how the pixels\n@@ -289,7 +294,7 @@ int DebayerEGL::initBayerShaders(PixelFormat inputFormat, PixelFormat outputForm\n int DebayerEGL::configure(const StreamConfiguration &inputCfg,\n \t\t\t const std::vector<std::reference_wrapper<const StreamConfiguration>> &outputCfgs,\n \t\t\t [[maybe_unused]] bool ccmEnabled,\n-\t\t\t bool lscEnabled)\n+\t\t\t uint32_t lscType)\n {\n \tif (getInputConfig(inputCfg.pixelFormat, inputConfig_) != 0)\n \t\treturn -EINVAL;\n@@ -306,7 +311,7 @@ int DebayerEGL::configure(const StreamConfiguration &inputCfg,\n \t\treturn -EINVAL;\n \t}\n \n-\tlscEnabled_ = lscEnabled;\n+\tlscType_ = lscType;\n \n \tinputConfig_.stride = inputCfg.stride;\n \tinputPixelFormat_ = inputCfg.pixelFormat;\n@@ -349,7 +354,7 @@ int DebayerEGL::configure(const StreamConfiguration &inputCfg,\n \t */\n \tstats_->setWindow(Rectangle(window_.size()));\n \n-\tif (lscEnabled_) {\n+\tif (lscType_ == DebayerParams::LscTable) {\n \t\tconstexpr unsigned int gridSize = DebayerParams::kLscGridSize;\n \t\tconst unsigned int stride = gridSize * DebayerParams::kLscBytesPerCell;\n \t\teglImageLscLookup_ =\n@@ -499,11 +504,15 @@ void DebayerEGL::setShaderVariableValues(const DebayerParams ¶ms)\n \tglUniformMatrix3fv(ccmUniformDataIn_, 1, GL_FALSE, ccm);\n \tLOG(Debayer, Debug) << \" ccmUniformDataIn_ \" << ccmUniformDataIn_ << \" data \" << params.combinedMatrix;\n \n-\tif (lscEnabled_) {\n+\tswitch (lscType_) {\n+\tcase DebayerParams::LscNone:\n+\t\tbreak;\n+\tcase DebayerParams::LscTable:\n \t\tegl_.createTexture2D(*eglImageLscLookup_, GL_RGB16F, GL_RGB, GL_FLOAT,\n \t\t\t\t DebayerParams::kLscGridSize, DebayerParams::kLscGridSize,\n \t\t\t\t params.lscLut.data(), GL_LINEAR);\n \t\tglUniform1i(textureUniformLsc_, eglImageLscLookup_->texture_unit_uniform_id_);\n+\t\tbreak;\n \t}\n \n \t/*\ndiff --git a/src/libcamera/software_isp/debayer_egl.h b/src/libcamera/software_isp/debayer_egl.h\nindex 85f51cf88..d5cfcad1e 100644\n--- a/src/libcamera/software_isp/debayer_egl.h\n+++ b/src/libcamera/software_isp/debayer_egl.h\n@@ -45,7 +45,7 @@ public:\n \tint configure(const StreamConfiguration &inputCfg,\n \t\t const std::vector<std::reference_wrapper<const StreamConfiguration>> &outputCfgs,\n \t\t bool ccmEnabled,\n-\t\t bool lscEnabled) override;\n+\t\t uint32_t lscType) override;\n \n \tSize patternSize(PixelFormat inputFormat) override;\n \n@@ -77,9 +77,9 @@ private:\n \tstd::unique_ptr<eGLImage> eglImageBayerIn_;\n \tstd::unique_ptr<eGLImage> eglImageBayerOut_;\n \n-\t/* LSC lookup table */\n+\t/* Lens shading correction */\n+\tuint32_t lscType_;\n \tstd::unique_ptr<eGLImage> eglImageLscLookup_;\n-\tbool lscEnabled_;\n \n \t/* Shader parameters */\n \tfloat firstRed_x_;\ndiff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\nindex e35bf10f1..3e59f262c 100644\n--- a/src/libcamera/software_isp/software_isp.cpp\n+++ b/src/libcamera/software_isp/software_isp.cpp\n@@ -158,7 +158,7 @@ SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor,\n \t\t\t sensor->controls(),\n \t\t\t ipaControls,\n \t\t\t &ccmEnabled_,\n-\t\t\t &lscEnabled_);\n+\t\t\t &lscType_);\n \tif (ret) {\n \t\tLOG(SoftwareIsp, Error) << \"IPA init failed\";\n \t\tdebayer_.reset();\n@@ -274,7 +274,7 @@ int SoftwareIsp::configure(const StreamConfiguration &inputCfg,\n \tif (ret < 0)\n \t\treturn ret;\n \n-\tret = debayer_->configure(inputCfg, outputCfgs, ccmEnabled_, lscEnabled_);\n+\tret = debayer_->configure(inputCfg, outputCfgs, ccmEnabled_, lscType_);\n \tif (ret < 0)\n \t\treturn ret;\n \n", "prefixes": [ "RFC", "v5", "09/10" ] }