Patch Detail
Show a patch.
GET /api/patches/26719/?format=api
{ "id": 26719, "url": "https://patchwork.libcamera.org/api/patches/26719/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26719/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260511-libipa-vector-rshift-v3-2-a275f6e87ec4@jetm.me>", "date": "2026-05-11T20:23:29", "name": "[v3,2/2] libcamera: software_isp: Use Vector operator>>= in finishFrame", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "d6c896fe666c2af07cf96b397a6523848dea2131", "submitter": { "id": 261, "url": "https://patchwork.libcamera.org/api/people/261/?format=api", "name": "Javier Tia", "email": "floss@jetm.me" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26719/mbox/", "series": [ { "id": 5934, "url": "https://patchwork.libcamera.org/api/series/5934/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5934", "date": "2026-05-11T20:23:27", "name": "libcamera: Vector right-shift operators and SwStatsCpu use site", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5934/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26719/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26719/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 27FADC32F7\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 11 May 2026 20:23:38 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3D87F62E9D;\n\tMon, 11 May 2026 22:23:37 +0200 (CEST)", "from fhigh-b2-smtp.messagingengine.com\n\t(fhigh-b2-smtp.messagingengine.com [202.12.124.153])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6766A62E9D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 11 May 2026 22:23:34 +0200 (CEST)", "from phl-compute-02.internal (phl-compute-02.internal\n\t[10.202.2.42])\n\tby mailfhigh.stl.internal (Postfix) with ESMTP id 6243D7A0057;\n\tMon, 11 May 2026 16:23:33 -0400 (EDT)", "from phl-imap-07 ([10.202.2.97])\n\tby phl-compute-02.internal (MEProxy); Mon, 11 May 2026 16:23:33 -0400", "by mailuser.phl.internal (Postfix, from userid 501)\n\tid 26BE01EA006B; Mon, 11 May 2026 16:23:33 -0400 (EDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=jetm.me header.i=@jetm.me header.b=\"UMP6fuHy\";\n\tdkim=pass (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com header.b=\"PgnD6qYH\"; \n\tdkim-atps=neutral", "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=jetm.me; h=cc:cc\n\t:content-transfer-encoding:content-type:content-type:date:date\n\t:from:from:in-reply-to:in-reply-to:message-id:mime-version\n\t:references:reply-to:subject:subject:to:to; s=fm2; t=1778531013;\n\tx=1778617413; bh=dtz2UrpL/ptITL8RY4B77zQklBI3B1hKmo+zo82NB3c=; b=\n\tUMP6fuHyAcyGExHwJZtf22BuUFvilKbh/yagcS0jtIWxDJZzhquHLSh09j6rXDWK\n\twB1ptfupKZbvdQhlqEPDrwstUj+RNl6Xn0eHC9FryxYrQBAL1Ydst0K9EFqq3Vtf\n\tgUtKlAzxf0sAXKKj9aaWgJ5FUmOAD4vIUSDQVlaLI9qL3vntilr5bYKKsNAC6EJp\n\t0e0FXqv15CTaPtcSadTD/5nlCJ9aWygIs+hKE0RkG9JV683flIyCrbReX9f01m7I\n\tSwQ0vBxqIYeWLzvIaYfqNHAnR6yiuB8il4MRLoXjQ1vXSmSUxLoGFsHGti7oR/s0\n\twQuwkZrLrglNMeQW6QxmYQ==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:cc:content-transfer-encoding\n\t:content-type:content-type:date:date:feedback-id:feedback-id\n\t:from:from:in-reply-to:in-reply-to:message-id:mime-version\n\t:references:reply-to:subject:subject:to:to:x-me-proxy\n\t:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1778531013; x=\n\t1778617413; bh=dtz2UrpL/ptITL8RY4B77zQklBI3B1hKmo+zo82NB3c=; b=P\n\tgnD6qYHYQs6G0cvBUssJ5mc65ROgb2xdl8afXS1XKuVLN4xJR6VrXzwdL+pu9FYP\n\t6zgSmUXRMaj/XeHJdIdSvHZ3aMa4tG1xuT3GHHewMV9YIx3Qgc2Z/iyxHqhbLZZb\n\tdagV4JWywdKWVv1n1qAq5y50RSE602alCgYg/Ugbhg5kuaj24SzHUdfI8UEBqZ1x\n\tb07Tizg7cDKy87cHEYjYkppauc9vYgWH8Wv003kGFGbZPuMUPnKwasyB4d+1t0EO\n\tKvuaaRb1x1/nwRRkiGUUfG6NhTS7sEHzwhiIZUEhhnrVay9btsdR6hpGVL/PlHCZ\n\tYJ8ZS3k9bg1FPTbaw7/VQ==" ], "X-ME-Sender": "<xms:xToCamGlqe2oh37Au5iBID4TF8mrSs-pyL5R5zhws0WX0g02S6Sffg>\n\t<xme:xToCaiJkywpinb_K5p9E5qqlkaCWKFtolJO3yirM3Jeph3Sl_VAFqk-a9iGUez-o2\n\tlLt2NYSEWcNBxcx314pa-LmvROzFJAWaQyF8Y59ZraM4RczQBt5zW10>", "X-ME-Proxy-Cause": "gggruggvucftvghtrhhoucdtuddrgeefhedrtddtgdduudelkeejucetufdoteggodetrf\n\tdotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu\n\trghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf\n\tgurhepoffhfffugggtgffkvfevofgjfhesthekredtredtjeenucfhrhhomheplfgrvhhi\n\tvghrucfvihgruceofhhlohhsshesjhgvthhmrdhmvgeqnecuggftrfgrthhtvghrnhepve\n\tektdfhffevuddtgfetieevtddvheduhfeggfekveejlefhleefieevueefiefhnecuvehl\n\tuhhsthgvrhfuihiivgepudenucfrrghrrghmpehmrghilhhfrhhomhepfhhlohhsshesjh\n\tgvthhmrdhmvgdpnhgspghrtghpthhtohepfedpmhhouggvpehsmhhtphhouhhtpdhrtghp\n\tthhtohepsggrrhhnrggsrghsrdhpohgtiigvsehiuggvrghsohhnsghorghrugdrtghomh\n\tdprhgtphhtthhopehlrghurhgvnhhtrdhpihhntghhrghrthesihguvggrshhonhgsohgr\n\trhgurdgtohhmpdhrtghpthhtoheplhhisggtrghmvghrrgdquggvvhgvlheslhhishhtsh\n\tdrlhhisggtrghmvghrrgdrohhrgh", "X-ME-Proxy": "<xmx:xToCavDX0gs7An_PO027sSwGoypWYDpUVy50cgBwUSZIC78X6_gbIA>\n\t<xmx:xToCatQU0pBYW5EkWVmbV8CgHiII-QLC2NEiNiDM70Gpvki5SsAZfQ>\n\t<xmx:xToCatrR-t3EYwF2lbpQVq3oK0ZlQePjg-R33CCOKlYZvzHigshaQg>\n\t<xmx:xToCavy23mfH7HOTFjClHmpTAUBxPZo4W2opNhHQpiYPI1f6_bW0mA>\n\t<xmx:xToCappkoh5jnoxZQlQIMpLizxyWyupt0qutSrYUj2Cx7AWKiC7amaMl>", "Feedback-ID": "i9dde48b3:Fastmail", "X-Mailer": [ "MessagingEngine.com Webmail Interface", "b4 0.15.2" ], "From": "Javier Tia <floss@jetm.me>", "Date": "Mon, 11 May 2026 14:23:29 -0600", "Subject": "[PATCH v3 2/2] libcamera: software_isp: Use Vector operator>>= in\n\tfinishFrame", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260511-libipa-vector-rshift-v3-2-a275f6e87ec4@jetm.me>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>, =?utf-8?q?Barnab?=\n\t=?utf-8?b?w6FzIFDFkWN6ZQ==?= <barnabas.pocze@ideasonboard.com>", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=1024; i=floss@jetm.me;\n\th=from:subject:message-id;\n\tbh=qa0MXKJoTMnIInZTz92a7r8y1F8xv2mxBKFbYifPdbE=; \n\tb=owEB7QES/pANAwAKAbXuwwuoZ3cfAcsmYgBqAjq/2moivWq38VddAFQVJjCTNTUyXYDHOMfbN\n\tJMLoYRalRuJAbMEAAEKAB0WIQSbE7ILzw7eI0VKk8m17sMLqGd3HwUCagI6vwAKCRC17sMLqGd3\n\tH/9qC/wK4+VyrxizAoknSHvyFKy7Y0TEMhscnRoudqXAAFeAW2Hberr/HY+k1bNrFrZevzmBWa8\n\tZV8yrfJbqhOuOtrXDHOzVNHvmQ0i8YGgIZ78il0zDiAsppTwzaUveChBaHUiB+CXFBTgRk/qRg+\n\tL5RH6Z5xlzdQkTLyklW5xsE31BDh0z580dB4B+puleLXQTmGq7Wfyn7+O0dJqtUJnM6jOuZNNqf\n\tMhq4Ir+DvilxixWjdL7HuUDYXIsjbLLWQsvU7gUwMGLnIM8ZS+hlnM7I3i19cjGxQF2z9xHwyxM\n\tQSWxd8A/UrpBrfm1DX+si5NLOsslQacf//OgQqmHS96h/2aPaFTdZdiaPd0LNQHtdYiWMzsXZsR\n\tUuL9LelfW4MsBuASxn+qYPHrZlc6tC6BuJ5RWTBbShb4wcRlZbr+FiHc8yM/ER2zmrzKSNsn9/v\n\tJRPCV/EaRhBjIr/EkvLvLVG3QA0myNn4kMphpZOmlkiUdxGjw2lmUIGa3wVSmsPrV1Nh4=", "X-Developer-Key": "i=floss@jetm.me; a=openpgp;\n\tfpr=9B13B20BCF0EDE23454A93C9B5EEC30BA867771F", "In-Reply-To": "<20260511-libipa-vector-rshift-v3-0-a275f6e87ec4@jetm.me>", "References": "<20260511-libipa-vector-rshift-v3-0-a275f6e87ec4@jetm.me>", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Replace the three per-component right-shift assignments with a single\nsum_ >>= sumShift_ call now that Vector provides the operator.\n\nSigned-off-by: Javier Tia <floss@jetm.me>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n src/libcamera/software_isp/swstats_cpu.cpp | 4 +---\n 1 file changed, 1 insertion(+), 3 deletions(-)", "diff": "diff --git a/src/libcamera/software_isp/swstats_cpu.cpp b/src/libcamera/software_isp/swstats_cpu.cpp\nindex 2e020e62..0815ec9a 100644\n--- a/src/libcamera/software_isp/swstats_cpu.cpp\n+++ b/src/libcamera/software_isp/swstats_cpu.cpp\n@@ -363,9 +363,7 @@ void SwStatsCpu::finishFrame(uint32_t frame, uint32_t bufferId)\n \t\t\t\tsharedStats_->yHistogram[j] += s.yHistogram[j];\n \t\t}\n \n-\t\tsharedStats_->sum_.r() >>= sumShift_;\n-\t\tsharedStats_->sum_.g() >>= sumShift_;\n-\t\tsharedStats_->sum_.b() >>= sumShift_;\n+\t\tsharedStats_->sum_ >>= sumShift_;\n \t}\n \n \tsharedStats_->valid = valid;\n", "prefixes": [ "v3", "2/2" ] }