Patch Detail
Show a patch.
GET /api/patches/26695/?format=api
{ "id": 26695, "url": "https://patchwork.libcamera.org/api/patches/26695/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26695/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260508-extensible-stats-v3-1-f2174ab4e124@ideasonboard.com>", "date": "2026-05-08T16:48:51", "name": "[v3,1/2] include: v4l2-isp: Update to support extensible stats", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "96f31155c00eb54ed7fefd584297059efcb1b15a", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26695/mbox/", "series": [ { "id": 5925, "url": "https://patchwork.libcamera.org/api/series/5925/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5925", "date": "2026-05-08T16:48:50", "name": "ipa: libipa: Add support for V4L2 ISP statistics", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5925/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26695/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26695/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A394FBE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 8 May 2026 16:49:04 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DB2956302B;\n\tFri, 8 May 2026 18:49:01 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E0D4362FD3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 8 May 2026 18:48:59 +0200 (CEST)", "from [192.168.1.7] (net-93-65-100-155.cust.vodafonedsl.it\n\t[93.65.100.155])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BE17313BE;\n\tFri, 8 May 2026 18:48:54 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"J3g7fQCq\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1778258934;\n\tbh=eQnNTTlpzLv5JKLf2Jmscdmml78NL0b90WPZR/XJaIg=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=J3g7fQCqwShKpV9yRbicBNfOxbbF5+9mk5nkbNtnjshaSIqQD2RUsoJHAY9g3zyJ0\n\tpkWunhR+w++QVeyhcPvii05zjNl4W/V24xUqVJ4Q8ekDLuQ/IYxk2n9CSKGlRG4i2F\n\tsEJuaZLBZWKdR/xarKeQPc3tGoDSAZ7ZL5WO4BAo=", "From": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Date": "Fri, 08 May 2026 18:48:51 +0200", "Subject": "[PATCH v3 1/2] include: v4l2-isp: Update to support extensible stats", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20260508-extensible-stats-v3-1-f2174ab4e124@ideasonboard.com>", "References": "<20260508-extensible-stats-v3-0-f2174ab4e124@ideasonboard.com>", "In-Reply-To": "<20260508-extensible-stats-v3-0-f2174ab4e124@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org, \n\tAntoine Bouyer <antoine.bouyer@nxp.com>", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>, \n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "X-Mailer": "b4 0.14.3", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=8888;\n\ti=jacopo.mondi@ideasonboard.com; h=from:subject:message-id;\n\tbh=eQnNTTlpzLv5JKLf2Jmscdmml78NL0b90WPZR/XJaIg=;\n\tb=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBp/hP6jLHKeB4nHtd7b5lGqoVY2/GuJFMHT/Gjc\n\tjc/gWiqms+JAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCaf4T+gAKCRByNAaPFqFW\n\tPKnFEACNW9ntPuXTiUV+M13uwDqVf4FxLGNmfarkfzkqZLmrbuDVbSlfbERPwrOdL+5paOHWs22\n\tirfKdrvby/dbT1Wq7Z2JFdQuf84ncxndyoNVi5H9/4AUWvaut8BNiV1TCOVSauNzZO4/aonTW2X\n\t9qEBPxqhdivfPx/mjBXRc0b0+qthpmY4O0WNdtF/Whhf/L23nqKxfgEpJcNxtp05MGHI26Q6zef\n\tAolzD0DI1rY6bGwe/jmok6CLVr5fd6ePnnNqTJkX70qhB6trCzbq6c8rfGiKUopwWKxnHtlBMrj\n\tzJqOvfLIgLFdsKWu9xUzeBBDnsdmj1Y1Lm28Zhc2/QJ5/naKzQxT6yZ3MP62X/d4NOdxQpZ86Yi\n\tT5dYtbQOOIPGXOkI3CcMOsR11AiCqgjRy+pMj+wWdpjwhhLuCLyucyMnqtajZPfMiFdbtXQSPcu\n\tcpOHsSqguN8vP+nIbXFF7mDC4hLYvGyyTeaEDOM1yaxstU1vHjCRNdizHIEzuUh4aKe4VoWxh+0\n\txrqCMjUxPcH1Secz6vw0K21TJhVtN/MvyWBTJe7NBHlfcv4B1yP48EsKbeprFK6ASDRxDiWLUl0\n\twkEHWqAKuDwCbHdBnia6S1w5mnukoNf61218LqJx44IetH9y3iNXNneokQSf4WnE3vTIpftYi3K\n\tBARkTOeV9/li9UQ==", "X-Developer-Key": "i=jacopo.mondi@ideasonboard.com; a=openpgp;\n\tfpr=72392EDC88144A65C701EA9BA5826A2587AD026B", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Update the v4l2-isp.h header to prepare to support extensible\nstatistics.\n\nThe new header version is generated from the following in-review\npatch series:\nhttps://patchwork.linuxtv.org/project/linux-media/patch/20260505-extensible-stats-v1-1-e16f326b8dad@ideasonboard.com/\n\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\nAcked-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n include/linux/media/v4l2-isp.h | 125 ++++++++++++++++++++++++++---------------\n 1 file changed, 79 insertions(+), 46 deletions(-)", "diff": "diff --git a/include/linux/media/v4l2-isp.h b/include/linux/media/v4l2-isp.h\nindex 0cfc4ab94967..60a716177d52 100644\n--- a/include/linux/media/v4l2-isp.h\n+++ b/include/linux/media/v4l2-isp.h\n@@ -13,25 +13,33 @@\n #include <linux/types.h>\n \n /**\n- * enum v4l2_isp_params_version - V4L2 ISP parameters versioning\n+ * enum v4l2_isp_version - V4L2 ISP serialization format versioning\n *\n- * @V4L2_ISP_PARAMS_VERSION_V0: First version of the V4L2 ISP parameters format\n- *\t\t\t\t(for compatibility)\n- * @V4L2_ISP_PARAMS_VERSION_V1: First version of the V4L2 ISP parameters format\n+ * @V4L2_ISP_VERSION_V0: First version of the V4L2 ISP serialization format\n+ * (for compatibility)\n+ * @V4L2_ISP_VERSION_V1: First version of the V4L2 ISP serialization format\n *\n * V0 and V1 are identical in order to support drivers compatible with the V4L2\n- * ISP parameters format already upstreamed which use either 0 or 1 as their\n- * versioning identifier. Both V0 and V1 refers to the first version of the\n- * V4L2 ISP parameters format.\n+ * ISP format already upstreamed which use either 0 or 1 as their versioning\n+ * identifier. Both V0 and V1 refers to the first version of the V4L2 ISP\n+ * serialization format.\n *\n- * Future revisions of the V4L2 ISP parameters format should start from the\n+ * Future revisions of the V4L2 ISP serialization format should start from the\n * value of 2.\n */\n-enum v4l2_isp_params_version {\n-\tV4L2_ISP_PARAMS_VERSION_V0 = 0,\n-\tV4L2_ISP_PARAMS_VERSION_V1\n+enum v4l2_isp_version {\n+\tV4L2_ISP_VERSION_V0 = 0,\n+\tV4L2_ISP_VERSION_V1\n };\n \n+/*\n+ * Compatibility with existing users of v4l2_isp_params which pre-date the\n+ * introduction of v4l2_isp_stats.\n+ */\n+#define v4l2_isp_params_version\t\t\tv4l2_isp_version\n+#define V4L2_ISP_PARAMS_VERSION_V0\t\tV4L2_ISP_VERSION_V0\n+#define V4L2_ISP_PARAMS_VERSION_V1\t\tV4L2_ISP_VERSION_V1\n+\n #define V4L2_ISP_PARAMS_FL_BLOCK_DISABLE\t(1U << 0)\n #define V4L2_ISP_PARAMS_FL_BLOCK_ENABLE\t\t(1U << 1)\n \n@@ -39,64 +47,89 @@ enum v4l2_isp_params_version {\n * Reserve the first 8 bits for V4L2_ISP_PARAMS_FL_* flag.\n *\n * Driver-specific flags should be defined as:\n- * #define DRIVER_SPECIFIC_FLAG0 ((1U << V4L2_ISP_PARAMS_FL_DRIVER_FLAGS(0))\n- * #define DRIVER_SPECIFIC_FLAG1 ((1U << V4L2_ISP_PARAMS_FL_DRIVER_FLAGS(1))\n+ * #define DRIVER_SPECIFIC_FLAG0 ((1U << V4L2_ISP_FL_DRIVER_FLAGS(0))\n+ * #define DRIVER_SPECIFIC_FLAG1 ((1U << V4L2_ISP_FL_DRIVER_FLAGS(1))\n */\n-#define V4L2_ISP_PARAMS_FL_DRIVER_FLAGS(n) ((n) + 8)\n+#define V4L2_ISP_FL_DRIVER_FLAGS(n)\t\t((n) + 8)\n \n /**\n- * struct v4l2_isp_params_block_header - V4L2 extensible parameters block header\n- * @type: The parameters block type (driver-specific)\n+ * struct v4l2_isp_block_header - V4L2 extensible block header\n+ * @type: The parameters or statistics block type (driver-specific)\n * @flags: A bitmask of block flags (driver-specific)\n- * @size: Size (in bytes) of the parameters block, including this header\n+ * @size: Size (in bytes) of the block, including this header\n *\n- * This structure represents the common part of all the ISP configuration\n- * blocks. Each parameters block shall embed an instance of this structure type\n- * as its first member, followed by the block-specific configuration data.\n+ * This structure represents the common part of all the ISP configuration or\n+ * statistic blocks. Each block shall embed an instance of this structure type\n+ * as its first member, followed by the block-specific configuration or\n+ * statistic data.\n *\n * The @type field is an ISP driver-specific value that identifies the block\n- * type. The @size field specifies the size of the parameters block.\n+ * type. The @size field specifies the size of the block, including this\n+ * header.\n *\n- * The @flags field is a bitmask of per-block flags V4L2_PARAMS_ISP_FL_* and\n- * driver-specific flags specified by the driver header.\n+ * The @flags field is a bitmask of per-block flags. If a block is used for\n+ * configuration parameters this field can be a combination of\n+ * V4L2_ISP_PARAMS_FL_* and driver-specific flags. If a block is used\n+ * for statistics this fields is used to report optional\n+ * driver-specific flags, if any.\n */\n-struct v4l2_isp_params_block_header {\n+struct v4l2_isp_block_header {\n \t__u16 type;\n \t__u16 flags;\n \t__u32 size;\n } __attribute__((aligned(8)));\n \n /**\n- * struct v4l2_isp_params_buffer - V4L2 extensible parameters configuration\n- * @version: The parameters buffer version (driver-specific)\n- * @data_size: The configuration data effective size, excluding this header\n- * @data: The configuration data\n+ * v4l2_isp_params_block_header - V4L2 extensible parameters block header\n+ *\n+ * Compatibility with existing users of v4l2_isp_params_block_header\n+ * which pre-date the introduction of v4l2_isp_block_header.\n+ */\n+#define v4l2_isp_params_block_header v4l2_isp_block_header\n+\n+/**\n+ * struct v4l2_isp_buffer - V4L2 extensible buffer\n+ * @version: The extensible buffer version (driver-specific)\n+ * @data_size: The data effective size, excluding this header\n+ * @data: The configuration or statistics data\n *\n- * This structure contains the configuration parameters of the ISP algorithms,\n- * serialized by userspace into a data buffer. Each configuration parameter\n- * block is represented by a block-specific structure which contains a\n- * :c:type:`v4l2_isp_params_block_header` entry as first member. Userspace\n- * populates the @data buffer with configuration parameters for the blocks that\n- * it intends to configure. As a consequence, the data buffer effective size\n- * changes according to the number of ISP blocks that userspace intends to\n- * configure and is set by userspace in the @data_size field.\n+ * This structure contains ISP configuration parameters or ISP hardware\n+ * statistics serialized into a data buffer. Each block is represented by a\n+ * block-specific structure which contains a :c:type:`v4l2_isp_block_header`\n+ * entry as first member.\n *\n- * The parameters buffer is versioned by the @version field to allow modifying\n- * and extending its definition. Userspace shall populate the @version field to\n- * inform the driver about the version it intends to use. The driver will parse\n- * and handle the @data buffer according to the data layout specific to the\n- * indicated version and return an error if the desired version is not\n+ * When used for ISP parameters, userspace populates the @data buffer with\n+ * configuration parameters for the blocks that it intends to configure. As a\n+ * consequence, the data buffer effective size changes according to the number\n+ * of ISP blocks that userspace intends to configure.\n+ *\n+ * When used to report ISP statistics, the driver populates the @data buffer\n+ * with statistics for each supported measurement block.\n+ *\n+ * The buffer is versioned by the @version field to allow modifying\n+ * and extending its definition. The writer shall populate the @version field\n+ * to inform the reader about the version it intends to use. The reader will\n+ * parse and handle the @data buffer according to the data layout specific to\n+ * the indicated version and return an error if the desired version is not\n * supported.\n *\n- * For each ISP block that userspace wants to configure, a block-specific\n- * structure is appended to the @data buffer, one after the other without gaps\n- * in between. Userspace shall populate the @data_size field with the effective\n- * size, in bytes, of the @data buffer.\n+ * For each ISP block, a block-specific structure is appended to the @data\n+ * buffer, one after the other without gaps in between. The writer shall\n+ * populate the @data_size field with the effective size, in bytes, of the\n+ * @data buffer.\n */\n-struct v4l2_isp_params_buffer {\n+struct v4l2_isp_buffer {\n \t__u32 version;\n \t__u32 data_size;\n \t__u8 data[] __counted_by(data_size);\n };\n \n+/**\n+ * v4l2_isp_params_buffer - V4L2 extensible parameters compatibility\n+ *\n+ * Compatibility with existing users of v4l2_isp_params_buffer which\n+ * pre-date the introduction of v4l2_isp_buffer.\n+ */\n+#define v4l2_isp_params_buffer v4l2_isp_buffer\n+\n #endif /* _V4L2_ISP_H_ */\n", "prefixes": [ "v3", "1/2" ] }