Patch Detail
Show a patch.
GET /api/patches/26688/?format=api
{ "id": 26688, "url": "https://patchwork.libcamera.org/api/patches/26688/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26688/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260508092816.119642-2-barnabas.pocze@ideasonboard.com>", "date": "2026-05-08T09:28:16", "name": "[v1,2/2] libcamera: base: bound_method: Forward when invoking", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "7d97fc8fdf725559ace11900ad6cac4627b60e3f", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26688/mbox/", "series": [ { "id": 5922, "url": "https://patchwork.libcamera.org/api/series/5922/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5922", "date": "2026-05-08T09:28:15", "name": "[v1,1/2] libcamera: base: bound_method: Strip qualifiers in argument pack", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5922/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26688/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26688/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1F6ECBE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 8 May 2026 09:28:23 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 76C686301E;\n\tFri, 8 May 2026 11:28:21 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8131562FE8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 8 May 2026 11:28:19 +0200 (CEST)", "from pb-laptop.local (185.221.140.217.nat.pool.zt.hu\n\t[185.221.140.217])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B221313BE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 8 May 2026 11:28:14 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"oWBAFuG4\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1778232494;\n\tbh=LK5dZHDmfWjbprygBqFvbB+gTN/Gi7GkAcu9cNMN6r8=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=oWBAFuG4q16QKwz/vro/Aythdn7Rx5v0dg/k+AYGHfEs3zUKKOlecPkIovoW1biWA\n\tzKCEJC/+e0MTggWrVJuiWp/wV1lPJZ/FJMGIaPBhZ6h4kIn80rBvJKHkaLCKo35EzW\n\t0bpvByFDySnwT4861uRifI2m9XizHZ8VKZmNpvB0=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v1 2/2] libcamera: base: bound_method: Forward when invoking", "Date": "Fri, 8 May 2026 11:28:16 +0200", "Message-ID": "<20260508092816.119642-2-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.54.0", "In-Reply-To": "<20260508092816.119642-1-barnabas.pocze@ideasonboard.com>", "References": "<20260508092816.119642-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This implements the same kind of change for pack-based invoking as 9c86a405b72a\n(\"libcamera: base: bound_method: Forward arguments when possible\") did for the\nother cases.\n\nAt the moment a single argument pack is used just once, hence it is safe\nto forward the arguments from the pack, allowing moving to take place\ninstead of copying. So do that.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n include/libcamera/base/bound_method.h | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/include/libcamera/base/bound_method.h b/include/libcamera/base/bound_method.h\nindex cb642e0a9b..9b42a8a1e8 100644\n--- a/include/libcamera/base/bound_method.h\n+++ b/include/libcamera/base/bound_method.h\n@@ -97,9 +97,9 @@ private:\n \t\t[[maybe_unused]] auto *args = static_cast<PackType *>(pack);\n \n \t\tif constexpr (!std::is_void_v<R>)\n-\t\t\targs->ret_ = invoke(std::get<I>(args->args_)...);\n+\t\t\targs->ret_ = invoke(std::forward<Args>(std::get<I>(args->args_))...);\n \t\telse\n-\t\t\tinvoke(std::get<I>(args->args_)...);\n+\t\t\tinvoke(std::forward<Args>(std::get<I>(args->args_))...);\n \t}\n \n public:\n", "prefixes": [ "v1", "2/2" ] }