Patch Detail
Show a patch.
GET /api/patches/26678/?format=api
{ "id": 26678, "url": "https://patchwork.libcamera.org/api/patches/26678/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26678/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260507-kbingham-simple-scaler-crop-v1-1-7a5af1948565@ideasonboard.com>", "date": "2026-05-07T15:25:33", "name": "[1/2] pipeline: simple: Report ScalerCropMaximum camera property", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "530eecd8b312b139ec39c0f30b2cd516f82beb60", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26678/mbox/", "series": [ { "id": 5919, "url": "https://patchwork.libcamera.org/api/series/5919/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5919", "date": "2026-05-07T15:25:32", "name": "pipeline: simple: Add ScalerCrop reporting", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5919/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26678/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26678/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8AE69C32F6\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 7 May 2026 15:25:44 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F125662FEC;\n\tThu, 7 May 2026 17:25:42 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8706462FEC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 7 May 2026 17:25:40 +0200 (CEST)", "from ping.linuxembedded.co.uk\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 31A569CE;\n\tThu, 7 May 2026 17:25:36 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"vFEgevxW\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1778167536;\n\tbh=kkfDVlBkpeOaZhtjuTuzPlCDhaYwqFiu2UrRjJFCIek=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=vFEgevxWUgQaaCU0vl9aXlaCEnTeAs2IXM45Iskk4ZBFhyQchEbf2jQhMnTIpL+vD\n\t2jX7TWSjKnqHvXTSVXddNBkHs67CNNLq9x9OfmUfMFku/LyiHkSqpqa3Lc3GKp2L5g\n\tzOO7vtGhewQSAIZNtnEYPKd6yQ8haZbCC7aZ7FXo=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "Date": "Thu, 07 May 2026 16:25:33 +0100", "Subject": "[PATCH 1/2] pipeline: simple: Report ScalerCropMaximum camera\n\tproperty", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20260507-kbingham-simple-scaler-crop-v1-1-7a5af1948565@ideasonboard.com>", "References": "<20260507-kbingham-simple-scaler-crop-v1-0-7a5af1948565@ideasonboard.com>", "In-Reply-To": "<20260507-kbingham-simple-scaler-crop-v1-0-7a5af1948565@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "X-Mailer": "b4 0.14.3", "X-Developer-Signature": "v=1; a=ed25519-sha256; t=1778167539; l=1351;\n\ti=kieran.bingham@ideasonboard.com; s=20260207;\n\th=from:subject:message-id; \n\tbh=kkfDVlBkpeOaZhtjuTuzPlCDhaYwqFiu2UrRjJFCIek=;\n\tb=R+p9maN8PE0q10jTFERf8Xpg/MFtOb9i/xSrvu1SFYMhzBxmIao/wToyaGq+Ggz9lSmhlELGP\n\tDNVyjFeNMmUAd48atI2P5xhsONygA9R1jrcqQ0x8AscTcrMASvksqmR", "X-Developer-Key": "i=kieran.bingham@ideasonboard.com; a=ed25519;\n\tpk=FVXKN7YuwHc6UtbRUeTMAmranfsQomA+vnilfglWdaY=", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Even without a specific scaler, this gives the application information about\nthe rectangle that conveys the pixels being displayed in the mode.\n\nProvide the analog crop region to the camera properties.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/pipeline/simple/simple.cpp | 8 ++++++++\n 1 file changed, 8 insertions(+)", "diff": "diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex c6fe12d65b18..ee394c567a2c 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -30,6 +30,7 @@\n #include <libcamera/control_ids.h>\n #include <libcamera/geometry.h>\n #include <libcamera/pixel_format.h>\n+#include <libcamera/property_ids.h>\n #include <libcamera/stream.h>\n \n #include \"libcamera/internal/camera.h\"\n@@ -1523,6 +1524,13 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c)\n \tif (ret < 0)\n \t\treturn ret;\n \n+\tIPACameraSensorInfo sensorInfo;\n+\tret = data->sensor_->sensorInfo(&sensorInfo);\n+\tif (ret)\n+\t\treturn ret;\n+\n+\tdata->properties_.set(properties::ScalerCropMaximum, sensorInfo.analogCrop);\n+\n \t/* Configure the video node, taking into account any Bayer pattern change. */\n \tV4L2PixelFormat videoFormat;\n \tif (format.code == pipeConfig->code) {\n", "prefixes": [ "1/2" ] }