Patch Detail
Show a patch.
GET /api/patches/26664/?format=api
{ "id": 26664, "url": "https://patchwork.libcamera.org/api/patches/26664/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26664/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260506230722.1041596-8-devve.3@gmail.com>", "date": "2026-05-06T23:07:19", "name": "[v2,07/10] ipa: libipa: camera_sensor_helper: Add OV2740 black level", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "4ff72347bdad59109aafa386d315d1355d718838", "submitter": { "id": 271, "url": "https://patchwork.libcamera.org/api/people/271/?format=api", "name": "devve", "email": "devve.3@gmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26664/mbox/", "series": [ { "id": 5915, "url": "https://patchwork.libcamera.org/api/series/5915/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5915", "date": "2026-05-06T23:07:12", "name": "OV01A10 sensor support and simple IPA improvements", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5915/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26664/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26664/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D4D9CC3304\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 6 May 2026 23:07:40 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8C10A6303C;\n\tThu, 7 May 2026 01:07:38 +0200 (CEST)", "from mail-qk1-x736.google.com (mail-qk1-x736.google.com\n\t[IPv6:2607:f8b0:4864:20::736])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CBF0963024\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 7 May 2026 01:07:34 +0200 (CEST)", "by mail-qk1-x736.google.com with SMTP id\n\taf79cd13be357-8f0a87e23daso21937785a.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 06 May 2026 16:07:34 -0700 (PDT)", "from dexps.speedport.ip\n\t(p200300eda74453cf3cf3f7929e513b94.dip0.t-ipconnect.de.\n\t[2003:ed:a744:53cf:3cf3:f792:9e51:3b94])\n\tby smtp.gmail.com with ESMTPSA id\n\taf79cd13be357-8fc2c25324esm2035266385a.23.2026.05.06.16.07.32\n\tfor <libcamera-devel@lists.libcamera.org>\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 06 May 2026 16:07:33 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"fxaxeS4g\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20251104; t=1778108854; x=1778713654;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:to:from:from:to:cc:subject:date:message-id\n\t:reply-to; bh=hUmrEbZjTFn8jTOOzmHe5n0FPgz7UNB05AkPrRPSWF8=;\n\tb=fxaxeS4gQWIFAmA/cKbbh5gEZUQ/TZrb/pfjCPQx2UvvxWp+5OkjiVBFW+r5UmwYp9\n\t0gVBgk410p4Aneq76fz97VkK2aJRNsswRd1rBu0DM5h/5YT4Q//Jcm/D9P+PdtzZ97Lc\n\t1ltLXG50YXQXkAXu28ZyjaIOdGt6hpcsyl65ghtFp4y8vTnjFHmOXxKDBSjg9fGIvKrl\n\tHODqorsHHSlMcf49WzEmNa+mQIDFzgALdTcrBnNHroX1O6gxIBtr0XAbCV0XUWmkCeyN\n\tdF8RInoriZt21Xa3ScbLQErJa/EUyrOG+CbpkR3n5ml+I+ZKymaEQLXpeJB7mlEuuyy4\n\tWKaQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20251104; t=1778108854; x=1778713654;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to\n\t:cc:subject:date:message-id:reply-to;\n\tbh=hUmrEbZjTFn8jTOOzmHe5n0FPgz7UNB05AkPrRPSWF8=;\n\tb=nruXAQpphwKceXdGTYbU0xJlhWH/w+dSlKi+6V8HIEHu6JIGSsehtrPCrT5sSvCKIs\n\tEEmqLaefhg5+jUV5Fq3OV7A5Ace4tWlR1ra9a4p5/eMBak/cnYPWAaoqLYJUIoT1lgRc\n\tKc5EIWYuVG8JSpCsJ1Cstsfpo3L4+Gcc1Xptje6dNl/l/msoKCp8JTQWUq+/15oZcW9N\n\t1pKDttIShv6xK31kE3qgWLOLW6EJPeqcntWslHDhzJLMaj54StmEPhToxiJVBRRRirTr\n\tBaF7ik+zj2erVQUNnlxmal6ONHcwv0W9RpCmK1mxzpCSKC6voqv2tjuLc67894ObvfbW\n\tBdzg==", "X-Gm-Message-State": "AOJu0YwVpPKya4dXeSTZlwwepePJnLhL73OTOXCa7xEpP9Br/n3jn2iC\n\tcg6Ucqkt/j/YK/ipUhuNAqSzb2wbNnUpCqvJgGSjRJ9zDGjKDoptloC3JF2U7A==", "X-Gm-Gg": "AeBDietG2I5aRCDQPPsP3O1uxiwtQDgWDgV83icKZA65FuAYN6kLe+fJCb7x1XXMxua\n\txMvy1F2Z6fBzn7fWgmIAt1I2YxF7jyPKuNM6DqcRWGgSAO25Ox5gTIeQlTaFZCZg1s6gQYfvEWZ\n\t9DbnO7nS9VnVPLJr6PPWi05rEJ4kH2vUWZjObGDTgjHD6EC0lvBpGg01h6o0vfgdTUl6V4fHA2Q\n\tL1W5BlqdoPcWNmO/wQa1Gmuf3GYaDkA+PHA5wRn3Dihx8ft9ovU9bYHRDPG9rE83lCXWV9ZTImv\n\t8PusrMxtiCAD7MZdagYskzjtUbMHMfp14nYxSJtvyHtHNuw5bqPR7FXWXmee6OIo88eWcdKvwH2\n\tDub5HKRkMdeBggz4yp0DOOKtunuLzCnz5HwOK6sBr7LRpwA9Dw/ZVTbZHmPGc6oZ1liLVJ/tiAx\n\tpupra+5mgC5cN7qAmlK4KsNey+YJurZ7f6gz9lO8USNcHr5Ve5cWJ2dkOaKaAQYABZStkkmG+o/\n\t2MOF6RBumC2EzkzX/Rm5UqmvYNfDheO20TZ3Wtarkg=", "X-Received": "by 2002:a05:620a:29c1:b0:8eb:f3c7:2246 with SMTP id\n\taf79cd13be357-904d60f60e3mr886020185a.35.1778108853719; \n\tWed, 06 May 2026 16:07:33 -0700 (PDT)", "From": "d3vv3 <devve.3@gmail.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v2 07/10] ipa: libipa: camera_sensor_helper: Add OV2740 black\n\tlevel", "Date": "Thu, 7 May 2026 01:07:19 +0200", "Message-ID": "<20260506230722.1041596-8-devve.3@gmail.com>", "X-Mailer": "git-send-email 2.54.0", "In-Reply-To": "<20260506230722.1041596-1-devve.3@gmail.com>", "References": "<20260506230722.1041596-1-devve.3@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Javier Tia <floss@jetm.me>\n\nSet blackLevel_ = 4096 (0x40 at 10-bit) in CameraSensorHelperOv2740.\nThe OV2740 kernel driver programs BLC target register 0x4003 with 0x40\nfor the 180 MHz link frequency mode. This matches the same pattern\nused by OV5675 and other OmniVision sensors with a 10-bit black level\nof 64.\n\nWithout this, the Simple pipeline falls back to auto-guessing the\nblack level, which happens to arrive at the same value but isn't\ndocumented. More importantly, the CameraSensorHelper is the canonical\nlocation for sensor calibration data and is used across all pipeline\nhandlers, not just Simple.\n\nSuggested-by: Robert Mader <robert.mader@collabora.com>\nSigned-off-by: Javier Tia <floss@jetm.me>\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nSigned-off-by: d3vv3 <devve.3@gmail.com>\n---\n src/ipa/libipa/camera_sensor_helper.cpp | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\nindex 72466867..f3e8d7c8 100644\n--- a/src/ipa/libipa/camera_sensor_helper.cpp\n+++ b/src/ipa/libipa/camera_sensor_helper.cpp\n@@ -684,6 +684,8 @@ class CameraSensorHelperOv2740 : public CameraSensorHelper\n public:\n \tCameraSensorHelperOv2740()\n \t{\n+\t\t/* From Linux kernel driver: 0x40 at 10bits. */\n+\t\tblackLevel_ = 4096;\n \t\tgain_ = AnalogueGainLinear{ 1, 0, 0, 128 };\n \t}\n };\n", "prefixes": [ "v2", "07/10" ] }