Patch Detail
Show a patch.
GET /api/patches/26639/?format=api
{ "id": 26639, "url": "https://patchwork.libcamera.org/api/patches/26639/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26639/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260506091744.53006-1-mzamazal@redhat.com>", "date": "2026-05-06T09:17:44", "name": "[v2] libcamera: software_isp: #include cleanup", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "a8513305fae9990e55874960f06f269cb58d7aa1", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26639/mbox/", "series": [ { "id": 5909, "url": "https://patchwork.libcamera.org/api/series/5909/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5909", "date": "2026-05-06T09:17:44", "name": "[v2] libcamera: software_isp: #include cleanup", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5909/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26639/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26639/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C22E2BE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 6 May 2026 09:17:56 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 892D962FE8;\n\tWed, 6 May 2026 11:17:55 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A5EA462FE1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 6 May 2026 11:17:53 +0200 (CEST)", "from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-16-bhR6EhPBNSair3iTB26mzw-1;\n\tWed, 06 May 2026 05:17:49 -0400", "from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.111])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 3830E19560A3; Wed, 6 May 2026 09:17:48 +0000 (UTC)", "from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.49.240])\n\tby mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id DE4791803A8E; Wed, 6 May 2026 09:17:46 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"Ix2v51WL\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1778059072;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding;\n\tbh=OZIFNMc+g6IVL5ck58/ERuW7uNMuJsD76/0KcrgIEC8=;\n\tb=Ix2v51WLKLuuyXS6pB4MIIT8HIpc6qj8/TBsEe2R6/DxIWVZPuzqLaja5oFH1DEj7RdolY\n\tAn6Mz4CNetafsigR4tIJuaEwVjvLds7LOe1AiS33BE/mQEQIHgGdMIp++x2Z6Qoj64babO\n\trJPbVNBbo1uT1EUAskzcFmhVRDogJuA=", "X-MC-Unique": "bhR6EhPBNSair3iTB26mzw-1", "X-Mimecast-MFC-AGG-ID": "bhR6EhPBNSair3iTB26mzw_1778059068", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>", "Subject": "[PATCH v2] libcamera: software_isp: #include cleanup", "Date": "Wed, 6 May 2026 11:17:44 +0200", "Message-ID": "<20260506091744.53006-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.111", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "koZieg4FM4_gLbeg1OKZDlaMf3_OG_blg5zH3JpODUg_1778059068", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Remove unused #include's, move improper ones and add missing ones.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n include/libcamera/internal/software_isp/software_isp.h | 1 -\n include/libcamera/internal/software_isp/swstats_cpu.h | 2 +-\n src/libcamera/software_isp/debayer_cpu.cpp | 1 +\n src/libcamera/software_isp/debayer_cpu.h | 3 ++-\n src/libcamera/software_isp/debayer_egl.cpp | 9 +++++++--\n src/libcamera/software_isp/debayer_egl.h | 3 +--\n src/libcamera/software_isp/software_isp.cpp | 4 +++-\n 7 files changed, 15 insertions(+), 8 deletions(-)", "diff": "diff --git a/include/libcamera/internal/software_isp/software_isp.h b/include/libcamera/internal/software_isp/software_isp.h\nindex 585e0d6d9..86cb8f8de 100644\n--- a/include/libcamera/internal/software_isp/software_isp.h\n+++ b/include/libcamera/internal/software_isp/software_isp.h\n@@ -9,7 +9,6 @@\n \n #include <deque>\n #include <functional>\n-#include <initializer_list>\n #include <map>\n #include <memory>\n #include <stdint.h>\ndiff --git a/include/libcamera/internal/software_isp/swstats_cpu.h b/include/libcamera/internal/software_isp/swstats_cpu.h\nindex 802370bdb..1f8873818 100644\n--- a/include/libcamera/internal/software_isp/swstats_cpu.h\n+++ b/include/libcamera/internal/software_isp/swstats_cpu.h\n@@ -16,10 +16,10 @@\n \n #include <libcamera/base/signal.h>\n \n+#include <libcamera/framebuffer.h>\n #include <libcamera/geometry.h>\n \n #include \"libcamera/internal/bayer_format.h\"\n-#include \"libcamera/internal/framebuffer.h\"\n #include \"libcamera/internal/shared_mem_object.h\"\n #include \"libcamera/internal/software_isp/swisp_stats.h\"\n \ndiff --git a/src/libcamera/software_isp/debayer_cpu.cpp b/src/libcamera/software_isp/debayer_cpu.cpp\nindex d9f5b3268..1f9b24da0 100644\n--- a/src/libcamera/software_isp/debayer_cpu.cpp\n+++ b/src/libcamera/software_isp/debayer_cpu.cpp\n@@ -23,6 +23,7 @@\n #include <libcamera/formats.h>\n \n #include \"libcamera/internal/bayer_format.h\"\n+#include \"libcamera/internal/camera_manager.h\"\n #include \"libcamera/internal/framebuffer.h\"\n #include \"libcamera/internal/global_configuration.h\"\n #include \"libcamera/internal/mapped_framebuffer.h\"\ndiff --git a/src/libcamera/software_isp/debayer_cpu.h b/src/libcamera/software_isp/debayer_cpu.h\nindex 8c58775d5..68da95083 100644\n--- a/src/libcamera/software_isp/debayer_cpu.h\n+++ b/src/libcamera/software_isp/debayer_cpu.h\n@@ -18,8 +18,9 @@\n #include <libcamera/base/mutex.h>\n #include <libcamera/base/object.h>\n \n+#include <libcamera/camera_manager.h>\n+\n #include \"libcamera/internal/bayer_format.h\"\n-#include \"libcamera/internal/camera_manager.h\"\n #include \"libcamera/internal/software_isp/debayer_params.h\"\n #include \"libcamera/internal/software_isp/swstats_cpu.h\"\n \ndiff --git a/src/libcamera/software_isp/debayer_egl.cpp b/src/libcamera/software_isp/debayer_egl.cpp\nindex 8f0c229fd..eae4c57f4 100644\n--- a/src/libcamera/software_isp/debayer_egl.cpp\n+++ b/src/libcamera/software_isp/debayer_egl.cpp\n@@ -9,14 +9,19 @@\n \n #include \"debayer_egl.h\"\n \n-#include <cmath>\n+#include <algorithm>\n+#include <memory>\n #include <stdlib.h>\n-#include <time.h>\n+#include <string>\n+#include <tuple>\n+#include <vector>\n \n #include <libcamera/base/utils.h>\n \n #include <libcamera/formats.h>\n \n+#include \"libcamera/internal/framebuffer.h\"\n+\n #include \"../glsl_shaders.h\"\n \n namespace libcamera {\ndiff --git a/src/libcamera/software_isp/debayer_egl.h b/src/libcamera/software_isp/debayer_egl.h\nindex fcd281f4c..141fb288f 100644\n--- a/src/libcamera/software_isp/debayer_egl.h\n+++ b/src/libcamera/software_isp/debayer_egl.h\n@@ -11,15 +11,14 @@\n \n #include <memory>\n #include <stdint.h>\n+#include <tuple>\n #include <vector>\n \n #define GL_GLEXT_PROTOTYPES\n #define EGL_EGLEXT_PROTOTYPES\n #include <libcamera/base/object.h>\n \n-#include \"libcamera/internal/bayer_format.h\"\n #include \"libcamera/internal/egl.h\"\n-#include \"libcamera/internal/framebuffer.h\"\n #include \"libcamera/internal/mapped_framebuffer.h\"\n #include \"libcamera/internal/software_isp/benchmark.h\"\n #include \"libcamera/internal/software_isp/swstats_cpu.h\"\ndiff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\nindex d227bd8e3..781cf02f8 100644\n--- a/src/libcamera/software_isp/software_isp.cpp\n+++ b/src/libcamera/software_isp/software_isp.cpp\n@@ -7,8 +7,10 @@\n \n #include \"libcamera/internal/software_isp/software_isp.h\"\n \n-#include <cmath>\n+#include <memory>\n+#include <optional>\n #include <stdint.h>\n+#include <string>\n #include <sys/mman.h>\n #include <sys/types.h>\n #include <unistd.h>\n", "prefixes": [ "v2" ] }