Patch Detail
Show a patch.
GET /api/patches/2659/?format=api
{ "id": 2659, "url": "https://patchwork.libcamera.org/api/patches/2659/?format=api", "web_url": "https://patchwork.libcamera.org/patch/2659/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200117145802.3322874-2-helen.koike@collabora.com>", "date": "2020-01-17T14:58:02", "name": "[libcamera-devel,v2,2/2] utils: rkisp1: sync topology with upstream driver in capture script", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "f76fd5368aae95f180041d98059121e68f0e707e", "submitter": { "id": 20, "url": "https://patchwork.libcamera.org/api/people/20/?format=api", "name": "Helen Koike", "email": "helen.koike@collabora.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/2659/mbox/", "series": [ { "id": 633, "url": "https://patchwork.libcamera.org/api/series/633/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=633", "date": "2020-01-17T14:58:01", "name": "[libcamera-devel,v2,1/2] libcamera: pipeline: rkisp1: sync topology with upstream driver", "version": 2, "mbox": "https://patchwork.libcamera.org/series/633/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/2659/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/2659/checks/", "tags": {}, "headers": { "Return-Path": "<helen.koike@collabora.com>", "Received": [ "from bhuna.collabora.co.uk (bhuna.collabora.co.uk\n\t[IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 67B2060456\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 17 Jan 2020 15:58:13 +0100 (CET)", "from [127.0.0.1] (localhost [127.0.0.1])\n\t(Authenticated sender: koike) with ESMTPSA id 038BC294912" ], "From": "Helen Koike <helen.koike@collabora.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "laurent.pinchart@ideasonboard.com, kernel@collabora.com, heiko@sntech.de,\n\ttfiga@chromium.org, niklas.soderlund@ragnatech.se,\n\tjoacim.zetterling@gmail.com", "Date": "Fri, 17 Jan 2020 11:58:02 -0300", "Message-Id": "<20200117145802.3322874-2-helen.koike@collabora.com>", "X-Mailer": "git-send-email 2.24.0", "In-Reply-To": "<20200117145802.3322874-1-helen.koike@collabora.com>", "References": "<20200117145802.3322874-1-helen.koike@collabora.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 2/2] utils: rkisp1: sync topology with\n\tupstream driver in capture script", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Fri, 17 Jan 2020 14:58:13 -0000" }, "content": "rkisp1 kernel driver was merged upstream with minor changes in the\ntopology from the original driver libcamera based it's first support to\nrkisp1.\n\nAdapt libcamera capture script to work with upstream driver.\n\n* Remove subdevice dphy from the pipeline.\n* Add resizer in the pipeline.\n* Fix links.\n* Update entity names.\n\nSigned-off-by: Helen Koike <helen.koike@collabora.com>\n\n---\n\nchanges in v2:\n* New commit (splitted from previous one)\n---\n utils/rkisp1/rkisp1-capture.sh | 16 ++++++++--------\n 1 file changed, 8 insertions(+), 8 deletions(-)", "diff": "diff --git a/utils/rkisp1/rkisp1-capture.sh b/utils/rkisp1/rkisp1-capture.sh\nindex cffe9fe..4d09f5d 100755\n--- a/utils/rkisp1/rkisp1-capture.sh\n+++ b/utils/rkisp1/rkisp1-capture.sh\n@@ -68,14 +68,14 @@ configure_pipeline() {\n \n \t$mediactl -r\n \n-\t$mediactl -l \"'$sensor':0 -> 'rockchip-sy-mipi-dphy':0 [1]\"\n-\t$mediactl -l \"'rockchip-sy-mipi-dphy':1 -> 'rkisp1-isp-subdev':0 [1]\"\n-\t$mediactl -l \"'rkisp1-isp-subdev':2 -> 'rkisp1_mainpath':0 [1]\"\n+\t$mediactl -l \"'$sensor':0 -> 'rkisp1_isp':0 [1]\"\n+\t$mediactl -l \"'rkisp1_isp':2 -> 'rkisp1_resizer_mainpath':0 [1]\"\n \n \t$mediactl -V \"\\\"$sensor\\\":0 [$format]\"\n-\t$mediactl -V \"'rockchip-sy-mipi-dphy':1 [$format]\"\n-\t$mediactl -V \"'rkisp1-isp-subdev':0 [$format crop:(0,0)/$sensor_size]\"\n-\t$mediactl -V \"'rkisp1-isp-subdev':2 [fmt:$capture_mbus_code/$capture_size crop:(0,0)/$capture_size]\"\n+\t$mediactl -V \"'rkisp1_isp':0 [$format crop:(0,0)/$sensor_size]\"\n+\t$mediactl -V \"'rkisp1_isp':2 [fmt:$capture_mbus_code/$sensor_size crop:(0,0)/$sensor_size]\"\n+\t$mediactl -V \"'rkisp1_resizer_mainpath':0 [fmt:$capture_mbus_code/$sensor_size crop:(0,0)/$sensor_size]\"\n+\t$mediactl -V \"'rkisp1_resizer_mainpath':1 [fmt:$capture_mbus_code/$capture_size]\"\n }\n \n # Capture frames\n@@ -161,8 +161,8 @@ fi\n \n sensor_name=$1\n \n-modprobe mipi_dphy_sy\n-modprobe video_rkisp1\n+modprobe phy_rockchip_dphy_rx0\n+modprobe rockchip_isp1\n \n sensor=$(find_sensor $sensor_name) || exit\n mdev=$(find_media_device rkisp1) || exit\n", "prefixes": [ "libcamera-devel", "v2", "2/2" ] }