Patch Detail
Show a patch.
GET /api/patches/26581/?format=api
{ "id": 26581, "url": "https://patchwork.libcamera.org/api/patches/26581/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26581/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260422044736.24717-5-hpa@redhat.com>", "date": "2026-04-22T04:47:36", "name": "[v2,4/4] meson: Add ipa-signature-algo option", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "592837c39da6a6a3f7f7470585173edabc6f70e1", "submitter": { "id": 105, "url": "https://patchwork.libcamera.org/api/people/105/?format=api", "name": "Kate Hsuan", "email": "hpa@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26581/mbox/", "series": [ { "id": 5889, "url": "https://patchwork.libcamera.org/api/series/5889/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5889", "date": "2026-04-22T04:47:32", "name": "Implement ML-DSA-65 for Post-Quantum Cryptographic compliance", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5889/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26581/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26581/checks/", "tags": {}, "headers": { "Return-Path": "<kieran.bingham@ideasonboard.com>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": [ "parsemail@patchwork.libcamera.org", "kbingham@ideasonboard.com" ], "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 59E25BE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 27 Apr 2026 09:51:05 +0000 (UTC)", "from monstersaurus.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net\n\t[86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 57B048D4\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 27 Apr 2026 11:49:23 +0200 (CEST)", "from perceval.ideasonboard.com\n\tby perceval.ideasonboard.com with LMTP id CLQ1LLBS6GkIFQEA4E0KoQ\n\t(envelope-from <libcamera-devel-bounces@lists.libcamera.org>)\n\tfor <kbingham@ideasonboard.com>; Wed, 22 Apr 2026 06:46:40 +0200", "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\tby perceval.ideasonboard.com (Postfix) with ESMTPS\n\tid 900CD324;\tWed, 22 Apr 2026 06:46:40 +0200 (CEST)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EAAB462F07;\n\tWed, 22 Apr 2026 06:48:17 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9310B62EF7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 22 Apr 2026 06:48:15 +0200 (CEST)", "from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-341-qOSQIzzIMmuGmbagK1PBQw-1;\n\tWed, 22 Apr 2026 00:48:10 -0400", "from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.12]) (using\n\tTLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519\n\tserver-signature RSA-PSS (2048 bits) server-digest SHA256) (No client\n\tcertificate requested) by\n\tmx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with\n\tESMTPS id 0AE371956048; Wed, 22 Apr 2026 04:48:09 +0000 (UTC)", "from fedora.redhat.com (unknown [10.67.32.92])\n\tby mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id BCABF19560B7; Wed, 22 Apr 2026 04:48:06 +0000 (UTC)" ], "Authentication-Results": [ "perceval.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.a=rsa-sha256 header.s=mimecast20190719\n\theader.b=iFciKQZZ; dkim-atps=neutral", "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=redhat.com\n\theader.i=@redhat.com header.b=\"iFciKQZZ\"; \n\tdkim-atps=neutral" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1776833294;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=dUf+Wh8et3UJa0DjCN0pIiBnfbdNCIlmh9Mr66IL0OI=;\n\tb=iFciKQZZfAymF2yyNye0stS6BVJcNUnuz64lOftxolM7S4HWQX0qFS6QSVsMM6Uo/174OY\n\tZT+CsxQ+96MQ2EALz5Etj3xR/zDKv5XJnL7jwNjBgZU3Dgf/W+pLxNgIFysxzhk2cGuEvJ\n\tm5ZoT7tJO/Y3JSZtxl/Tu63LhPCqam0=", "X-MC-Unique": "qOSQIzzIMmuGmbagK1PBQw-1", "X-Mimecast-MFC-AGG-ID": "qOSQIzzIMmuGmbagK1PBQw_1776833289", "From": "Kate Hsuan <hpa@redhat.com>", "To": "libcamera-devel@lists.libcamera.org, =?utf-8?b?QmFybmFiw6FzIFDFkWN6?=\n\t=?utf-8?q?e?= <barnabas.pocze@ideasonboard.com>", "Cc": "Kate Hsuan <hpa@redhat.com>", "Subject": "[PATCH v2 4/4] meson: Add ipa-signature-algo option", "Date": "Wed, 22 Apr 2026 12:47:36 +0800", "Message-ID": "<20260422044736.24717-5-hpa@redhat.com>", "In-Reply-To": "<20260422044736.24717-1-hpa@redhat.com>", "References": "<20260422044736.24717-1-hpa@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.12", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "6cDFDei8vCTfjaffPSWgcJOu1rDxTbSslxighhJW24I_1776833289", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>", "X-TUID": "1i75PwcBXudo", "Resent-From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "Resent-To": "parsemail@patchwork.libcamera.org" }, "content": "Add a combo type \"ipa-signature-algo\" meson option to select signature\nalgorithms, including rsa-sha256 and ml-dsa-65.\nras-sha256 is the default setting for now.\n\nSigned-off-by: Kate Hsuan <hpa@redhat.com>\n---\n meson_options.txt | 8 ++++++++\n src/libcamera/meson.build | 6 ++++++\n src/meson.build | 14 +++++++++++---\n utils/gen-ipa-priv-key.sh | 16 ++++++++++++++--\n 4 files changed, 39 insertions(+), 5 deletions(-)", "diff": "diff --git a/meson_options.txt b/meson_options.txt\nindex 20baacc4..18488e6b 100644\n--- a/meson_options.txt\n+++ b/meson_options.txt\n@@ -46,6 +46,14 @@ option('gstreamer',\n value : 'auto',\n description : 'Compile libcamera GStreamer plugin')\n \n+option('ipa-signature-algo',\n+ type : 'combo',\n+ choices : [\n+ 'rsa-sha256',\n+ 'ml-dsa-65',\n+ ],\n+ description : 'Select a signature algorithm to sign IPA libraries.')\n+\n option('ipas',\n type : 'array',\n choices : ['ipu3', 'mali-c55', 'rkisp1', 'rpi/pisp', 'rpi/vc4', 'simple',\ndiff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\nindex 575408b2..55ba6c6d 100644\n--- a/src/libcamera/meson.build\n+++ b/src/libcamera/meson.build\n@@ -97,6 +97,12 @@ else\n endif\n endif\n \n+# comply with FIPS 204\n+signature_algo = get_option('ipa-signature-algo')\n+if signature_algo == 'ml-dsa-65'\n+ config_h.set('WITH_PQC', 1)\n+endif\n+\n if not libcrypto.found()\n warning('Neither gnutls nor libcrypto found, all IPA modules will be isolated')\n summary({'IPA modules signed with': 'None (modules will run isolated)'},\ndiff --git a/src/meson.build b/src/meson.build\nindex 9b63c8e8..7f8909b1 100644\n--- a/src/meson.build\n+++ b/src/meson.build\n@@ -15,11 +15,19 @@ summary({\n }, section : 'Paths')\n \n # Module Signing\n+signature_algo = get_option('ipa-signature-algo')\n openssl = find_program('openssl', required : false)\n if openssl.found()\n- ipa_priv_key = custom_target('ipa-priv-key',\n- output : ['ipa-priv-key.pem'],\n- command : [gen_ipa_priv_key, '@OUTPUT@'])\n+ if signature_algo == 'ml-dsa-65'\n+ ipa_priv_key = custom_target('ipa-priv-key',\n+ output : ['ipa-priv-key.pem'],\n+ command : [gen_ipa_priv_key, 'ML-DSA-65', '@OUTPUT@'])\n+ endif\n+ if signature_algo == 'rsa-sha256'\n+ ipa_priv_key = custom_target('ipa-priv-key',\n+ output : ['ipa-priv-key.pem'],\n+ command : [gen_ipa_priv_key, 'RSA', '@OUTPUT@'])\n+ endif\n config_h.set('HAVE_IPA_PUBKEY', 1)\n ipa_sign_module = true\n else\ndiff --git a/utils/gen-ipa-priv-key.sh b/utils/gen-ipa-priv-key.sh\nindex 2ca7b883..374377fc 100755\n--- a/utils/gen-ipa-priv-key.sh\n+++ b/utils/gen-ipa-priv-key.sh\n@@ -6,6 +6,18 @@\n #\n # Generate an RSA private key to sign IPA modules\n \n-key=\"$1\"\n+algo=\"$1\"\n+key=\"$2\"\n \n-openssl genpkey -algorithm RSA -out \"${key}\" -pkeyopt rsa_keygen_bits:2048\n+# Two possible algorithms: RSA and ML-DSA-65\n+# openssl genpkey -algorithm RSA -out \"${key}\" -pkeyopt rsa_keygen_bits:2048\n+# openssl genpkey -algorithm ML-DSA-65 -out \"${key}\"\n+\n+if [ \"$algo\" == \"RSA\" ]; then\n+ openssl genpkey -algorithm RSA -out \"${key}\" -pkeyopt rsa_keygen_bits:2048\n+elif [ \"$algo\" == \"ML-DSA-65\" ]; then\n+ openssl genpkey -algorithm ML-DSA-65 -out \"${key}\"\n+else\n+ echo \"Invalid algorithm: $algo\"\n+ exit 1\n+fi\n\\ No newline at end of file\n", "prefixes": [ "v2", "4/4" ] }