Patch Detail
Show a patch.
GET /api/patches/26562/?format=api
{ "id": 26562, "url": "https://patchwork.libcamera.org/api/patches/26562/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26562/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260424200255.356798-2-mzamazal@redhat.com>", "date": "2026-04-24T20:02:47", "name": "[RFC,v3,1/7] libcamera: software_isp: egl: Add gl_scale_param to createTexture2D()", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "5afc841a4dc23d8879a7236ee76b2460fe19482c", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26562/mbox/", "series": [ { "id": 5885, "url": "https://patchwork.libcamera.org/api/series/5885/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5885", "date": "2026-04-24T20:02:46", "name": "LSC for SoftISP simple pipeline", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5885/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26562/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26562/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 25184BE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 24 Apr 2026 20:03:17 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CFCD962F8D;\n\tFri, 24 Apr 2026 22:03:16 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5CECF62E6A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 24 Apr 2026 22:03:15 +0200 (CEST)", "from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-85-BNZA_94oO1GZTiIl425p8A-1;\n\tFri, 24 Apr 2026 16:03:08 -0400", "from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 8D1BB180057D; Fri, 24 Apr 2026 20:03:06 +0000 (UTC)", "from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.32.33])\n\tby mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 9EB6C3007572; Fri, 24 Apr 2026 20:03:03 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"eEpbEL5U\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1777060994;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=ZQ4ueoYJbOpftewiVwKy8XCGQ313wuqop8NXakiv0IY=;\n\tb=eEpbEL5UKzTrgpDdBBjYZw+Nf7B4LR5WYqi0av6wdgRzU3FWMDdNgMuMzlMtcgP7mgy/um\n\tAk7hyxbDXnLhmQNooW6kYJ/FCfQDw5gU6D+5jWy5vGfc5jF23VoWamWdnHgjzsqWHgABUy\n\tgH2llFKFrgC69dhNojIY5040lBvNiGA=", "X-MC-Unique": "BNZA_94oO1GZTiIl425p8A-1", "X-Mimecast-MFC-AGG-ID": "BNZA_94oO1GZTiIl425p8A_1777060987", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Xander Pronk <xander.c.pronk@gmail.com>,\n\tBryan O'Donoghue <bod.linux@nxsw.ie>,\n\tHans de Goede <johannes.goede@oss.qualcomm.com>,\n\tBryan O'Donoghue <bryan.odonoghue@linaro.org>,\n\tRick ten Wolde <rick_libcamera@wolde.info>,\n\tMilan Zamazal <mzamazal@redhat.com>", "Subject": "[RFC PATCH v3 1/7] libcamera: software_isp: egl: Add gl_scale_param\n\tto createTexture2D()", "Date": "Fri, 24 Apr 2026 22:02:47 +0200", "Message-ID": "<20260424200255.356798-2-mzamazal@redhat.com>", "In-Reply-To": "<20260424200255.356798-1-mzamazal@redhat.com>", "References": "<20260424200255.356798-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.4", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "g2JabhqnjFFl9d4ZDug6PbyHln42NB9XSObnqp8ZMms_1777060987", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Xander Pronk <xander.c.pronk@gmail.com>\n\nAdd a gl_scale_param to createTexture2D() to allow overriding\nthe currently hardcoded GL_NEAREST value. This is needed for\ngrid-based lens shading interpolation, which is implemented in followup\npatches.\n\nReviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\nCo-developed-by: Rick ten Wolde <rick_libcamera@wolde.info>\nSigned-off-by: Rick ten Wolde <rick_libcamera@wolde.info>\nSigned-off-by: Xander Pronk <xander.c.pronk@gmail.com>\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n include/libcamera/internal/egl.h | 3 ++-\n src/libcamera/egl.cpp | 8 +++++---\n src/libcamera/software_isp/debayer_egl.cpp | 4 +++-\n 3 files changed, 10 insertions(+), 5 deletions(-)", "diff": "diff --git a/include/libcamera/internal/egl.h b/include/libcamera/internal/egl.h\nindex 0ad2320b1..2496679b2 100644\n--- a/include/libcamera/internal/egl.h\n+++ b/include/libcamera/internal/egl.h\n@@ -103,7 +103,8 @@ public:\n \n \tint createInputDMABufTexture2D(eGLImage &eglImage, int fd);\n \tint createOutputDMABufTexture2D(eGLImage &eglImage, int fd);\n-\tvoid createTexture2D(eGLImage &eglImage, GLint format, uint32_t width, uint32_t height, void *data);\n+\tvoid createTexture2D(eGLImage &eglImage, GLint format, uint32_t width, uint32_t height,\n+\t\t\t const void *data, GLint glFilterParam);\n \n \tvoid pushEnv(std::vector<std::string> &shaderEnv, const char *str);\n \tvoid makeCurrent();\ndiff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp\nindex f65929470..9b50111a4 100644\n--- a/src/libcamera/egl.cpp\n+++ b/src/libcamera/egl.cpp\n@@ -212,13 +212,15 @@ int eGL::createOutputDMABufTexture2D(eGLImage &eglImage, int fd)\n * \\param[in] width Texture width in pixels\n * \\param[in] height Texture height in pixels\n * \\param[in] data Pointer to pixel data, or nullptr for uninitialised texture\n+ * \\param[in] glFilterParam GL texture filter setting\n *\n * Creates a 2D texture from a CPU-accessible memory buffer. The texture\n * is configured with nearest filtering and clamp-to-edge wrapping. This\n * is useful for uploading static data like lookup tables or uniform color\n * matrices to the GPU.\n */\n-void eGL::createTexture2D(eGLImage &eglImage, GLint format, uint32_t width, uint32_t height, void *data)\n+void eGL::createTexture2D(eGLImage &eglImage, GLint format, uint32_t width, uint32_t height,\n+\t\t\t const void *data, GLint glFilterParam)\n {\n \tASSERT(tid_ == Thread::currentId());\n \n@@ -229,8 +231,8 @@ void eGL::createTexture2D(eGLImage &eglImage, GLint format, uint32_t width, uint\n \tglTexImage2D(GL_TEXTURE_2D, 0, format, width, height, 0, format, GL_UNSIGNED_BYTE, data);\n \n \t// Nearest filtering\n-\tglTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_NEAREST);\n-\tglTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_NEAREST);\n+\tglTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, glFilterParam);\n+\tglTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, glFilterParam);\n \n \t// Wrap to edge to avoid edge artifacts\n \tglTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_S, GL_CLAMP_TO_EDGE);\ndiff --git a/src/libcamera/software_isp/debayer_egl.cpp b/src/libcamera/software_isp/debayer_egl.cpp\nindex 2ad258bca..08e513eaf 100644\n--- a/src/libcamera/software_isp/debayer_egl.cpp\n+++ b/src/libcamera/software_isp/debayer_egl.cpp\n@@ -502,7 +502,9 @@ int DebayerEGL::debayerGPU(MappedFrameBuffer &in, int out_fd, const DebayerParam\n \tegl_.makeCurrent();\n \n \t/* Create a standard texture input */\n-\tegl_.createTexture2D(*eglImageBayerIn_, glFormat_, inputConfig_.stride / bytesPerPixel_, height_, in.planes()[0].data());\n+\tegl_.createTexture2D(*eglImageBayerIn_, glFormat_,\n+\t\t\t inputConfig_.stride / bytesPerPixel_, height_,\n+\t\t\t in.planes()[0].data(), GL_NEAREST);\n \n \t/* Generate the output render framebuffer as render to texture */\n \tegl_.createOutputDMABufTexture2D(*eglImageBayerOut_, out_fd);\n", "prefixes": [ "RFC", "v3", "1/7" ] }