Patch Detail
Show a patch.
GET /api/patches/26560/?format=api
{ "id": 26560, "url": "https://patchwork.libcamera.org/api/patches/26560/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26560/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260424164029.3373853-1-laurent.pinchart@ideasonboard.com>", "date": "2026-04-24T16:40:29", "name": "ipa: rpi: awb_nn: Rename YamlObject to ValueNode", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "a955f9dfc11a495275259f09cdaf403a03339b62", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26560/mbox/", "series": [ { "id": 5884, "url": "https://patchwork.libcamera.org/api/series/5884/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5884", "date": "2026-04-24T16:40:29", "name": "ipa: rpi: awb_nn: Rename YamlObject to ValueNode", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5884/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26560/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26560/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AA870BE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 24 Apr 2026 16:40:33 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D23CA62F86;\n\tFri, 24 Apr 2026 18:40:32 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 60C6D62E6A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 24 Apr 2026 18:40:31 +0200 (CEST)", "from killaraus.ideasonboard.com\n\t(2001-14ba-703d-e500--2a1.rev.dnainternet.fi\n\t[IPv6:2001:14ba:703d:e500::2a1])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 240781A63\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 24 Apr 2026 18:38:51 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"V085Ec2H\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1777048731;\n\tbh=yHfGlhELAMph99EvusZ3tFSFaDdJoffTvtiLuV8K4Rw=;\n\th=From:To:Subject:Date:From;\n\tb=V085Ec2H0dAu4vQ5lO4+oMrFtsABf7CqW/kal8mWL6Edw4kI6tfl2dTAX4Rm5KMGV\n\toQ/gyoQv+UugEZNqaP6kgUGtk63w8HKT/VALr/lGe6ZdB6nXGD19R6a+DnqkddUPCE\n\tgisulJg5p6SQSGekvwWpwmWYt5NgqMACp5WEZL3A=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH] ipa: rpi: awb_nn: Rename YamlObject to ValueNode", "Date": "Fri, 24 Apr 2026 19:40:29 +0300", "Message-ID": "<20260424164029.3373853-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.53.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The global rename of YamlObject to ValueNode in commit 554c5c7fa174\nmissed awb_nn.cpp. Fix it.\n\nFixes: 554c5c7fa174 (\"libcamera: Rename YamlObject to ValueNode\")\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/rpi/controller/rpi/awb_nn.cpp | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)\n\n\nbase-commit: 7227dd4b4013f0e24584b4d370154c7e55a0a384", "diff": "diff --git a/src/ipa/rpi/controller/rpi/awb_nn.cpp b/src/ipa/rpi/controller/rpi/awb_nn.cpp\nindex c382f63d5f21..6543d8cb9b69 100644\n--- a/src/ipa/rpi/controller/rpi/awb_nn.cpp\n+++ b/src/ipa/rpi/controller/rpi/awb_nn.cpp\n@@ -47,7 +47,7 @@ namespace RPiController {\n \n struct AwbNNConfig {\n \tAwbNNConfig() = default;\n-\tint read(const libcamera::YamlObject ¶ms, AwbConfig &config);\n+\tint read(const libcamera::ValueNode ¶ms, AwbConfig &config);\n \n \t/* An empty model will check default locations for model.tflite */\n \tstd::string model;\n@@ -67,7 +67,7 @@ public:\n \t~AwbNN();\n \tchar const *name() const override;\n \tvoid initialise() override;\n-\tint read(const libcamera::YamlObject ¶ms) override;\n+\tint read(const libcamera::ValueNode ¶ms) override;\n \n protected:\n \tvoid doAwb() override;\n@@ -86,7 +86,7 @@ private:\n \tstd::unique_ptr<tflite::Interpreter> interpreter_;\n };\n \n-int AwbNNConfig::read(const libcamera::YamlObject ¶ms, AwbConfig &config)\n+int AwbNNConfig::read(const libcamera::ValueNode ¶ms, AwbConfig &config)\n {\n \tmodel = params[\"model\"].get<std::string>(\"\");\n \tminTemp = params[\"min_temp\"].get<float>(2800.0);\n@@ -146,7 +146,7 @@ char const *AwbNN::name() const\n \treturn NAME;\n }\n \n-int AwbNN::read(const libcamera::YamlObject ¶ms)\n+int AwbNN::read(const libcamera::ValueNode ¶ms)\n {\n \tint ret;\n \n", "prefixes": [] }