Patch Detail
Show a patch.
GET /api/patches/26558/?format=api
{ "id": 26558, "url": "https://patchwork.libcamera.org/api/patches/26558/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26558/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260423230059.3180987-37-laurent.pinchart@ideasonboard.com>", "date": "2026-04-23T23:00:58", "name": "[v3,36/37] pipeline: simple: Rename supported_devices configuration option to devices", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "83de7697d188d5524f1d678182155980dff42211", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26558/mbox/", "series": [ { "id": 5883, "url": "https://patchwork.libcamera.org/api/series/5883/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5883", "date": "2026-04-23T23:00:22", "name": "libcamera: Global configuration file improvements", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5883/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26558/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26558/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 96D53BDCB5\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 23 Apr 2026 23:02:08 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 41B3362FED;\n\tFri, 24 Apr 2026 01:02:08 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EA48062FDC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 24 Apr 2026 01:01:50 +0200 (CEST)", "from killaraus.ideasonboard.com\n\t(2001-14ba-703d-e500--2a1.rev.dnainternet.fi\n\t[IPv6:2001:14ba:703d:e500::2a1])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 782F01283\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 24 Apr 2026 01:00:11 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZNzHmJYh\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1776985211;\n\tbh=5b5Us//VC9ngZ8EFKZcwDDPkvfzdu56EO8WwJv/8lRI=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=ZNzHmJYhQ9mSUjVpujSKOfJmpaMuP0s0VI3qAlQ8gNtDTWn31uatbZAF2C4t9S8cx\n\tv/MldPANLFBdOAD9f+aNGQFrtdC+1QtdWaFOIwy0lTaqoGMCwSGZlJOCmfMRPQhefP\n\tAqi1f98zF61nVnjS8RvrsEUJM2G1ouz0MB89sw1w=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v3 36/37] pipeline: simple: Rename supported_devices\n\tconfiguration option to devices", "Date": "Fri, 24 Apr 2026 02:00:58 +0300", "Message-ID": "<20260423230059.3180987-37-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260423230059.3180987-1-laurent.pinchart@ideasonboard.com>", "References": "<20260423230059.3180987-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The pipelines.simple.supported_devices configuration entry list\nper-device options for the simple pipeline handler. Rename\n\"supported_devices\" to \"devices\" to indicate its role more clearly.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\nReviewed-by: Isaac Scott <isaac.scott@ideasonboard.com>\n---\n Documentation/runtime_configuration.rst | 6 +++---\n src/libcamera/pipeline/simple/simple.cpp | 2 +-\n 2 files changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/Documentation/runtime_configuration.rst b/Documentation/runtime_configuration.rst\nindex fa7fb34f8eff..9dfa61e72ce8 100644\n--- a/Documentation/runtime_configuration.rst\n+++ b/Documentation/runtime_configuration.rst\n@@ -43,7 +43,7 @@ file structure:\n - ... # pipeline name\n pipelines:\n simple:\n- supported_devices:\n+ devices:\n - driver: # driver name, e.g. `mxc-isi`\n software_isp: # true/false\n software_isp:\n@@ -78,7 +78,7 @@ Configuration file example\n - simple\n pipelines:\n simple:\n- supported_devices:\n+ devices:\n - driver: mxc-isi\n software_isp: true\n software_isp:\n@@ -150,7 +150,7 @@ LIBCAMERA_SOFTISP_MODE, software_isp.mode\n \n Example value: ``gpu``\n \n-pipelines.simple.supported_devices.driver, pipelines.simple.supported_devices.software_isp\n+pipelines.simple.devices.driver, pipelines.simple.devices.software_isp\n Override whether software ISP is enabled for the given driver.\n \n Example `driver` value: ``mxc-isi``\ndiff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex c6fe12d65b18..9ae220fc8860 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -1881,7 +1881,7 @@ bool SimplePipelineHandler::matchDevice(std::shared_ptr<MediaDevice> media,\n \tswIspEnabled_ = info.swIspEnabled;\n \tconst GlobalConfiguration &configuration = cameraManager()->_d()->configuration();\n \tfor (const ValueNode &entry :\n-\t configuration.configuration()[\"pipelines\"][\"simple\"][\"supported_devices\"]\n+\t configuration.configuration()[\"pipelines\"][\"simple\"][\"devices\"]\n \t\t .asList()) {\n \t\tauto name = entry[\"driver\"].get<std::string>();\n \t\tif (name == info.driver) {\n", "prefixes": [ "v3", "36/37" ] }