Patch Detail
Show a patch.
GET /api/patches/26538/?format=api
{ "id": 26538, "url": "https://patchwork.libcamera.org/api/patches/26538/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26538/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260423230059.3180987-17-laurent.pinchart@ideasonboard.com>", "date": "2026-04-23T23:00:38", "name": "[v3,16/37] libcamera: value_node: Add mutable adapters", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "5c7603d20f58e74206d29359b143ac69e19bbda0", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26538/mbox/", "series": [ { "id": 5883, "url": "https://patchwork.libcamera.org/api/series/5883/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5883", "date": "2026-04-23T23:00:22", "name": "libcamera: Global configuration file improvements", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5883/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26538/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26538/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 36B37BDCB5\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 23 Apr 2026 23:01:34 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A9B6662FB5;\n\tFri, 24 Apr 2026 01:01:33 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9666462F86\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 24 Apr 2026 01:01:23 +0200 (CEST)", "from killaraus.ideasonboard.com\n\t(2001-14ba-703d-e500--2a1.rev.dnainternet.fi\n\t[IPv6:2001:14ba:703d:e500::2a1])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 11B2CC75\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 24 Apr 2026 00:59:44 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"u7leya8D\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1776985184;\n\tbh=271LkudYLoFrF9u1x3Js8ZS6P6JtAxU6W1j3htfU7r8=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=u7leya8DYkqDz3nHNWCwqg2+LWMBet7fVFHnoPjqCIi7y6CXAxRMv7kz7wit528A6\n\tRv/LZupmOFbiGoQOCG5NjBrsySaxNbDAnpZYewPOVEhW9EybsYOTIKwv3H7fQhO0mi\n\tLSWCzCWW/ykBEaoIF71/I1UG5s1e3SZz8cR7k54c=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v3 16/37] libcamera: value_node: Add mutable adapters", "Date": "Fri, 24 Apr 2026 02:00:38 +0300", "Message-ID": "<20260423230059.3180987-17-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260423230059.3180987-1-laurent.pinchart@ideasonboard.com>", "References": "<20260423230059.3180987-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The ValueNode class was initially designed to store read-only property\ntrees. It is useful to also provide mutable access. Add non-const\nadapters and iterators and adapters. This allows obtaining a mutable\nValueNode instance when traversing a tree.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\nReviewed-by: Isaac Scott <isaac.scott@ideasonboard.com>\n---\n include/libcamera/internal/value_node.h | 32 ++++++++++++++++++-------\n src/libcamera/value_node.cpp | 10 ++++++++\n 2 files changed, 34 insertions(+), 8 deletions(-)", "diff": "diff --git a/include/libcamera/internal/value_node.h b/include/libcamera/internal/value_node.h\nindex 16e6660e8329..b51d2f4b610b 100644\n--- a/include/libcamera/internal/value_node.h\n+++ b/include/libcamera/internal/value_node.h\n@@ -143,17 +143,31 @@ public:\n \t\t}\n \t};\n \n-\tclass DictAdapter : public Adapter<DictIterator<const ValueNode,\n-\t\t\t\t\t\t\tValueContainer::const_iterator>,\n-\t\t\t\t\t const ValueContainer>\n+\tclass DictAdapter : public Adapter<DictIterator<ValueNode,\n+\t\t\t\t\t\t\tValueContainer::iterator>,\n+\t\t\t\t\t ValueContainer>\n \t{\n \tpublic:\n \t\tusing key_type = std::string;\n \t};\n \n-\tclass ListAdapter : public Adapter<ListIterator<const ValueNode,\n-\t\t\t\t\t\t\tValueContainer::const_iterator>,\n-\t\t\t\t\t const ValueContainer>\n+\tclass ListAdapter : public Adapter<ListIterator<ValueNode,\n+\t\t\t\t\t\t\tValueContainer::iterator>,\n+\t\t\t\t\t ValueContainer>\n+\t{\n+\t};\n+\n+\tclass ConstDictAdapter : public Adapter<DictIterator<const ValueNode,\n+\t\t\t\t\t\t\t ValueContainer::const_iterator>,\n+\t\t\t\t\t\tconst ValueContainer>\n+\t{\n+\tpublic:\n+\t\tusing key_type = std::string;\n+\t};\n+\n+\tclass ConstListAdapter : public Adapter<ListIterator<const ValueNode,\n+\t\t\t\t\t\t\t ValueContainer::const_iterator>,\n+\t\t\t\t\t\tconst ValueContainer>\n \t{\n \t};\n #endif /* __DOXYGEN__ */\n@@ -211,8 +225,10 @@ public:\n \t\t\t.set(*this, std::forward<T>(value));\n \t}\n \n-\tDictAdapter asDict() const { return DictAdapter{ list_ }; }\n-\tListAdapter asList() const { return ListAdapter{ list_ }; }\n+\tDictAdapter asDict() { return DictAdapter{ list_ }; }\n+\tListAdapter asList() { return ListAdapter{ list_ }; }\n+\tConstDictAdapter asDict() const { return ConstDictAdapter{ list_ }; }\n+\tConstListAdapter asList() const { return ConstListAdapter{ list_ }; }\n \n \tconst ValueNode &operator[](std::size_t index) const;\n \ndiff --git a/src/libcamera/value_node.cpp b/src/libcamera/value_node.cpp\nindex 324419f02bb6..e2dd455d3f1e 100644\n--- a/src/libcamera/value_node.cpp\n+++ b/src/libcamera/value_node.cpp\n@@ -335,6 +335,11 @@ template struct ValueNode::Accessor<std::vector<uint32_t>>;\n template struct ValueNode::Accessor<std::vector<std::string>>;\n #endif /* __DOXYGEN__ */\n \n+/**\n+ * \\fn ValueNode::asDict()\n+ * \\copydoc ValueNode::asDict() const\n+ */\n+\n /**\n * \\fn ValueNode::asDict() const\n * \\brief Wrap a dictionary ValueNode in an adapter that exposes iterators\n@@ -355,6 +360,11 @@ template struct ValueNode::Accessor<std::vector<std::string>>;\n * \\return An adapter of unspecified type compatible with range-based for loops\n */\n \n+/**\n+ * \\fn ValueNode::asList()\n+ * \\copydoc ValueNode::asList() const\n+ */\n+\n /**\n * \\fn ValueNode::asList() const\n * \\brief Wrap a list ValueNode in an adapter that exposes iterators\n", "prefixes": [ "v3", "16/37" ] }