Patch Detail
Show a patch.
GET /api/patches/26525/?format=api
{ "id": 26525, "url": "https://patchwork.libcamera.org/api/patches/26525/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26525/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260423230059.3180987-4-laurent.pinchart@ideasonboard.com>", "date": "2026-04-23T23:00:25", "name": "[v3,03/37] libcamera: yaml_parser: Rename Container to ValueContainer", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "3195bee3ef19d69c4b36971f318b8c3fb1938814", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26525/mbox/", "series": [ { "id": 5883, "url": "https://patchwork.libcamera.org/api/series/5883/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5883", "date": "2026-04-23T23:00:22", "name": "libcamera: Global configuration file improvements", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5883/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26525/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26525/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 37C7EBDCB5\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 23 Apr 2026 23:01:11 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B373062F72;\n\tFri, 24 Apr 2026 01:01:10 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EB2A462F5D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 24 Apr 2026 01:01:04 +0200 (CEST)", "from killaraus.ideasonboard.com\n\t(2001-14ba-703d-e500--2a1.rev.dnainternet.fi\n\t[IPv6:2001:14ba:703d:e500::2a1])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6FD0E9A6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 24 Apr 2026 00:59:25 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"aahURiow\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1776985165;\n\tbh=t1nl6sy8MFRvVdFtecv66RVa3fw0XbtCuJV0u3f75g4=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=aahURiowuKva5O9wQpOh5PDgwbHFgWGtfOxGNoGKA2sDpNkmHmicfgsafXkuORhdS\n\toxGcv8FqPyHl62We6avC1ewRsEmMBX2t6arcd0tb/vKY6vf0QNDD6NkR8EiYNC2HmS\n\tdXC7g5mNq4OCK5uJGAYOW9hc0pnBZPJU6tPKooeU=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v3 03/37] libcamera: yaml_parser: Rename Container to\n\tValueContainer", "Date": "Fri, 24 Apr 2026 02:00:25 +0300", "Message-ID": "<20260423230059.3180987-4-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260423230059.3180987-1-laurent.pinchart@ideasonboard.com>", "References": "<20260423230059.3180987-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The YamlObject class defines two private types, Container and\nListContainer. The format is an alias to std::vector<Value>, and is used\nto store child elements. The latter hasn't been used since commit\n38987e165c28 (\"libcamera: yaml_parser: Preserve order of items in\ndictionary\").\n\nTo prepare for upcoming reworks that will use the name 'Container' as a\ntemplate parameter, rename Container to ValueContainer for clarity, and\ndrop the unused ListContainer type.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\nReviewed-by: Isaac Scott <isaac.scott@ideasonboard.com>\n---\n include/libcamera/internal/yaml_parser.h | 13 ++++++-------\n 1 file changed, 6 insertions(+), 7 deletions(-)", "diff": "diff --git a/include/libcamera/internal/yaml_parser.h b/include/libcamera/internal/yaml_parser.h\nindex 8c7916565946..03d6a05e2d0f 100644\n--- a/include/libcamera/internal/yaml_parser.h\n+++ b/include/libcamera/internal/yaml_parser.h\n@@ -36,8 +36,7 @@ private:\n \t\tstd::unique_ptr<YamlObject> value;\n \t};\n \n-\tusing Container = std::vector<Value>;\n-\tusing ListContainer = std::vector<std::unique_ptr<YamlObject>>;\n+\tusing ValueContainer = std::vector<Value>;\n \n public:\n #ifndef __DOXYGEN__\n@@ -48,7 +47,7 @@ public:\n \t\tusing difference_type = std::ptrdiff_t;\n \t\tusing iterator_category = std::forward_iterator_tag;\n \n-\t\tIterator(typename Container::const_iterator it)\n+\t\tIterator(typename ValueContainer::const_iterator it)\n \t\t\t: it_(it)\n \t\t{\n \t\t}\n@@ -77,14 +76,14 @@ public:\n \t\t}\n \n \tprotected:\n-\t\tContainer::const_iterator it_;\n+\t\tValueContainer::const_iterator it_;\n \t};\n \n \ttemplate<typename Iterator>\n \tclass Adapter\n \t{\n \tpublic:\n-\t\tAdapter(const Container &container)\n+\t\tAdapter(const ValueContainer &container)\n \t\t\t: container_(container)\n \t\t{\n \t\t}\n@@ -100,7 +99,7 @@ public:\n \t\t}\n \n \tprotected:\n-\t\tconst Container &container_;\n+\t\tconst ValueContainer &container_;\n \t};\n \n \tclass ListIterator : public Iterator<ListIterator>\n@@ -232,7 +231,7 @@ private:\n \tType type_;\n \n \tstd::string value_;\n-\tContainer list_;\n+\tValueContainer list_;\n \tstd::map<std::string, YamlObject *, std::less<>> dictionary_;\n };\n \n", "prefixes": [ "v3", "03/37" ] }