Patch Detail
Show a patch.
GET /api/patches/26503/?format=api
{ "id": 26503, "url": "https://patchwork.libcamera.org/api/patches/26503/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26503/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260408115606.12417-2-johannes.goede@oss.qualcomm.com>", "date": "2026-04-08T11:56:03", "name": "[v4,1/4] libcamera: ipa_manager: Create IPA by name", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "ec0fc5cc2e78f750eb21d29d91cd8db3d7266d73", "submitter": { "id": 242, "url": "https://patchwork.libcamera.org/api/people/242/?format=api", "name": "Hans de Goede", "email": "johannes.goede@oss.qualcomm.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26503/mbox/", "series": [ { "id": 5876, "url": "https://patchwork.libcamera.org/api/series/5876/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5876", "date": "2026-04-08T11:56:02", "name": "ipa: Allow IPA creation by name", "version": 4, "mbox": "https://patchwork.libcamera.org/series/5876/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26503/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26503/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2856DBDCBD\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 8 Apr 2026 11:56:18 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DA21262E05;\n\tWed, 8 Apr 2026 13:56:17 +0200 (CEST)", "from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com\n\t[205.220.168.131])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7396362CE6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 8 Apr 2026 13:56:14 +0200 (CEST)", "from pps.filterd (m0279864.ppops.net [127.0.0.1])\n\tby mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n\t638B3JbF1314439 for <libcamera-devel@lists.libcamera.org>;\n\tWed, 8 Apr 2026 11:56:12 GMT", "from mail-qt1-f200.google.com (mail-qt1-f200.google.com\n\t[209.85.160.200])\n\tby mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dd8d6k1ud-1\n\t(version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 08 Apr 2026 11:56:12 +0000 (GMT)", "by mail-qt1-f200.google.com with SMTP id\n\td75a77b69052e-50b4661881eso76311621cf.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 08 Apr 2026 04:56:12 -0700 (PDT)", "from t14s\n\t(2001-1c00-0c32-7800-07d4-cca3-ec08-7ac7.cable.dynamic.v6.ziggo.nl.\n\t[2001:1c00:c32:7800:7d4:cca3:ec08:7ac7])\n\tby smtp.gmail.com with ESMTPSA id\n\ta640c23a62f3a-b9c3cec6c1csm639102066b.39.2026.04.08.04.56.09\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 08 Apr 2026 04:56:09 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=qualcomm.com header.i=@qualcomm.com\n\theader.b=\"ZOXGJUKc\"; dkim=pass (2048-bit key;\n\tunprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n\theader.b=\"OVYxJS2n\"; dkim-atps=neutral", "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n\tcc:content-transfer-encoding:content-type:date:from:in-reply-to\n\t:message-id:mime-version:references:subject:to; s=qcppdkim1; bh=\n\tZeFap/o+BzZok25lJzZc2bbQ1DHpfD2gW77I8yesimo=; b=ZOXGJUKcarFF+oZX\n\twykiGGD09/0CATmbPr6GZFS4/4dHkZ6dAIHsB4YVy1rjWYg8BYlRm977CPtNtpuj\n\tGJTl7jcoezsZ1H+nwKGQqAKo3G6bEmNpdB9rhvZ5ju3OBcy5DwhgOfIZa0psmEmp\n\tjREiC9vtmJRLqHgbTuIxtw/+ZoVEOgLzJ9Ls8N8pSV2+KGmHYHWd16mK6224JBpS\n\t/FmfCEPoWlmQ8F6+UIzeiXgyyTFd2AhN8OgEsodxo9tAqVWVEfFF2LpNVThg/+dV\n\tjrY9I+R7lRoMfUyocaPvH8iz4GhNlOAWsAtJXlmjra6ljlHbMkEgB6IgeTq3J+Oy\n\tpAc/hA==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=oss.qualcomm.com; s=google; t=1775649371; x=1776254171;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=ZeFap/o+BzZok25lJzZc2bbQ1DHpfD2gW77I8yesimo=;\n\tb=OVYxJS2nqNi0xtT9MZYgf2ldKHt/sNLf4CtR7zMvFzyv0aFwQFjjejP28KRwwZK1v6\n\tec/t8yTVzSbD9iceJN23wLZAXDCyHclpvetoG175yCh//VsTgdgMwLY/7Y+SluAZ5s7R\n\t60DaOHxOnWkCiLyq0ZsSHZqRZRnCyr3LAUsu4kWOGk8/gDX8twh6pYQnQK+CTrNduoa1\n\tJANhOMF8WKUtI092GtwuTVZpGU+2rgi7DZiaGH652zCMmbY/hPLaKuWykDEPun/pjb3a\n\tXVrdg3ux3YZZ5iP08/YP4qT2A/hS4M67o8VXV0UmckIVPVn9+52PBOgPS2fxH9QBjGGG\n\t9WfQ==" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20251104; t=1775649371; x=1776254171;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=ZeFap/o+BzZok25lJzZc2bbQ1DHpfD2gW77I8yesimo=;\n\tb=cB8Xno2BlFbK4l4Qt8vfYxrEDQT1P2BcSI0qWJ4q7d3P52NexsTPNdm9TTuJdVDozm\n\tf3cyQyswxsHxPZWSw+mKotnsSZkC4Ltw6ueofFumqVIl31jCFHClqboMnlpv9Vv+SihI\n\tV9tigWpgi03o/przi6oW42JskTRVc7xOK6Jswcq2hkCIxpVV0mYqktJidKLagHpk2bEy\n\taCN2cK8mMR8tejIjm8UyNXKo9Ai68EJ+NtgFdrSEdVYv4ot9ZFikiasiWrs2peXgMStb\n\t3nAW6JpdOULJ2+D57XyuyY9tkxKQ+8ISIY8JiRLR5BT/Ay/4ABfvh+6johVohQ89fDPf\n\tnS2A==", "X-Gm-Message-State": "AOJu0YwmU0JK16Sh5JKpenUaljBaVylIFnGGZoV9GOnLcsmha/rKc0C8\n\tWz0DZPzZp/sQhqo8Cvu8lSIeyeBoNeatbcUVaSJN5okbcrinKWpRA79hZsldAd374zCRn0/dK1l\n\t9eNm6o7xUrJQPsEe2wtFshX4Pb4fvhLZOgFihqOJaPBKAyUvwAhT31ozIdlGsLHhBWI9AtsSQ1h\n\tFGZ+Bl5s2M", "X-Gm-Gg": "AeBDies0+MPgFVOYRdwaLBTGe+qslVw7Z/CotUjKgFsbrJQGD7DfF4GWU1SeskGFnxy\n\tmlZoLm+cfOlF83rPrj/yB6oxD0dDeuss+fPtwVi2aI35i4hC64fVJ+94SUsrwIUtjGpz5fbt62l\n\tRPGN8hWOFhdEJOlPFly6eo/HuaOReRUe9Kt9I7k+xZTeHolgN/Nja9/ffiqFg2yoSQHqwYvtFfS\n\t2gDv9q6MAGwOFAsVyBvjs9tmt7Z0/APwZfSMT7USUsO6J0Z7wfRM3Pt8nG6O3a1hMp+JO5Renb9\n\tur+jraVbebCfBZ9xk7RjA0OyFoSA4Z1MZCByy23cluVbCrVvrnLYyLEVL51TmDb3zSrmXZmCcBH\n\tGKDWBZG812trMIud92VZmcPn94lpnoM4EreeAHULh4O1zOxY3cn7CzIlMBHHC0Ptb6f8Icyo7dR\n\tkVdvWc1TZqESPSqdPdvkuuFSw17dn6AGog", "X-Received": [ "by 2002:ac8:7d11:0:b0:50d:65ec:a071 with SMTP id\n\td75a77b69052e-50d65eca37cmr293008111cf.5.1775649371085; \n\tWed, 08 Apr 2026 04:56:11 -0700 (PDT)", "by 2002:ac8:7d11:0:b0:50d:65ec:a071 with SMTP id\n\td75a77b69052e-50d65eca37cmr293007661cf.5.1775649370587; \n\tWed, 08 Apr 2026 04:56:10 -0700 (PDT)" ], "From": "Hans de Goede <johannes.goede@oss.qualcomm.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Loic Poulain <loic.poulain@oss.qualcomm.com>, Hans de Goede\n\t<johannes.goede@oss.qualcomm.com>, Jacopo Mondi\n\t<jacopo.mondi@ideasonboard.com>, Kieran Bingham\n\t<kieran.bingham@ideasonboard.com>, =?utf-8?q?Niklas_S=C3=B6derlund?=\n\t<niklas.soderlund+renesas@ragnatech.se>", "Subject": "[PATCH v4 1/4] libcamera: ipa_manager: Create IPA by name", "Date": "Wed, 8 Apr 2026 13:56:03 +0200", "Message-ID": "<20260408115606.12417-2-johannes.goede@oss.qualcomm.com>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260408115606.12417-1-johannes.goede@oss.qualcomm.com>", "References": "<20260408115606.12417-1-johannes.goede@oss.qualcomm.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-Proofpoint-ORIG-GUID": "2sijeyNDIAqrBOpweLPofam0ihl77cUo", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwNDA4MDExMCBTYWx0ZWRfX8bipDw8B3HZe\n\tJFxT7PXoFfehnT9Z71kv36wxTGiUxdMyErd/9qkAgrbhCn1lzN5UxZzNpD9E2Nh46tPyJKvVXd3\n\tAOdSZVJUHwMQ9dUIIznEKZOzjZAeqj9OVZAhhHuGjR38txC3SeCPo27K+46IYSt7lgwirj3Yvrw\n\tEhf3rJ0W5/ccV7879slqHuR/+bomN3/8qcW2aifjTa3OKTUTWS2Qmadp1kZq2QLcx3wCiZ8Fiuv\n\t309uFwjAKPs/WeYPuBJ3o4OB2K8NHSo/EU9C92I4VjaA6KNRdiymDSjMfwq0UGBdv91wRnLUfN2\n\trAC9R5O3p/CwLuMOZAZEGJIh/t2YZ9N+HFUohnEq+NBnPyYcQebrg6SqSzSfNXRqMOPKfG1Sdjl\n\tLgUNUoj20f21VTtQWOV6n59vmVuVexpbs7TUVe4Hv6yeVzQIh1XE1lT76SMoinkmohJT6gWI5iH\n\t9zKOtk0onpvR6QxcDKg==", "X-Authority-Analysis": "v=2.4 cv=GN041ONK c=1 sm=1 tr=0 ts=69d6425c cx=c_pps\n\ta=JbAStetqSzwMeJznSMzCyw==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10\n\ta=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22\n\ta=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=P1BnusSwAAAA:8\n\ta=EUspDBNiAAAA:8 a=TsfB_WN0WhEKZ-rE8qoA:9 a=3ZKOabzyN94A:10\n\ta=QEXdDO2ut3YA:10\n\ta=uxP6HrT_eTzRwkO_Te1X:22 a=D0XLA9XvdZm18NrgonBM:22", "X-Proofpoint-GUID": "2sijeyNDIAqrBOpweLPofam0ihl77cUo", "X-Proofpoint-Virus-Version": "vendor=baseguard\n\tengine=ICAP:2.0.293, Aquarius:18.0.1143, Hydra:6.1.51,\n\tFMLib:17.12.100.49\n\tdefinitions=2026-04-08_03,2026-04-08_01,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n\tlowpriorityscore=0 priorityscore=1501 phishscore=0 suspectscore=0\n\tclxscore=1015 spamscore=0 adultscore=0 bulkscore=0 impostorscore=0\n\tmalwarescore=0 classifier=typeunknown authscore=0 authtc= authcc=\n\troute=outbound adjust=0 reason=mlx scancount=1\n\tengine=8.22.0-2604010000\n\tdefinitions=main-2604080110", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Currently createIPA() / IPAManager::module() assume that there is a 1:1\nrelationship between pipeline handlers and IPAs and IPA matching is done\nbased on matching the pipe to ipaModuleInfo.pipelineName[].\n\nOne way to allow using a single IPA with multiple pipelines would be to\nallow the IPA to declare itself compatible with more than one pipeline,\nturning ipaModuleInfo.pipelineName[] into e.g. a vector. But the way\nipaModuleInfo is loaded as an ELF symbol requires it to be a simple flat\nC-struct.\n\nInstead, move the IPA creation procedure to be name-based, introducing\nan overload to IPAManager::createIPA(pipe, name, minVer, maxVer) that\nallows to specify the name of the IPA module to match. Pipeline handlers\nthat wants to use their name as matching criteria can continue doing so\nusing the already existing createIPA(pipe, minVer, maxVer) overload.\n\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nTested-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>\nSigned-off-by: Hans de Goede <johannes.goede@oss.qualcomm.com>\n---\n include/libcamera/internal/ipa_manager.h | 13 +++++++--\n include/libcamera/internal/ipa_module.h | 4 +--\n src/libcamera/ipa_manager.cpp | 34 +++++++++++++++++++-----\n src/libcamera/ipa_module.cpp | 12 ++++-----\n 4 files changed, 47 insertions(+), 16 deletions(-)", "diff": "diff --git a/include/libcamera/internal/ipa_manager.h b/include/libcamera/internal/ipa_manager.h\nindex f8ce78016..4c01e76f1 100644\n--- a/include/libcamera/internal/ipa_manager.h\n+++ b/include/libcamera/internal/ipa_manager.h\n@@ -34,12 +34,13 @@ public:\n \n \ttemplate<typename T>\n \tstatic std::unique_ptr<T> createIPA(PipelineHandler *pipe,\n+\t\t\t\t\t const char *name,\n \t\t\t\t\t uint32_t minVersion,\n \t\t\t\t\t uint32_t maxVersion)\n \t{\n \t\tCameraManager *cm = pipe->cameraManager();\n \t\tIPAManager *self = cm->_d()->ipaManager();\n-\t\tIPAModule *m = self->module(pipe, minVersion, maxVersion);\n+\t\tIPAModule *m = self->module(name, minVersion, maxVersion);\n \t\tif (!m)\n \t\t\treturn nullptr;\n \n@@ -60,6 +61,14 @@ public:\n \t\treturn proxy;\n \t}\n \n+\ttemplate<typename T>\n+\tstatic std::unique_ptr<T> createIPA(PipelineHandler *pipe,\n+\t\t\t\t\t uint32_t minVersion,\n+\t\t\t\t\t uint32_t maxVersion)\n+\t{\n+\t\treturn createIPA<T>(pipe, pipe->name(), minVersion, maxVersion);\n+\t}\n+\n #if HAVE_IPA_PUBKEY\n \tstatic const PubKey &pubKey()\n \t{\n@@ -72,7 +81,7 @@ private:\n \t\t std::vector<std::string> &files);\n \tunsigned int addDir(const char *libDir, unsigned int maxDepth = 0);\n \n-\tIPAModule *module(PipelineHandler *pipe, uint32_t minVersion,\n+\tIPAModule *module(const char *name, uint32_t minVersion,\n \t\t\t uint32_t maxVersion);\n \n \tbool isSignatureValid(IPAModule *ipa) const;\ndiff --git a/include/libcamera/internal/ipa_module.h b/include/libcamera/internal/ipa_module.h\nindex 15f19492c..a0a53764e 100644\n--- a/include/libcamera/internal/ipa_module.h\n+++ b/include/libcamera/internal/ipa_module.h\n@@ -36,8 +36,8 @@ public:\n \n \tIPAInterface *createInterface();\n \n-\tbool match(PipelineHandler *pipe,\n-\t\t uint32_t minVersion, uint32_t maxVersion) const;\n+\tbool match(const char *name, uint32_t minVersion,\n+\t\t uint32_t maxVersion) const;\n \n protected:\n \tstd::string logPrefix() const override;\ndiff --git a/src/libcamera/ipa_manager.cpp b/src/libcamera/ipa_manager.cpp\nindex 35171d097..f62a4ee5f 100644\n--- a/src/libcamera/ipa_manager.cpp\n+++ b/src/libcamera/ipa_manager.cpp\n@@ -247,15 +247,15 @@ unsigned int IPAManager::addDir(const char *libDir, unsigned int maxDepth)\n \n /**\n * \\brief Retrieve an IPA module that matches a given pipeline handler\n- * \\param[in] pipe The pipeline handler\n+ * \\param[in] name The IPA module string identifier\n * \\param[in] minVersion Minimum acceptable version of IPA module\n * \\param[in] maxVersion Maximum acceptable version of IPA module\n */\n-IPAModule *IPAManager::module(PipelineHandler *pipe, uint32_t minVersion,\n+IPAModule *IPAManager::module(const char *name, uint32_t minVersion,\n \t\t\t uint32_t maxVersion)\n {\n \tfor (const auto &module : modules_) {\n-\t\tif (module->match(pipe, minVersion, maxVersion))\n+\t\tif (module->match(name, minVersion, maxVersion))\n \t\t\treturn module.get();\n \t}\n \n@@ -263,12 +263,34 @@ IPAModule *IPAManager::module(PipelineHandler *pipe, uint32_t minVersion,\n }\n \n /**\n- * \\fn IPAManager::createIPA()\n- * \\brief Create an IPA proxy that matches a given pipeline handler\n- * \\param[in] pipe The pipeline handler that wants a matching IPA proxy\n+ * \\fn IPAManager::createIPA(PipelineHandler *pipe, const char *ipaName, uint32_t minVersion, uint32_t maxVersion)\n+ * \\brief Create an IPA proxy that matches the requested name and version\n+ * \\param[in] pipe The pipeline handler that wants to create the IPA module\n+ * \\param[in] ipaName The IPA module name\n * \\param[in] minVersion Minimum acceptable version of IPA module\n * \\param[in] maxVersion Maximum acceptable version of IPA module\n *\n+ * Create an IPA module using \\a name as the matching identifier. This overload\n+ * allows pipeline handlers to create an IPA module by specifying its name\n+ * instead of relying on the fact that the IPA module matches the pipeline\n+ * handler's one.\n+ *\n+ * \\return A newly created IPA proxy, or nullptr if no matching IPA module is\n+ * found or if the IPA proxy fails to initialize\n+ */\n+\n+/**\n+ * \\fn IPAManager::createIPA(PipelineHandler *pipe, uint32_t minVersion, uint32_t maxVersion)\n+ * \\brief Create an IPA proxy that matches the pipeline handler name and the\n+ * requested version\n+ * \\param[in] pipe The pipeline handler that wants to create the IPA module\n+ * \\param[in] minVersion Minimum acceptable version of IPA module\n+ * \\param[in] maxVersion Maximum acceptable version of IPA module\n+ *\n+ * Create an IPA module using the pipeline handler name as the matching\n+ * identifier. This overload allows pipeline handler to create an IPA module\n+ * whose name matches the pipeline handler one.\n+ *\n * \\return A newly created IPA proxy, or nullptr if no matching IPA module is\n * found or if the IPA proxy fails to initialize\n */\ndiff --git a/src/libcamera/ipa_module.cpp b/src/libcamera/ipa_module.cpp\nindex e6ea61e44..0bd6f1462 100644\n--- a/src/libcamera/ipa_module.cpp\n+++ b/src/libcamera/ipa_module.cpp\n@@ -463,21 +463,21 @@ IPAInterface *IPAModule::createInterface()\n \n /**\n * \\brief Verify if the IPA module matches a given pipeline handler\n- * \\param[in] pipe Pipeline handler to match with\n+ * \\param[in] name The IPA module name\n * \\param[in] minVersion Minimum acceptable version of IPA module\n * \\param[in] maxVersion Maximum acceptable version of IPA module\n *\n- * This function checks if this IPA module matches the \\a pipe pipeline handler,\n+ * This function checks if this IPA module matches the requested \\a name\n * and the input version range.\n *\n- * \\return True if the pipeline handler matches the IPA module, or false otherwise\n+ * \\return True if the IPA module matches, or false otherwise\n */\n-bool IPAModule::match(PipelineHandler *pipe,\n-\t\t uint32_t minVersion, uint32_t maxVersion) const\n+bool IPAModule::match(const char *name, uint32_t minVersion,\n+\t\t uint32_t maxVersion) const\n {\n \treturn info_.pipelineVersion >= minVersion &&\n \t info_.pipelineVersion <= maxVersion &&\n-\t !strcmp(info_.pipelineName, pipe->name());\n+\t !strcmp(info_.name, name);\n }\n \n std::string IPAModule::logPrefix() const\n", "prefixes": [ "v4", "1/4" ] }