Patch Detail
Show a patch.
GET /api/patches/26501/?format=api
{ "id": 26501, "url": "https://patchwork.libcamera.org/api/patches/26501/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26501/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260408075540.53309-5-hpa@redhat.com>", "date": "2026-04-08T07:55:40", "name": "[4/4] meson: Add \"fips\" meson option to enable ML-DSA", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "b8f2d9a49179e5584cb0aa618645c98e8ce300af", "submitter": { "id": 105, "url": "https://patchwork.libcamera.org/api/people/105/?format=api", "name": "Kate Hsuan", "email": "hpa@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26501/mbox/", "series": [ { "id": 5875, "url": "https://patchwork.libcamera.org/api/series/5875/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5875", "date": "2026-04-08T07:55:36", "name": "Implement ML-DSA-65 for Post-Quantum Cryptographic compliance", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5875/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26501/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26501/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 73F32BDCBD\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 8 Apr 2026 07:56:40 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1F8F862DD3;\n\tWed, 8 Apr 2026 09:56:40 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B6AD362DB7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 8 Apr 2026 09:56:38 +0200 (CEST)", "from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-300-tTIq0DV8OTCCZbpFEmlzhg-1;\n\tWed, 08 Apr 2026 03:56:36 -0400", "from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS\n\tid 6B2CC1956089 for <libcamera-devel@lists.libcamera.org>;\n\tWed, 8 Apr 2026 07:56:35 +0000 (UTC)", "from fedora.redhat.com (unknown [10.67.32.15])\n\tby mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id B1DAB300019F; Wed, 8 Apr 2026 07:56:33 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"gHJuV6Kt\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1775634997;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=zR3E2P0FfHLaNh+kZBSbcg+8eM35S78nVWlxvV9aViM=;\n\tb=gHJuV6Ktd9IoDpGeH3cJ6pq5R1XYexO6ADiHBI6pREgBVc4Fbb6GQAqMxrvp+jpaj+tc7g\n\tQPg9IOBvnLZpyGtvS2EFZH+jjeV4uoKpFFZl83PoOE9634+puz/rWvZi62QdbP2VjsIGPg\n\tMltaNu8pMwllZysDm+/jnhEgeCiVHQA=", "X-MC-Unique": "tTIq0DV8OTCCZbpFEmlzhg-1", "X-Mimecast-MFC-AGG-ID": "tTIq0DV8OTCCZbpFEmlzhg_1775634995", "From": "Kate Hsuan <hpa@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Kate Hsuan <hpa@redhat.com>", "Subject": "[PATCH 4/4] meson: Add \"fips\" meson option to enable ML-DSA", "Date": "Wed, 8 Apr 2026 15:55:40 +0800", "Message-ID": "<20260408075540.53309-5-hpa@redhat.com>", "In-Reply-To": "<20260408075540.53309-1-hpa@redhat.com>", "References": "<20260408075540.53309-1-hpa@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.4", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "g973dwkU6IvoTWAA_Ddc3VM75SkLmQl4SnAc5cS_WwE_1775634995", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add a boolean type \"fips\" meson option to enable ML-SDA. If fips=false,\nthe RSA-SHA256 will be used.\n\nSigned-off-by: Kate Hsuan <hpa@redhat.com>\n---\n meson_options.txt | 5 +++++\n src/libcamera/meson.build | 6 ++++++\n src/meson.build | 13 ++++++++++---\n utils/gen-ipa-priv-key.sh | 16 ++++++++++++++--\n 4 files changed, 35 insertions(+), 5 deletions(-)", "diff": "diff --git a/meson_options.txt b/meson_options.txt\nindex c27e377a..c89167fb 100644\n--- a/meson_options.txt\n+++ b/meson_options.txt\n@@ -26,6 +26,11 @@ option('doc_werror',\n value : false,\n description : 'Treat documentation warnings as errors')\n \n+option('fips',\n+ type : 'boolean',\n+ value : false,\n+ description : 'Sign IPA library using ML-DSA (FIPS 204)')\n+\n option('gstreamer',\n type : 'feature',\n value : 'auto',\ndiff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\nindex d1594358..aed962c4 100644\n--- a/src/libcamera/meson.build\n+++ b/src/libcamera/meson.build\n@@ -118,6 +118,12 @@ else\n endif\n endif\n \n+# comply with FIPS 204\n+with_fips = get_option('fips')\n+if with_fips\n+ config_h.set('WITH_FIPS', 1)\n+endif\n+\n if not libcrypto.found()\n warning('Neither gnutls nor libcrypto found, all IPA modules will be isolated')\n summary({'IPA modules signed with': 'None (modules will run isolated)'},\ndiff --git a/src/meson.build b/src/meson.build\nindex 9b63c8e8..f1493341 100644\n--- a/src/meson.build\n+++ b/src/meson.build\n@@ -15,11 +15,18 @@ summary({\n }, section : 'Paths')\n \n # Module Signing\n+with_fips = get_option('fips')\n openssl = find_program('openssl', required : false)\n if openssl.found()\n- ipa_priv_key = custom_target('ipa-priv-key',\n- output : ['ipa-priv-key.pem'],\n- command : [gen_ipa_priv_key, '@OUTPUT@'])\n+ if with_fips\n+ ipa_priv_key = custom_target('ipa-priv-key',\n+ output : ['ipa-priv-key.pem'],\n+ command : [gen_ipa_priv_key, 'ML-DSA-65', '@OUTPUT@'])\n+ else\n+ ipa_priv_key = custom_target('ipa-priv-key',\n+ output : ['ipa-priv-key.pem'],\n+ command : [gen_ipa_priv_key, 'RSA', '@OUTPUT@'])\n+ endif\n config_h.set('HAVE_IPA_PUBKEY', 1)\n ipa_sign_module = true\n else\ndiff --git a/utils/gen-ipa-priv-key.sh b/utils/gen-ipa-priv-key.sh\nindex 2ca7b883..374377fc 100755\n--- a/utils/gen-ipa-priv-key.sh\n+++ b/utils/gen-ipa-priv-key.sh\n@@ -6,6 +6,18 @@\n #\n # Generate an RSA private key to sign IPA modules\n \n-key=\"$1\"\n+algo=\"$1\"\n+key=\"$2\"\n \n-openssl genpkey -algorithm RSA -out \"${key}\" -pkeyopt rsa_keygen_bits:2048\n+# Two possible algorithms: RSA and ML-DSA-65\n+# openssl genpkey -algorithm RSA -out \"${key}\" -pkeyopt rsa_keygen_bits:2048\n+# openssl genpkey -algorithm ML-DSA-65 -out \"${key}\"\n+\n+if [ \"$algo\" == \"RSA\" ]; then\n+ openssl genpkey -algorithm RSA -out \"${key}\" -pkeyopt rsa_keygen_bits:2048\n+elif [ \"$algo\" == \"ML-DSA-65\" ]; then\n+ openssl genpkey -algorithm ML-DSA-65 -out \"${key}\"\n+else\n+ echo \"Invalid algorithm: $algo\"\n+ exit 1\n+fi\n\\ No newline at end of file\n", "prefixes": [ "4/4" ] }