Patch Detail
Show a patch.
GET /api/patches/26481/?format=api
{ "id": 26481, "url": "https://patchwork.libcamera.org/api/patches/26481/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26481/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260407153427.1825999-42-laurent.pinchart@ideasonboard.com>", "date": "2026-04-07T15:34:26", "name": "[v2,41/42] pipeline: simple: Rename supported_devices configuration option to devices", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "83de7697d188d5524f1d678182155980dff42211", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26481/mbox/", "series": [ { "id": 5873, "url": "https://patchwork.libcamera.org/api/series/5873/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5873", "date": "2026-04-07T15:33:45", "name": "libcamera: Global configuration file improvements", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5873/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26481/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26481/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1311BC32F9\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 7 Apr 2026 15:35:31 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A6AB162E56;\n\tTue, 7 Apr 2026 17:35:30 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EB97262E57\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 7 Apr 2026 17:35:24 +0200 (CEST)", "from killaraus.ideasonboard.com\n\t(2001-14ba-703d-e500--2a1.rev.dnainternet.fi\n\t[IPv6:2001:14ba:703d:e500::2a1])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 6D842A30\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 7 Apr 2026 17:33:57 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"R0U5YpSW\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1775576037;\n\tbh=cz9oRoSTp2JnMN7xrp9ulGjuDga103W7o8UPUbdTr6k=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=R0U5YpSWUKbzr4aaLHfbeLjD+8qCPUIOSuZZeerVfCnA/Ih3WkK0RpbP7cnIDKq1p\n\tPIXvBvwbg/nJbvlaKgz6eHner5PdU2qTh3+O3DOp5I/ttUAWOrOrtUqArnUtAf1Eyz\n\tbMYPbrdCi5rNJjY9VGQqdai0hqUksHGn3jLaNGNQ=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v2 41/42] pipeline: simple: Rename supported_devices\n\tconfiguration option to devices", "Date": "Tue, 7 Apr 2026 18:34:26 +0300", "Message-ID": "<20260407153427.1825999-42-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260407153427.1825999-1-laurent.pinchart@ideasonboard.com>", "References": "<20260407153427.1825999-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The pipelines.simple.supported_devices configuration entry list\nper-device options for the simple pipeline handler. Rename\n\"supported_devices\" to \"devices\" to indicate its role more clearly.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n Documentation/runtime_configuration.rst | 6 +++---\n src/libcamera/pipeline/simple/simple.cpp | 2 +-\n 2 files changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/Documentation/runtime_configuration.rst b/Documentation/runtime_configuration.rst\nindex fa7fb34f8eff..9dfa61e72ce8 100644\n--- a/Documentation/runtime_configuration.rst\n+++ b/Documentation/runtime_configuration.rst\n@@ -43,7 +43,7 @@ file structure:\n - ... # pipeline name\n pipelines:\n simple:\n- supported_devices:\n+ devices:\n - driver: # driver name, e.g. `mxc-isi`\n software_isp: # true/false\n software_isp:\n@@ -78,7 +78,7 @@ Configuration file example\n - simple\n pipelines:\n simple:\n- supported_devices:\n+ devices:\n - driver: mxc-isi\n software_isp: true\n software_isp:\n@@ -150,7 +150,7 @@ LIBCAMERA_SOFTISP_MODE, software_isp.mode\n \n Example value: ``gpu``\n \n-pipelines.simple.supported_devices.driver, pipelines.simple.supported_devices.software_isp\n+pipelines.simple.devices.driver, pipelines.simple.devices.software_isp\n Override whether software ISP is enabled for the given driver.\n \n Example `driver` value: ``mxc-isi``\ndiff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex c6fe12d65b18..9ae220fc8860 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -1881,7 +1881,7 @@ bool SimplePipelineHandler::matchDevice(std::shared_ptr<MediaDevice> media,\n \tswIspEnabled_ = info.swIspEnabled;\n \tconst GlobalConfiguration &configuration = cameraManager()->_d()->configuration();\n \tfor (const ValueNode &entry :\n-\t configuration.configuration()[\"pipelines\"][\"simple\"][\"supported_devices\"]\n+\t configuration.configuration()[\"pipelines\"][\"simple\"][\"devices\"]\n \t\t .asList()) {\n \t\tauto name = entry[\"driver\"].get<std::string>();\n \t\tif (name == info.driver) {\n", "prefixes": [ "v2", "41/42" ] }