Patch Detail
Show a patch.
GET /api/patches/26460/?format=api
{ "id": 26460, "url": "https://patchwork.libcamera.org/api/patches/26460/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26460/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260407153427.1825999-21-laurent.pinchart@ideasonboard.com>", "date": "2026-04-07T15:34:05", "name": "[v2,20/42] libcamera: value_node: Add constructor with value", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "097c13cd9662cf52f3f413cb42150375db10067f", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26460/mbox/", "series": [ { "id": 5873, "url": "https://patchwork.libcamera.org/api/series/5873/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5873", "date": "2026-04-07T15:33:45", "name": "libcamera: Global configuration file improvements", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5873/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26460/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26460/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4D8D6C3304\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 7 Apr 2026 15:35:03 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9B50162DF7;\n\tTue, 7 Apr 2026 17:35:02 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6198B62DEE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 7 Apr 2026 17:34:56 +0200 (CEST)", "from killaraus.ideasonboard.com\n\t(2001-14ba-703d-e500--2a1.rev.dnainternet.fi\n\t[IPv6:2001:14ba:703d:e500::2a1])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id C37536DC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 7 Apr 2026 17:33:28 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Qjy3nDnW\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1775576009;\n\tbh=srDjWtA9sSjt/lKH4vSR14aLiLHWhPBzw6YG5ZzPnMs=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=Qjy3nDnWL98QH4VStsZCXK9gz3IgdEGTLnDXymLL6Np3hW94lKjMvQOKIYd9o1zXV\n\tzwg2RI+G4sBa3i5WuzMauk4ABcT8q4LBFBExOGdbEgnkrpv4H+VLGTvN4bBwqIbCLn\n\tu4DIpocO8O9wG2Ewp02RHAQJfPzKxmRPpJFa14Mg=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v2 20/42] libcamera: value_node: Add constructor with value", "Date": "Tue, 7 Apr 2026 18:34:05 +0300", "Message-ID": "<20260407153427.1825999-21-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260407153427.1825999-1-laurent.pinchart@ideasonboard.com>", "References": "<20260407153427.1825999-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The new constructor takes a value, allowing creation of a leaf ValueNode\nwith a value in a single operation instead of having to call set() on an\nempty node.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\nChanges since v1:\n\n- Initialize type_ to Empty\n---\n include/libcamera/internal/value_node.h | 8 ++++++++\n src/libcamera/value_node.cpp | 7 +++++++\n 2 files changed, 15 insertions(+)", "diff": "diff --git a/include/libcamera/internal/value_node.h b/include/libcamera/internal/value_node.h\nindex e42aa9ba0ce0..a7f916e22bc8 100644\n--- a/include/libcamera/internal/value_node.h\n+++ b/include/libcamera/internal/value_node.h\n@@ -143,6 +143,14 @@ public:\n #endif /* __DOXYGEN__ */\n \n \tValueNode();\n+\n+\ttemplate<typename T>\n+\tValueNode(T &&value)\n+\t\t: type_(Type::Empty)\n+\t{\n+\t\tset(std::forward<T>(value));\n+\t}\n+\n \t~ValueNode();\n \n \tbool isValue() const\ndiff --git a/src/libcamera/value_node.cpp b/src/libcamera/value_node.cpp\nindex 52ccf432fb96..6c9e2239165b 100644\n--- a/src/libcamera/value_node.cpp\n+++ b/src/libcamera/value_node.cpp\n@@ -44,6 +44,13 @@ ValueNode::ValueNode()\n {\n }\n \n+/**\n+ * \\fn template<typename T> ValueNode::ValueNode(T &&value)\n+ * \\brief Construct a ValueNode instance with a value\n+ * \\tparam T Type of the value\n+ * \\param[in] value The value\n+ */\n+\n ValueNode::~ValueNode() = default;\n \n /**\n", "prefixes": [ "v2", "20/42" ] }